Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-6568

Duplicated files on review - race condition

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Medium
    • Resolution: Fixed
    • 3.1.0
    • 3.5.0
    • None
    • None

    Description

      I can see occasionally duplicated files created on a single review. I was able to replicate this issue by adding several changes to the same review at a time.
      Scenario to reproduce:

      1. create empty review
      2. add content, browse for changesets
      3. pick up a branch/commiter so you can see several changesets with checkboxes. Changesets should be touching same files.
      4. quickly check several checkboxes, don't wait for previous to complete when selecting next
      5. notice some paths were duplicated on the review

      The problem does not exhibit itself when checkboxes are selected one after other, when waiting for the previous one to complete.

      Most likely same issue can be caused by several REST actions or API calls to add content to review.

      Edit: This might also trigger for other cases, unrelated to concurrent requests (see FECRU-3438 and https://atlaseye.atlassian.com/cru/CR-BAM-5260)

      Attachments

        Issue Links

          Activity

            People

              tom@atlassian.com Tom Davies
              pswiecicki Piotr Swiecicki
              Votes:
              3 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - Not Specified
                  Not Specified
                  Logged:
                  Time Spent - 55m
                  55m