Uploaded image for project: 'Crucible'
  1. Crucible
  2. CRUC-3805

Reloading Inline Comments in FF 3.6 Causes NPE

    XMLWordPrintable

Details

    Description

      NullPointerException can be reproduced in Firefox 3.6.7 by doing the following:

      1. User A creates a review and adds comments. Assign's User B as the reviewer.
      2. User B adds comments to the review.
      3. In User A's screen, the notification pop-up comes up in the bottom right corner and the user click's Reload (in Firefox).

      The following NPE is generated (full stack trace attached as well as screenshot):

      java.lang.NullPointerException
              at com.cenqua.crucible.actions.RetrieveCommentsAjaxAction.generateComments(RetrieveCommentsAjaxAction.java:134)
              at com.cenqua.crucible.actions.RetrieveCommentsAjaxAction.execute(RetrieveCommentsAjaxAction.java:181)
      

      The offending code is as follows:

      if (inlineComments == null) {
          inlineComments = new HashSet<InlineComment>();
      }
      inlineComments.add(inlineComment);
      frxsToRetrieve.put(inlineComment.getFrx(), inlineComments);
      

      For some reason inlineComment is set to null.

      Attachments

        1. error.tiff
          159 kB
        2. npe.txt
          12 kB

        Activity

          People

            Unassigned Unassigned
            dhansen@atlassian.com Dylan Hansen [Atlassian]
            Votes:
            2 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: