Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-80123

Struts does not reflect Text-Encoding setting change immediately

XMLWordPrintable

      The following Struts properties are loaded on startup by ConfluenceStrutsSettings via ConfluenceStrutsConfigurationProvider (and reloaded on plugin install/uninstall):

      • struts.i18n.encoding
      • struts.multipart.maxFileSize (custom property)

      However, these property values should immediately reflect Confluence settings as set by `/admin/viewgeneralconfig.action`

      A Strut configuration reload should be triggered when those settings are changed. However, Struts has no mechanism to wait until completion of any pending requests prior to triggering the reload. So reloading immediately will cause any pending requests to malfunction including the request that changed these properties. A delayed reload of between 0.25-0.5s seems to remedy this issue (in the integration tests), however, it causes integration tests for the OfficeConnector plugin to fail. We are yet to investigate this further.

      Workaround

      Currently, for `struts.multipart.maxFileSize`, we are using the workaround of retrieving the AttachmentMaxFileSize directly from the SettingsService from ConfluenceJakartaMultipartRequest. So this functionality is not affected.

      We have no workaround for the text encoding property, and it will not be reflected in Struts until a server restart or plugin install/uninstall.

        1. image-2022-10-07-14-26-34-173.png
          image-2022-10-07-14-26-34-173.png
          159 kB

            [CONFSERVER-80123] Struts does not reflect Text-Encoding setting change immediately

            Alex Cooksey made changes -
            Remote Link New: This issue links to "Page (Confluence)" [ 885874 ]
            Alex Cooksey made changes -
            Remote Link Original: This issue links to "Page (Confluence)" [ 706192 ]
            Jordan Anslow made changes -
            Status Original: Waiting for Release [ 12075 ] New: Closed [ 6 ]
            Kusal Kithul-Godage made changes -
            Status Original: Awaiting Merge [ 10064 ] New: Waiting for Release [ 12075 ]
            Kusal Kithul-Godage made changes -
            QA Demo Status Original: Not Done [ 14330 ] New: Not Needed [ 14332 ]
            Status Original: In Review [ 10051 ] New: Awaiting Merge [ 10064 ]
            Kusal Kithul-Godage made changes -
            Link New: This issue relates to CONFSERVER-81006 [ CONFSERVER-81006 ]
            Kusal Kithul-Godage made changes -
            Fix Version/s New: 8.5.5 [ 106525 ]
            Kusal Kithul-Godage made changes -
            Comment [ A fix for this issue is available in Confluence Server and Data Center 8.0.0.
            [Upgrade|https://www.atlassian.com/software/confluence/download-archives?utm_source=confluence_bugfix&utm_campaign=confluence_bugfix&utm_medium=email] now or check out the [Release Notes|https://confluence.atlassian.com/display/DOC/Confluence+8.0+Release+Notes?utm_source=confluence_bugfix&utm_campaign=confluence_bugfix&utm_medium=email] to see what other issues are resolved. ]
            Kusal Kithul-Godage made changes -
            QA Kickoff Status Original: Not Done [ 14234 ] New: Not Needed [ 14236 ]
            Status Original: In Progress [ 3 ] New: In Review [ 10051 ]
            Kusal Kithul-Godage made changes -
            Status Original: Ready for Development [ 10049 ] New: In Progress [ 3 ]

              854eef6f5746 Kusal Kithul-Godage
              854eef6f5746 Kusal Kithul-Godage
              Affected customers:
              0 This affects my team
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: