[CONFSERVER-52102] Broken Attachment Link in JIRA Activity Stream Gadget

Type: Bug
Resolution: Fixed
Priority: Medium
Fix Version/s: 6.14.0
Affects Version/s: 6.1.0, 6.1.2, 6.3.4, 6.4.0, 6.9.0
Component/s: Integrations - Jira
Labels:

Support reference count:
47
Symptom Severity:
Severity 3 - Minor
UIS:
30
Bug Fix Policy:
View Atlassian Server bug fix policy

Summary

Confluence attachment is rendered as a broken link when viewed in JIRA Activity Stream gadget from JIRA and Activity Stream gadget from Confluence.

Environment

Confluence 6.1.0, 6.1.2
JIRA 7.3.3, 7.3.5

Steps to Reproduce

Set up application links between JIRA and Confluence
Add attachment in an existing Confluence page
See JIRA Activity Stream gadget from JIRA Dashboard

Expected Results

The attachment is rendered correctly

Actual Results

The attachment is rendered as a broken link
Opening the attachment in a new tab will result in a System Error page with below error:

Cause
java.lang.NullPointerException
at com.atlassian.confluence.servlet.download.AttachmentDownload.getStreamForDownload(AttachmentDownload.java:105)
Stack Trace:[hide]
java.lang.NullPointerException
at com.atlassian.confluence.servlet.download.AttachmentDownload.getStreamForDownload(AttachmentDownload.java:105)
at com.atlassian.confluence.servlet.download.ServeAfterTransactionDownload$StreamResultCallback.doInTransaction(ServeAfterTransactionDownload.java:110)
at org.springframework.transaction.support.TransactionTemplate.execute(TransactionTemplate.java:133)
at com.atlassian.confluence.servlet.download.ServeAfterTransactionDownload.getStreamInTransaction(ServeAfterTransactionDownload.java:36)
at com.atlassian.confluence.servlet.download.ServeAfterTransactionDownload.serveFile(ServeAfterTransactionDownload.java:42)

Notes

JIRA Activity Stream gadget can render the attachment correctly when JIRA 7.3.3 is integrated with Confluence 5.10.5
The same URL is used for linking the attachment when integrated with Confluence 5.10.5 and 6.1.0, for example http://10.60.2.82:8090//download/attachments

Workaround

Open the attachment link in a new tab and remove one of the 2 forward slashes between the Base URL and download/attachments. E.g. from:

http://10.60.2.82:8090//download/attachments

http://10.60.2.82:8090/download/attachments

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List

123.jpg
31 kB
07/Apr/2017 2:03 AM
1234.JPG
37 kB
07/Apr/2017 2:12 AM
12345.JPG
52 kB
07/Apr/2017 2:12 AM
123456.JPG
16 kB
07/Apr/2017 2:18 AM
Screen Shot 2018-02-16 at 9.10.44 am.png
135 kB
15/Feb/2018 10:11 PM

is incorporated by

JRASERVER-65090 subsequent Confluence images not showing correctly in JIRA activity stream

Closed

Michael Swansegar made changes - 02/Nov/2019 4:46 PM

Comment

[ This is too complex for atlassian...

It's a web based product that doesn't know how to handle URLs.

This says a lot about their technical competence or product management priorities.

Everyday I use a web application I always have to override the URL said no one EVER. ]

Michael Swansegar made changes - 02/Nov/2019 4:45 PM

Comment

[ one line of code that takes months to fix. ]

Bespin Global Admin added a comment - 26/Oct/2019 3:01 AM - edited

Well, it still remains for confluence 7.0.3 with a very specific case.

When someone shares the confluence page to others at least 2 people, then the gadget mentions the page is shared with the other person. However, the profile photo path of the person has two slashes such as https://example.com//download/attachments/5472359/user-avatar and cannot see the photo, logging the errors.

--------------------------
Attributes
--------------------------
javax.servlet.forward.request_uri: //download/attachments/5472359/user-avatar
javax.servlet.forward.context_path:
javax.servlet.forward.servlet_path: /download
javax.servlet.forward.path_info: /attachments/5472359/user-avatar
javax.servlet.forward.mapping: org.apache.catalina.core.ApplicationMapping$MappingImpl@376f34de
javax.servlet.error.status_code: 500
com.atlassian.confluence.impl.profiling.DecoratorTimings: com.atlassian.confluence.impl.profiling.DecoratorTimings@1fbc1721
com.opensymphony.sitemesh.APPLIED_ONCE: true
__cleanup_recursion_counter: 0
javax.servlet.error.message:
javax.servlet.error.servlet_name: file-server
com.atlassian.confluence.web.filter.validateparam.RequestParamValidationFilter_already_filtered: true
atlassian.core.seraph.original.url: /500page.jsp
com.atlassian.labs.botkiller.BotKillerFilter: true
com.atlassian.gzipfilter.GzipFilter_already_filtered: true
Confluence-Request-Time: 1572058631091
B3-TraceId: 6a9e3c11d71761
loginfilter.already.filtered: true
javax.servlet.error.request_uri: //download/attachments/5472359/user-avatar
com.atlassian.core.filters.HeaderSanitisingFilter_already_filtered: true
com.atlassian.prettyurls.filter.PrettyUrlsSiteMeshFixupFilter: true
com.atlassian.confluence.web.ConfluenceJohnsonFilter_already_filtered: true
javax.servlet.error.exception: java.lang.NullPointerException
os_securityfilter_already_filtered: true
com.atlassian.seraph.auth.LoginReason: OK
com.atlassian.prettyurls.filter.PrettyUrlsSiteMeshFilter: true
--------------------------
Parameters
--------------------------
caused by: java.lang.NullPointerException
at com.atlassian.confluence.servlet.download.AttachmentDownload.getStreamForDownload(AttachmentDownload.java:108)

Bespin Global Admin added a comment - 26/Oct/2019 3:01 AM - edited Well, it still remains for confluence 7.0.3 with a very specific case. When someone shares the confluence page to others at least 2 people, then the gadget mentions the page is shared with the other person. However, the profile photo path of the person has two slashes such as https://example.com//download/attachments/5472359/user-avatar and cannot see the photo, logging the errors. -------------------------- Attributes -------------------------- javax.servlet.forward.request_uri: //download/attachments/5472359/user-avatar javax.servlet.forward.context_path: javax.servlet.forward.servlet_path: /download javax.servlet.forward.path_info: /attachments/5472359/user-avatar javax.servlet.forward.mapping: org.apache.catalina.core.ApplicationMapping$MappingImpl@376f34de javax.servlet.error.status_code: 500 com.atlassian.confluence.impl.profiling.DecoratorTimings: com.atlassian.confluence.impl.profiling.DecoratorTimings@1fbc1721 com.opensymphony.sitemesh.APPLIED_ONCE: true __cleanup_recursion_counter: 0 javax.servlet.error.message: javax.servlet.error.servlet_name: file-server com.atlassian.confluence.web.filter.validateparam.RequestParamValidationFilter_already_filtered: true atlassian.core.seraph.original.url: /500page.jsp com.atlassian.labs.botkiller.BotKillerFilter: true com.atlassian.gzipfilter.GzipFilter_already_filtered: true Confluence-Request-Time: 1572058631091 B3-TraceId: 6a9e3c11d71761 loginfilter.already.filtered: true javax.servlet.error.request_uri: //download/attachments/5472359/user-avatar com.atlassian.core.filters.HeaderSanitisingFilter_already_filtered: true com.atlassian.prettyurls.filter.PrettyUrlsSiteMeshFixupFilter: true com.atlassian.confluence.web.ConfluenceJohnsonFilter_already_filtered: true javax.servlet.error.exception: java.lang.NullPointerException os_securityfilter_already_filtered: true com.atlassian.seraph.auth.LoginReason: OK com.atlassian.prettyurls.filter.PrettyUrlsSiteMeshFilter: true -------------------------- Parameters -------------------------- caused by: java.lang.NullPointerException at com.atlassian.confluence.servlet.download.AttachmentDownload.getStreamForDownload(AttachmentDownload.java:108)

Zhenhuan Zhou (Inactive) added a comment - 22/Jan/2019 10:49 PM

A fix for this issue is available to Server and Data Center customers in Confluence 6.14.0
Upgrade now or check out the Release Notes to see what other issues are resolved.

Zhenhuan Zhou (Inactive) added a comment - 22/Jan/2019 10:49 PM A fix for this issue is available to Server and Data Center customers in Confluence 6.14.0 Upgrade now or check out the Release Notes to see what other issues are resolved.

Zhenhuan Zhou (Inactive) made changes - 22/Jan/2019 2:50 AM

Resolution		New: Fixed [ 1 ]
Status	Original: Waiting for Release [ 12075 ]	New: Closed [ 6 ]

SET Analytics Bot made changes - 17/Jan/2019 12:08 AM

UIS

Original: 31

New: 30

SET Analytics Bot made changes - 15/Jan/2019 12:14 AM

UIS

Original: 30

New: 31

SET Analytics Bot made changes - 11/Jan/2019 12:11 AM

Support reference count	Original: 46	New: 47
UIS	Original: 24	New: 30

SET Analytics Bot made changes - 21/Dec/2018 12:13 AM

Support reference count	Original: 45	New: 46
UIS	Original: 18	New: 24

SET Analytics Bot made changes - 04/Dec/2018 12:28 AM

UIS

Original: 24

New: 18

Assignee:: Duy Truong Luong

Reporter:: Zul NS [Atlassian]

Affected customers:: 82 This affects my team

Watchers:: 92 Start watching this issue

Created:: 30/Mar/2017 5:30 AM

Updated:: 02/Nov/2019 4:46 PM

Resolved:: 22/Jan/2019 2:50 AM

Details

Description

Summary

Environment

Steps to Reproduce

Expected Results

Actual Results

Notes

Workaround

Attachments

Attachments

Issue Links

Forms

Activity

Collapse comment: Bespin Global Admin added a comment - 26/Oct/2019 3:01 AM, Edited by Bespin Global Admin - 26/Oct/2019 3:03 AM

Expand comment: Bespin Global Admin added a comment - 26/Oct/2019 3:01 AM, Edited by Bespin Global Admin - 26/Oct/2019 3:03 AM

Collapse comment: Zhenhuan Zhou (Inactive) added a comment - 22/Jan/2019 10:49 PM

Expand comment: Zhenhuan Zhou (Inactive) added a comment - 22/Jan/2019 10:49 PM

People

Dates