Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-51182

Team Calendars source code not available on my.atlassian.com for licensed users

    • 0
    • 0
    • We collect Confluence feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      NOTE: This suggestion is for Confluence Server. Using Confluence Cloud? See the corresponding suggestion.

      As a licensed user of other Atlassian products, we have access to the source code of those products.
      We do not have access to the Team Calendars source code. This Jira is to request that the source code be made available on my.atlassian.com

        1. teamcal.jpg
          59 kB
          Duy Truong Luong

          Form Name

            [CONFSERVER-51182] Team Calendars source code not available on my.atlassian.com for licensed users

            Justin W. added a comment -

            Reopening this case as the source code is no longer publicly available at https://my.atlassian.com/download/source/teamcalendars/

            Justin W. added a comment - Reopening this case as the source code is no longer publicly available at https://my.atlassian.com/download/source/teamcalendars/

            New source code is available on MAC. Older source code is not, and can be requested separately.

            snorrish (Inactive) added a comment - New source code is available on MAC. Older source code is not, and can be requested separately.

            Hi tquanghua,

            Checking back in to determine if there are any updates on this issue? I am currently working with the client on a case at FMR and am checking in on this issue.

            Sincerely,

            Chuck

            chucktalk (Inactive) added a comment - Hi tquanghua , Checking back in to determine if there are any updates on this issue? I am currently working with the client on a case at FMR and am checking in on this issue. Sincerely, Chuck

            Hi ctalk,

            1) You're right it supposed not to have SNAPSHOT source code distribution there to avoid confusion but the snapshot source code you download from our distribution channel is actually same as latest release version (i.e 5.2.8-SNAPSHOT is same as 5.2.8) it's because the source code was zipped right before the build release of 5.2.8 version so there's no miss match between the source and the released version. We'll fix this to avoid confusion in the future.

            2) & 3) We'll make some old source versions available for download as on demand but not all the source code of old version. In your case I'll make source code of version 3.2.6 available and build-able soon.

            4) & 5) The build of TC source code is depend on version of maven and AMPS SDK. I recommend maven 3.0.5 and java 7. Some new version of AMPS SDK use new maven version may not work. For the build instruction I'll get back to you later.

            Thinh Quang Hua (Inactive) added a comment - Hi ctalk , 1) You're right it supposed not to have SNAPSHOT source code distribution there to avoid confusion but the snapshot source code you download from our distribution channel is actually same as latest release version (i.e 5.2.8-SNAPSHOT is same as 5.2.8) it's because the source code was zipped right before the build release of 5.2.8 version so there's no miss match between the source and the released version. We'll fix this to avoid confusion in the future. 2) & 3) We'll make some old source versions available for download as on demand but not all the source code of old version. In your case I'll make source code of version 3.2.6 available and build-able soon. 4) & 5) The build of TC source code is depend on version of maven and AMPS SDK. I recommend maven 3.0.5 and java 7. Some new version of AMPS SDK use new maven version may not work. For the build instruction I'll get back to you later.

            My client has built the Team Calendar from the source code on MAC given the above pom modification, but reports very different builds based on the following:

            "This builds! Unfortunately, exploding the built jar and comparing it to a built 5.1.21 jar shows there are massive differences, even in plaintext files like properties files, so that's not reassuring. For example, a truncated diff of a plaintext comparison on a properties file:

            --- expl-real/JAR/com/atlassian/confluence/extra/calendar3/calendar3.properties 2014-12-19 10:03:16.000000000 -0500
            +++ expl-snapshot/com/atlassian/confluence/extra/calendar3/calendar3.properties 2015-02-11 17:43:22.000000000 -0500
            @@ -65,6 +65,7 @@
             calendar3.restrictsubcalendar=Restrictions
             calendar3.restrictsubcalendar.tooltip=Restrict access to calendar
             calendar3.subscribedviacontent=Watching
            +calendar3.watching.status=Watching Status
             calendar3.subscribedviacontent.tooltip=You''re watching this calendar via pages
             calendar3.removesubcalendar=Remove...
             calendar3.removesubcalendar.tooltip=Remove calendar
            @@ -396,7 +397,8 @@
             calendar3.moreinvitees.singular=and {0} other
             
             calendar3.mycalendars=My Calendars
            -calendar3.mycalendars.pdl=Calendars
            +calendar3.mycalendars.pdl=My Calendars
            +calendar3.mycalendars.link=Calendars
             
             # Recently updated mail
             calendar3.viewmycalendars=View My Calendars
            @@ -498,6 +500,11 @@ 

            "

            So we are making progress, but it still seems to be missing some information.

            chucktalk (Inactive) added a comment - My client has built the Team Calendar from the source code on MAC given the above pom modification, but reports very different builds based on the following: "This builds! Unfortunately, exploding the built jar and comparing it to a built 5.1.21 jar shows there are massive differences, even in plaintext files like properties files, so that's not reassuring. For example, a truncated diff of a plaintext comparison on a properties file: --- expl-real/JAR/com/atlassian/confluence/extra/calendar3/calendar3.properties 2014-12-19 10:03:16.000000000 -0500 +++ expl-snapshot/com/atlassian/confluence/extra/calendar3/calendar3.properties 2015-02-11 17:43:22.000000000 -0500 @@ -65,6 +65,7 @@ calendar3.restrictsubcalendar=Restrictions calendar3.restrictsubcalendar.tooltip=Restrict access to calendar calendar3.subscribedviacontent=Watching +calendar3.watching.status=Watching Status calendar3.subscribedviacontent.tooltip=You''re watching this calendar via pages calendar3.removesubcalendar=Remove... calendar3.removesubcalendar.tooltip=Remove calendar @@ -396,7 +397,8 @@ calendar3.moreinvitees.singular=and {0} other calendar3.mycalendars=My Calendars -calendar3.mycalendars.pdl=Calendars +calendar3.mycalendars.pdl=My Calendars +calendar3.mycalendars.link=Calendars # Recently updated mail calendar3.viewmycalendars=View My Calendars @@ -498,6 +500,11 @@ " So we are making progress, but it still seems to be missing some information.

            +1 for Brendan's idea re: just making it available via Bitbucket

            Laura Kolker added a comment - +1 for Brendan's idea re: just making it available via Bitbucket

            Hey Sherif,

            Thanks for that info! The best thing to do would actually be to put it in BitBucket and share it with commercial customers who can submit "pull requests" to the code base - free fixes, more rapid development, less issues for customers and a route to being the code change you seek - WIN/WIN/WIN/WIN. Might be a good test case for that model Just an idea.

            Brendan

            Brendan Patterson added a comment - Hey Sherif, Thanks for that info! The best thing to do would actually be to put it in BitBucket and share it with commercial customers who can submit "pull requests" to the code base - free fixes, more rapid development, less issues for customers and a route to being the code change you seek - WIN/WIN/WIN/WIN. Might be a good test case for that model Just an idea. Brendan

            Martin R added a comment -

            Any update on this? There are so many features we need in the calendar plugin which don't seem to be getting anywhere in the development queue, that we would like to implement them ourselves. Unfortunately we can't as this plugin appears to be one of the few where our commercial license doesn't get us the source code!

            At the very least it would be nice to understand the reasons why it's not being made available.

            Martin R added a comment - Any update on this? There are so many features we need in the calendar plugin which don't seem to be getting anywhere in the development queue, that we would like to implement them ourselves. Unfortunately we can't as this plugin appears to be one of the few where our commercial license doesn't get us the source code! At the very least it would be nice to understand the reasons why it's not being made available.

            Still nothing here?

            Steven F Behnke added a comment - Still nothing here?

            We need the source to Team Calendars to fix this same issue I've fixed for several customers now in Confluence:
            https://jira.atlassian.com/browse/CONF-23802

            No one wants their customers to receive emails from "Anonymous"

            Any updates on this?

            thanks,
            Brendan

            Brendan Patterson added a comment - We need the source to Team Calendars to fix this same issue I've fixed for several customers now in Confluence: https://jira.atlassian.com/browse/CONF-23802 No one wants their customers to receive emails from "Anonymous" Any updates on this? thanks, Brendan

            Access to the source code is needed in order to adjust the rendering of non-essential information in the calendar entry.

            vhartgraves added a comment - Access to the source code is needed in order to adjust the rendering of non-essential information in the calendar entry.

            We are also interested in the source code.

            Thomas Cheyney added a comment - We are also interested in the source code.

            Alice N Brough added a comment - - edited

            It's kind of just become urgent for me - my old main client loves Team Calendars, but, as usual, they've got some requirements that aren't quite fitting (And are highly business specific, so they're never going to make it on to Atlassian's roadmap as they'd be virtually useless to everyone else). I've made the mistake of saying "yes, it's Atlassian, we have commercial licences, it'll be the same as the other stuff". Oops. So, a quick +1 here while I try to look busy on other stuff (Well, actually, I've dumped this on an ex-colleague, so I'm really trying to not drop him in it!)

            Alice N Brough added a comment - - edited It's kind of just become urgent for me - my old main client loves Team Calendars, but, as usual, they've got some requirements that aren't quite fitting (And are highly business specific, so they're never going to make it on to Atlassian's roadmap as they'd be virtually useless to everyone else). I've made the mistake of saying "yes, it's Atlassian, we have commercial licences, it'll be the same as the other stuff". Oops. So, a quick +1 here while I try to look busy on other stuff (Well, actually, I've dumped this on an ex-colleague, so I'm really trying to not drop him in it!)

            We are also interested in the source code as we would like to implement a "busy" view for restricted users.

            Oliver Göck added a comment - We are also interested in the source code as we would like to implement a "busy" view for restricted users.

            P added a comment -

            We are also intereted in the source code.

            P added a comment - We are also intereted in the source code.

            Paul Boyum added a comment -

            We are also interested in having access to the source so that we can add some additional restrictions around who can access the plugin. (Our scenario is outlined in TEAMCAL-536)

            Paul Boyum added a comment - We are also interested in having access to the source so that we can add some additional restrictions around who can access the plugin. (Our scenario is outlined in TEAMCAL-536 )

            Hey Sherif is there any possibility of getting the source before the private URL functionality is rolled into the plugin officially?
            It doesn't need to be production ready. I need to change a single the CalendarResource.java file, and then re-compile that single file against the rest of the classes bundled with the plugin (and the rest of the libs I can grab with the Plugin SDK if needed).

            David Corley added a comment - Hey Sherif is there any possibility of getting the source before the private URL functionality is rolled into the plugin officially? It doesn't need to be production ready. I need to change a single the CalendarResource.java file, and then re-compile that single file against the rest of the classes bundled with the plugin (and the rest of the libs I can grab with the Plugin SDK if needed).

            I don't disagree that it's secure in the sense of being difficult to brute-force guess the URL.
            However, our concern is with users sharing more than they should, be it accidentally or otherwise. We prefer to completely lock down Confluence to only authorized users.

            David Corley added a comment - I don't disagree that it's secure in the sense of being difficult to brute-force guess the URL. However, our concern is with users sharing more than they should, be it accidentally or otherwise. We prefer to completely lock down Confluence to only authorized users.

            Hey Mate,
            With TEAMCAL-503 we are looking at creating a setting which allows you to turn this off. Would that suffice? Out of curiosity what is the concern with that feature? Security? (It's actually fairly secure)

            Sherif Mansour added a comment - Hey Mate, With TEAMCAL-503 we are looking at creating a setting which allows you to turn this off. Would that suffice? Out of curiosity what is the concern with that feature? Security? (It's actually fairly secure )

            David Corley added a comment - - edited

            Hey Sherif,
            Yup, it's specifically to allow me to create a modified version that neuters the private calendar URL functionality - TEAMCAL-503 . We've managed to remove the Subcalendar menu option by just editing one of the velocity templates, but I need to get at the source of CalenderResource.class to really break it properly.
            I've used Jad to decompile the class, but because there are so many inner classes, re-compiling is not a trivial task. Having access to the source would be so much easier.

            David Corley added a comment - - edited Hey Sherif, Yup, it's specifically to allow me to create a modified version that neuters the private calendar URL functionality - TEAMCAL-503 . We've managed to remove the Subcalendar menu option by just editing one of the velocity templates, but I need to get at the source of CalenderResource.class to really break it properly. I've used Jad to decompile the class, but because there are so many inner classes, re-compiling is not a trivial task. Having access to the source would be so much easier.

              Unassigned Unassigned
              b0d88db9bee7 David Corley
              Votes:
              36 Vote for this issue
              Watchers:
              46 Start watching this issue

                Created:
                Updated: