Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-51101

Better error message when viewing an embedded calendar as an unprivileged user

    • We collect Confluence feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      NOTE: This suggestion is for Confluence Server. Using Confluence Cloud? See the corresponding suggestion.

      On our site's dashboard I have a calendar macro defined as:

      {calendar:id=8f564b4b-afed-4ceb-b206-2e426f595648,a80c628d-5155-40bc-8a55-0874fb77bf71}

      The result is something that looks like this:

      After using the new features from TEAMCAL-102 to restrict view access of one of those calendars, users who don't have view rights to that calendar now see a huge warning on our site:

      I believe the appropriate user experience would be to see no errors and no indication that there is a calendar that they do not have access to. I understand this has to be balanced with the requirement for editors to know if they fat-finger a calendar id in their macros when editing, and the error is probably useful then. But big red boxes on dashboards are worse.

      Marking as critical because I believe this is a significant bug that will impact many users as they begin to utilize the new features from TEAMCAL-102.

        1. Embed Restrictions Message 01.png
          34 kB
          Samantha Thebridge [Atlassian]
        2. Embed Restrictions Message 02.png
          5 kB
          Samantha Thebridge [Atlassian]
        3. User without View Rights.JPEG
          126 kB
          Justin Clarke
        4. User with View Rights.JPEG
          63 kB
          Justin Clarke

            [CONFSERVER-51101] Better error message when viewing an embedded calendar as an unprivileged user

            Matthew Erickson added a comment - - edited

            Hi Justin,

            If you have a way to add CSS to the page (with a plugin or some other mechanism) then you can use the following CSS rule to get rid of the message all together:

            .restricted-calendars-warning {
                display: none;
            }
            

            Matthew Erickson added a comment - - edited Hi Justin, If you have a way to add CSS to the page (with a plugin or some other mechanism) then you can use the following CSS rule to get rid of the message all together: .restricted-calendars-warning { display: none; }

            Thanks for the update. Will there be a way to disable this error message through CSS and/or an option in the macro?

            If not, i'll go ahead and file another bug/improvement request.

            Justin Clarke added a comment - Thanks for the update. Will there be a way to disable this error message through CSS and/or an option in the macro? If not, i'll go ahead and file another bug/improvement request.

            We have gone with the minimal error message. This seems like the best compromise.

            Matthew Erickson added a comment - We have gone with the minimal error message. This seems like the best compromise.

            David Yu added a comment -

            Samantha, the dialog may be a bit too large on Confluence pages where the calendar is compacted into a corner. It may very well be the case that as an author of a calendar, I never will share a specific calendar inside the macro to a user. The user would see that message every single time. Would prefer a smaller footprint (one liner, that can maybe expand if clicked), or an option to show no errors.

            David Yu added a comment - Samantha, the dialog may be a bit too large on Confluence pages where the calendar is compacted into a corner. It may very well be the case that as an author of a calendar, I never will share a specific calendar inside the macro to a user. The user would see that message every single time. Would prefer a smaller footprint (one liner, that can maybe expand if clicked), or an option to show no errors.

            Samantha, that dialog is definitely much nicer from an end-user perspective. It may be appropriate for some scenarios, but not ours.

            This may be a "misuse" of the macro, but here's how I'm using it. I'll paint our scenario with a hypothetical group of 4 calendars:

            1. General Events (open to all users)
            2. Executive Meetings (read only by "executive" group)
            3. Company Holidays (open to all users)
            4. Justin's Personal Calendar (private)

            On our dashboard or landing page I'd like to include a macro like:

            {calendar:id=1,2,3}

            I'd envision this to then display a calendar macro only showing events from #1 and #3 to all Confluence users, but also includes events from #2 when the end user is a member of the "executive" group. In our case, it'd look pretty silly to have a notice shown to every user stating that there's an additional calendar that they don't have rights to.

            But I'll go back to my previous comment. Your proposed dialog would be fine, as long as there's an option for the calendar macro to not display the dialog box. Or allow (and document) a way for users to hide the dialog using CSS. I'm sure there are also use cases where this dialog is necessary, so I don't want my lone opinion to sway the development of this plugin too far toward my specific usage of it.

            Justin Clarke added a comment - Samantha, that dialog is definitely much nicer from an end-user perspective. It may be appropriate for some scenarios, but not ours. This may be a "misuse" of the macro, but here's how I'm using it. I'll paint our scenario with a hypothetical group of 4 calendars: 1. General Events (open to all users) 2. Executive Meetings (read only by "executive" group) 3. Company Holidays (open to all users) 4. Justin's Personal Calendar (private) On our dashboard or landing page I'd like to include a macro like: {calendar:id=1,2,3} I'd envision this to then display a calendar macro only showing events from #1 and #3 to all Confluence users, but also includes events from #2 when the end user is a member of the "executive" group. In our case, it'd look pretty silly to have a notice shown to every user stating that there's an additional calendar that they don't have rights to. But I'll go back to my previous comment. Your proposed dialog would be fine, as long as there's an option for the calendar macro to not display the dialog box. Or allow (and document) a way for users to hide the dialog using CSS. I'm sure there are also use cases where this dialog is necessary, so I don't want my lone opinion to sway the development of this plugin too far toward my specific usage of it.

            Hi Justin, we have been discussing a way to present a nicer error without breaking the page layout.

            I've attached Embed Restrictions Message 01.png which is how we handle it in other places. How would you feel about this solution? Would it address your issue, or would you still prefer it to show nothing at all?

            Samantha Thebridge [Atlassian] added a comment - Hi Justin, we have been discussing a way to present a nicer error without breaking the page layout. I've attached Embed Restrictions Message 01.png which is how we handle it in other places. How would you feel about this solution? Would it address your issue, or would you still prefer it to show nothing at all?

            By my opinion the priority of this issue mut be higher because this error message spoils web interface. My mailbox is full of questions from customers "What the f** this error we see?". For users who must not see calendar, confluence web site looks ugly now. Out of the topic but for

            {include}

            macro is the same thing.

            Igor Kucherenko added a comment - By my opinion the priority of this issue mut be higher because this error message spoils web interface. My mailbox is full of questions from customers "What the f** this error we see?". For users who must not see calendar, confluence web site looks ugly now. Out of the topic but for {include} macro is the same thing.

            DavidA added a comment -

            Hi Justin,

            The priority was set to minor because it doesn't cause any actual functionality loss. However, that isn't to say we won't be looking at it. In fact, it was one of the things that we talked about when implementing TEAMCAL-102. For 1.3, we didn't make any decision because we felt there wasn't enough feedback to help us come up with a proper UX for this scenario.

            Your feedback helps, and I'm definitely going to highlight this with the product manager in our next catchup.

            DavidA added a comment - Hi Justin, The priority was set to minor because it doesn't cause any actual functionality loss. However, that isn't to say we won't be looking at it. In fact, it was one of the things that we talked about when implementing TEAMCAL-102 . For 1.3, we didn't make any decision because we felt there wasn't enough feedback to help us come up with a proper UX for this scenario. Your feedback helps, and I'm definitely going to highlight this with the product manager in our next catchup.

              merickson Matthew Erickson
              c15e2bcd81f1 Justin Clarke
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: