Details
-
Bug
-
Resolution: Fixed
-
Low
-
5.7
-
None
Description
Some of the resources are duplicated across roadmap-javascript and view-roadmap-javascript. The following resources are duplicated:
roadmap-javascript/templates.js view-roadmap-javascript/templates.js
roadmap-javascript/roadmap-editinplace.js view-roadmap-javascript/roadmap-editinplace.js
roadmap-javascript/roadmap.css view-roadmap-javascript/roadmap.css
roadmap-javascript/dialog.js view-roadmap-javascript/dialog.js
roadmap-javascript/bar-dialog.js view-roadmap-javascript/bar-dialog.js
roadmap-javascript/bar-link-new-page.js view-roadmap-javascript/bar-link-new-page.js
roadmap-javascript/roadmap-analytics.js view-roadmap-javascript/roadmap-analytics.js
As a general rule of thumb : every static resource file inside a plugin should appear in one and only one <web-resource>. In this case, factor the common JS into a separate web-resource that both the roadmap-javascript and view-roadmap-javascript depend on.
It would also be good if templates.soy could be split into a series of smaller soy template files, so we can reduce the amount of soy inside the view-roadmap-javascript resource. Same with roadmap.css if possible.