Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-20993

Confluence Modification Detection does not detect changes to classfiles

      The hash-registry.properties file included in Confluence distributions since CONF-13627 was implemented does not include the class files from the confluence.jar (or anywhere else). This means if customers modify classes then modification detection will not report it at all.

            [CONFSERVER-20993] Confluence Modification Detection does not detect changes to classfiles

            Hi There

            Thanks for taking the time to raise this issue. As you are probably aware this issue has been on our backlog now for quite some time with very little progress being made. Rather than leave this here I'm going to close this issue as won't fix, I believe that this better reflects the status of this issue.

            Regards
            Steve Haffenden
            Confluence Bugmaster

            Steve Haffenden (Inactive) added a comment - Hi There Thanks for taking the time to raise this issue. As you are probably aware this issue has been on our backlog now for quite some time with very little progress being made. Rather than leave this here I'm going to close this issue as won't fix, I believe that this better reflects the status of this issue. Regards Steve Haffenden Confluence Bugmaster

            Don Willis added a comment -

            For a standalone build, should modz be monitoring the whole tomcat install?

            Probably. But assuming it doesn't handle additions it might not be that helpful.

            Don Willis added a comment - For a standalone build, should modz be monitoring the whole tomcat install? Probably. But assuming it doesn't handle additions it might not be that helpful.

            Don Willis added a comment -

            I'm not very familiar with modz detector, but I don't think it has a concept of "added". Certainly our existing UI doesn't have a place for additions.

            I think it's just a matter of unzipping the confluence.jar and hashing its contents when building the distribution.

            Don Willis added a comment - I'm not very familiar with modz detector, but I don't think it has a concept of "added". Certainly our existing UI doesn't have a place for additions. I think it's just a matter of unzipping the confluence.jar and hashing its contents when building the distribution.

            Is it possible to just add WEB-INF/classes to the list of files/directories modz will check? Then it can report these files as 'added', rather than just 'modified' or 'removed'. This will cover any core confluence code that confluence is running that wasn't covered before, although it wouldn't cover plugins installed after the fact...

            For a standalone build, should modz be monitoring the whole tomcat install?

            Richard Atkins added a comment - Is it possible to just add WEB-INF/classes to the list of files/directories modz will check? Then it can report these files as 'added', rather than just 'modified' or 'removed'. This will cover any core confluence code that confluence is running that wasn't covered before, although it wouldn't cover plugins installed after the fact... For a standalone build, should modz be monitoring the whole tomcat install?

            This is inconsistent with JIRA, who include JIRA's class files, although not the class files of any libraries.

            Don Willis added a comment - This is inconsistent with JIRA, who include JIRA's class files, although not the class files of any libraries.

              shaffenden Steve Haffenden (Inactive)
              don.willis@atlassian.com Don Willis
              Affected customers:
              0 This affects my team
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: