Details
-
Suggestion
-
Resolution: Won't Fix
-
None
Description
NOTE: This suggestion is for Confluence Server. Using Confluence Cloud? See the corresponding suggestion.
In order to make it easy to leverage both com.atlassian.confluence.rpc.auth.TokenAuthenticationManager and custom authenticator code, it would be great if
TokenAuthenticationManager would be more friendly to its subclasses by sharing some of its private fields and methods as protected.
diff --git a/apps/confluence/confluence-project/confluence/src/java/com/atlassian/confluence/rpc/auth/TokenAuthenticationManager.java b/apps/confluence/confluence-project/confluence/src/java/com/atlassian/confluence/rpc/auth/TokenAuthenticationManager.java
--- a/apps/confluence/confluence-project/confluence/src/java/com/atlassian/confluence/rpc/auth/TokenAuthenticationManager.java
+++ b/apps/confluence/confluence-project/confluence/src/java/com/atlassian/confluence/rpc/auth/TokenAuthenticationManager.java
@@ -26,10 +26,10 @@
{
public static final String TOKEN_CACHE = TokenAuthenticationManager.class.getName() + ".tokens";
- private UserAccessor userAccessor;
- private PermissionManager permissionManager;
+ protected UserAccessor userAccessor;
+ protected PermissionManager permissionManager;
private SettingsManager settingsManager;
- private CacheManager cacheManager;
+ protected CacheManager cacheManager;
private EventManager eventManager;
/**
@@ -190,7 +190,7 @@
return userAccessor.getUser(name);
}
- private Cache getCache()
+ protected Cache getCache()
{
return cacheManager.getCache(TOKEN_CACHE);
}
Attachments
Issue Links
- relates to
-
- Closed
