Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-10887

Cannot build Confluence 2.7.1/2.7.2 from source - Compilation failure on atlassian-mail

    • Icon: Bug Bug
    • Resolution: Resolved Locally
    • Icon: Low Low
    • None
    • 2.7.1, 2.7.2
    • None
    • Red Hat Enterprise Linux 5.1 on i686
      Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_14-b03)
      Java HotSpot(TM) Server VM (build 1.5.0_14-b03, mixed mode)

      $ export JAVA_HOME=/usr/java/jdk1.5.0_14
      $ export PATH=$JAVA_HOME/bin:$PATH
      
      $ md5sum confluence-2.7.1-source.zip
      b136f7c01bd16387465ba6c4f493c560  confluence-2.7.1-source.zip
      $ unzip confluence-2.7.1-source.zip
      $ cd confluence-2.7.1-source/
      $ ./build.sh
      [...]
      Downloading: http://repository.atlassian.com/javax.transaction/jars/jta-1.0.1b.jar
      Downloading: http://repo1.maven.org/maven2/javax/transaction/jta/1.0.1b/jta-1.0.1b.jar
      [INFO] ------------------------------------------------------------------------
      [ERROR] BUILD ERROR
      [INFO] ------------------------------------------------------------------------
      [INFO] Failed to resolve artifact.
      
      Missing:
      ----------
      1) javax.mail:mail:jar:1.3.2
      
        Try downloading the file manually from: 
            http://java.sun.com/products/javamail/downloads/index.html
      
        Then, install it using the command: 
            mvn install:install-file -DgroupId=javax.mail -DartifactId=mail \
                -Dversion=1.3.2 -Dpackaging=jar -Dfile=/path/to/file
      
        Path to dependency: 
              1) com.atlassian.ofbiz:atlassian-ofbiz:jar:2.1
              2) javax.mail:mail:jar:1.3.2
      
      2) javax.transaction:jta:jar:1.0.1b
      
        Try downloading the file manually from the project website.
      
        Then, install it using the command: 
            mvn install:install-file -DgroupId=javax.transaction -DartifactId=jta \
                -Dversion=1.0.1b -Dpackaging=jar -Dfile=/path/to/file
      
        Path to dependency: 
              1) com.atlassian.ofbiz:atlassian-ofbiz:jar:2.1
              2) javax.transaction:jta:jar:1.0.1b
      
      ----------
      2 required artifacts are missing.
      
      for artifact: 
        com.atlassian.ofbiz:atlassian-ofbiz:jar:2.1
      
      from the specified remote repositories:
        central (http://repo1.maven.org/maven2),
        atlassian-m1-repository (http://repository.atlassian.com),
        atlassian-proxy (https://m2proxy.atlassian.com/repository/public)
      
      
      [INFO] ------------------------------------------------------------------------
      [INFO] For more information, run Maven with the -e switch
      [INFO] ------------------------------------------------------------------------
      [INFO] Total time: 4 minutes 56 seconds
      [INFO] Finished at: Mon Mar 03 18:02:38 CET 2008
      [INFO] Final Memory: 37M/73M
      [INFO] ------------------------------------------------------------------------
      

      Thanks for your time. More details upon request.

            [CONFSERVER-10887] Cannot build Confluence 2.7.1/2.7.2 from source - Compilation failure on atlassian-mail

            Don Willis added a comment -

            Thanks Jérôme.

            Don Willis added a comment - Thanks Jérôme.

            It works now, sorry for the noise. In case this helps someone:

            $ head -1 /etc/issue
            Red Hat Enterprise Linux Server release 5.1 (Tikanga)
            
            $ cd <dir>/confluence-2.7.1-source
            $ export JAVA_HOME=/usr/java/j2sdk1.4.2_17
            $ export PATH=$JAVA_HOME/bin:$PATH
            $ ./build.sh -Dmaven.test.skip
            

            You can close this issue. Thanks for your time.

            Jérôme Zago added a comment - It works now, sorry for the noise. In case this helps someone: $ head -1 /etc/issue Red Hat Enterprise Linux Server release 5.1 (Tikanga) $ cd <dir>/confluence-2.7.1-source $ export JAVA_HOME=/usr/java/j2sdk1.4.2_17 $ export PATH=$JAVA_HOME/bin:$PATH $ ./build.sh -Dmaven.test.skip You can close this issue. Thanks for your time.

            $ export JAVA_HOME=/usr/java/j2sdk1.4.2_17
            $ export PATH=$JAVA_HOME/bin:$PATH
            
            $ cd <dir>/confluence-2.7.2-source 
            $ ./build.sh
            [...]
            [INFO] [surefire:test]
            [INFO] Surefire report directory: /telelogic/src/confluence-2.7.2-source/atlassi
            an-seraph/target/surefire-reports
            
            -------------------------------------------------------
             T E S T S
            -------------------------------------------------------
            Running com.atlassian.seraph.service.TestPathService
            Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.11 sec
            Running com.atlassian.security.auth.trustedapps.TestDefaultIPMatcher
            Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.022 sec
            Running com.atlassian.seraph.cookie.TestEncryptedCookieEncoder
            log4j:WARN No appenders could be found for logger (com.atlassian.seraph.cookie.E
            ncryptedCookieEncoder).
            log4j:WARN Please initialize the log4j system properly.
            Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.43 sec
            Running com.atlassian.security.auth.trustedapps.TestDefaultRequestMatcher
            Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec
            Running com.atlassian.security.auth.trustedapps.TestUIDGenerator
            Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec
            Running com.atlassian.security.auth.trustedapps.TestBouncyCastleEncryptionProvid
            er
            Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 52.897 sec
            Running com.atlassian.seraph.controller.TestNullSecurityController
            Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec
            Running com.atlassian.seraph.util.TestPathMapper
            Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec
            Running com.atlassian.seraph.util.TestCookieUtils
            Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec
            Running com.atlassian.seraph.util.TestRedirectUtils
            Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.09 sec
            Running com.atlassian.seraph.service.TestWebworkService
            Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.066 sec
            Running com.atlassian.seraph.logout.TestLogoutServlet
            Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec
            Running com.atlassian.seraph.filter.TestTrustedApplicationsFilter
            Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec
            Running com.atlassian.seraph.auth.TestDefaultAuthenticator
            Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.181 sec
            Running com.atlassian.security.auth.trustedapps.TestTrustedApplications
            Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 13.2 sec <<< FAI
            LURE!
            Running com.atlassian.security.auth.trustedapps.TestDefaultURLMatcher
            Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec
            
            Results :
            
            Tests in error: 
              testNonExpiry(com.atlassian.security.auth.trustedapps.TestTrustedApplications)
            
            Tests run: 59, Failures: 0, Errors: 1, Skipped: 0
            
            [INFO] ------------------------------------------------------------------------
            [ERROR] BUILD FAILURE
            [INFO] ------------------------------------------------------------------------
            [INFO] There are test failures.
            [INFO] ------------------------------------------------------------------------
            [INFO] For more information, run Maven with the -e switch
            [INFO] ------------------------------------------------------------------------
            [INFO] Total time: 4 minutes 23 seconds
            [INFO] Finished at: Fri Mar 14 20:27:00 CET 2008
            [INFO] Final Memory: 35M/68M
            [INFO] ------------------------------------------------------------------------
            

            Well, we do have another problem with JDK 1.4.2...

            Jérôme Zago added a comment - $ export JAVA_HOME=/usr/java/j2sdk1.4.2_17 $ export PATH=$JAVA_HOME/bin:$PATH $ cd <dir>/confluence-2.7.2-source $ ./build.sh [...] [INFO] [surefire:test] [INFO] Surefire report directory: /telelogic/src/confluence-2.7.2-source/atlassi an-seraph/target/surefire-reports ------------------------------------------------------- T E S T S ------------------------------------------------------- Running com.atlassian.seraph.service.TestPathService Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.11 sec Running com.atlassian.security.auth.trustedapps.TestDefaultIPMatcher Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.022 sec Running com.atlassian.seraph.cookie.TestEncryptedCookieEncoder log4j:WARN No appenders could be found for logger (com.atlassian.seraph.cookie.E ncryptedCookieEncoder). log4j:WARN Please initialize the log4j system properly. Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.43 sec Running com.atlassian.security.auth.trustedapps.TestDefaultRequestMatcher Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.044 sec Running com.atlassian.security.auth.trustedapps.TestUIDGenerator Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec Running com.atlassian.security.auth.trustedapps.TestBouncyCastleEncryptionProvid er Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 52.897 sec Running com.atlassian.seraph.controller.TestNullSecurityController Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec Running com.atlassian.seraph.util.TestPathMapper Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.009 sec Running com.atlassian.seraph.util.TestCookieUtils Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec Running com.atlassian.seraph.util.TestRedirectUtils Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.09 sec Running com.atlassian.seraph.service.TestWebworkService Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.066 sec Running com.atlassian.seraph.logout.TestLogoutServlet Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec Running com.atlassian.seraph.filter.TestTrustedApplicationsFilter Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec Running com.atlassian.seraph.auth.TestDefaultAuthenticator Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.181 sec Running com.atlassian.security.auth.trustedapps.TestTrustedApplications Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 13.2 sec <<< FAI LURE! Running com.atlassian.security.auth.trustedapps.TestDefaultURLMatcher Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.01 sec Results : Tests in error: testNonExpiry(com.atlassian.security.auth.trustedapps.TestTrustedApplications) Tests run: 59, Failures: 0, Errors: 1, Skipped: 0 [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] There are test failures. [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 4 minutes 23 seconds [INFO] Finished at: Fri Mar 14 20:27:00 CET 2008 [INFO] Final Memory: 35M/68M [INFO] ------------------------------------------------------------------------ Well, we do have another problem with JDK 1.4.2...

            Ok looks like I didn't install the archives from Sun properly. Indeed, the following jars in my local Maven repository don't include .class files at all:

            $ cd ~/.m2/repository
            $ find -name "*.jar" | sort | while read file; do
                  jar tf $file | grep -q class$ || echo $file
              done
            ./javax/activation/activation/1.0.2/activation-1.0.2.jar
            ./javax/mail/mail/1.3.2/mail-1.3.2.jar
            

            Therefore:

            $ rm -rf ~/.m2 # restart from scratch
            $ cd <dir>/confluence-2.7.2-source
            
            $ ./maven/bin/mvn install:install-file -DgroupId=javax.transaction -DartifactId=jta \
                  -Dversion=1.0.1b -Dpackaging=jar -Dfile=../files/jta-1_0_1B-classes.zip
            
            $ (cd ..; unzip files/javamail-1_3_2-upd.zip)
            $ ./maven/bin/mvn install:install-file -DgroupId=javax.mail -DartifactId=mail \
                  -Dversion=1.3.2 -Dpackaging=jar -Dfile=../javamail-1.3.2/mail.jar
            
            $ (cd ..; unzip files/jaf-1_0_2-upd2.zip)
            $ ./maven/bin/mvn install:install-file -DgroupId=javax.activation -DartifactId=activation \
                  -Dversion=1.0.2 -Dpackaging=jar -Dfile=../jaf-1.0.2/activation.jar
            
            $ ./build.sh
            [...]
            [INFO] [compiler:testCompile]
            [INFO] Compiling 80 source files to /telelogic/src/confluence-2.7.2-source/atlas
            sian-renderer/target/test-classes
            [INFO] ------------------------------------------------------------------------
            [ERROR] BUILD FAILURE
            [INFO] ------------------------------------------------------------------------
            [INFO] Compilation failure
            /telelogic/src/confluence-2.7.2-source/atlassian-renderer/src/test/java/com/atla
            ssian/renderer/wysiwyg/TestWysiwygLinkHelper.java:[70,19] com.atlassian.renderer
            .wysiwyg.TestWysiwygLinkHelper.MockNode is not abstract and does not override ab
            stract method getUserData(java.lang.String) in org.w3c.dom.Node
            
            /telelogic/src/confluence-2.7.2-source/atlassian-renderer/src/test/java/com/atla
            ssian/renderer/wysiwyg/TestWysiwygLinkHelper.java:[70,19] com.atlassian.renderer
            .wysiwyg.TestWysiwygLinkHelper.MockNode is not abstract and does not override ab
            stract method getUserData(java.lang.String) in org.w3c.dom.Node
            
            [INFO] ------------------------------------------------------------------------
            [INFO] For more information, run Maven with the -e switch
            [INFO] ------------------------------------------------------------------------
            [INFO] Total time: 10 minutes 11 seconds
            [INFO] Finished at: Fri Mar 14 19:13:19 CET 2008
            [INFO] Final Memory: 40M/78M
            [INFO] ------------------------------------------------------------------------
            

            That's better ! Now I should just build with JDK 1.4.2 instead of 1.5.0 I guess...

            Jérôme Zago added a comment - Ok looks like I didn't install the archives from Sun properly. Indeed, the following jars in my local Maven repository don't include .class files at all: $ cd ~/.m2/repository $ find -name "*.jar" | sort | while read file; do jar tf $file | grep -q class$ || echo $file done ./javax/activation/activation/1.0.2/activation-1.0.2.jar ./javax/mail/mail/1.3.2/mail-1.3.2.jar Therefore: $ rm -rf ~/.m2 # restart from scratch $ cd <dir>/confluence-2.7.2-source $ ./maven/bin/mvn install:install-file -DgroupId=javax.transaction -DartifactId=jta \ -Dversion=1.0.1b -Dpackaging=jar -Dfile=../files/jta-1_0_1B-classes.zip $ (cd ..; unzip files/javamail-1_3_2-upd.zip) $ ./maven/bin/mvn install:install-file -DgroupId=javax.mail -DartifactId=mail \ -Dversion=1.3.2 -Dpackaging=jar -Dfile=../javamail-1.3.2/mail.jar $ (cd ..; unzip files/jaf-1_0_2-upd2.zip) $ ./maven/bin/mvn install:install-file -DgroupId=javax.activation -DartifactId=activation \ -Dversion=1.0.2 -Dpackaging=jar -Dfile=../jaf-1.0.2/activation.jar $ ./build.sh [...] [INFO] [compiler:testCompile] [INFO] Compiling 80 source files to /telelogic/src/confluence-2.7.2-source/atlas sian-renderer/target/test-classes [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Compilation failure /telelogic/src/confluence-2.7.2-source/atlassian-renderer/src/test/java/com/atla ssian/renderer/wysiwyg/TestWysiwygLinkHelper.java:[70,19] com.atlassian.renderer .wysiwyg.TestWysiwygLinkHelper.MockNode is not abstract and does not override ab stract method getUserData(java.lang.String) in org.w3c.dom.Node /telelogic/src/confluence-2.7.2-source/atlassian-renderer/src/test/java/com/atla ssian/renderer/wysiwyg/TestWysiwygLinkHelper.java:[70,19] com.atlassian.renderer .wysiwyg.TestWysiwygLinkHelper.MockNode is not abstract and does not override ab stract method getUserData(java.lang.String) in org.w3c.dom.Node [INFO] ------------------------------------------------------------------------ [INFO] For more information, run Maven with the -e switch [INFO] ------------------------------------------------------------------------ [INFO] Total time: 10 minutes 11 seconds [INFO] Finished at: Fri Mar 14 19:13:19 CET 2008 [INFO] Final Memory: 40M/78M [INFO] ------------------------------------------------------------------------ That's better ! Now I should just build with JDK 1.4.2 instead of 1.5.0 I guess...

            Note: my Maven2 repository now includes the following files with "mail" in the name:

            $ (cd ~/.m2/repository/; find -name "*mail*" -type f | sort)
            ./javamail/mail/1.3.2/mail-1.3.2.pom
            ./javamail/mail/1.3.2/mail-1.3.2.pom.sha1
            ./javax/mail/mail/1.3.2/mail-1.3.2.jar
            ./javax/mail/mail/1.3.2/mail-1.3.2.pom
            ./javax/mail/mail/1.3.2/mail-1.3.2.pom.sha1
            ./javax/mail/mail/1.4/mail-1.4.jar
            ./javax/mail/mail/1.4/mail-1.4.jar.sha1
            ./javax/mail/mail/1.4/mail-1.4.pom
            ./javax/mail/mail/1.4/mail-1.4.pom.sha1
            

            Jérôme Zago added a comment - Note: my Maven2 repository now includes the following files with "mail" in the name: $ (cd ~/.m2/repository/; find -name "*mail*" -type f | sort) ./javamail/mail/1.3.2/mail-1.3.2.pom ./javamail/mail/1.3.2/mail-1.3.2.pom.sha1 ./javax/mail/mail/1.3.2/mail-1.3.2.jar ./javax/mail/mail/1.3.2/mail-1.3.2.pom ./javax/mail/mail/1.3.2/mail-1.3.2.pom.sha1 ./javax/mail/mail/1.4/mail-1.4.jar ./javax/mail/mail/1.4/mail-1.4.jar.sha1 ./javax/mail/mail/1.4/mail-1.4.pom ./javax/mail/mail/1.4/mail-1.4.pom.sha1

            After downloading the archives from Sun, I installed them (into my Maven2 repository) like this:

            $ ./maven/bin/mvn install:install-file -DgroupId=javax.transaction -DartifactId=jta \
                  -Dversion=1.0.1b -Dpackaging=jar -Dfile=../jta-1_0_1B-classes.zip
            $ ./maven/bin/mvn install:install-file -DgroupId=javax.mail -DartifactId=mail \
                  -Dversion=1.3.2 -Dpackaging=jar -Dfile=../javamail-1_3_2-upd.zip
            $ ./maven/bin/mvn install:install-file -DgroupId=javax.activation -DartifactId=activation \
                  -Dversion=1.0.2 -Dpackaging=jar -Dfile=../jaf-1_0_2-upd2.zip
            

            Unfortunately the Confluence 2.7.1 build still fails:

            $ ./build.sh
            [...]
            [INFO] ----------------------------------------------------------------------------
            [INFO] Building Atlassian Mail
            [INFO]    task-segment: [clean, package]
            [INFO] ----------------------------------------------------------------------------
            [INFO] [clean:clean]
            [INFO] [resources:resources]
            [INFO] Using default encoding to copy filtered resources.
            Downloading: https://m2proxy.atlassian.com/repository/public/javamail/mail/1.3.2/mail-1.3.2.pom
            311b downloaded
            [WARNING] While downloading javamail:mail:1.3.2
              This artifact has been relocated to javax.mail:mail:1.3.2.
            [...]
            [INFO] [compiler:compile]
            Compiling 24 source files to /telelogic/src/confluence-2.7.1-source/atlassian-mail/target/classes
            [INFO] ------------------------------------------------------------------------
            [ERROR] BUILD FAILURE
            [INFO] ------------------------------------------------------------------------
            [INFO] Compilation failure
            [...]
            /telelogic/src/confluence-2.7.1-source/atlassian-mail/src/main/java/com/atlassian/mail/server/MailServerManager.java:[14,18]
                package javax.mail does not exist
            [...]
            /telelogic/src/confluence-2.7.1-source/atlassian-mail/src/main/java/com/atlassian/mail/MailUtils.java:[374,42] 
                cannot find symbol
            symbol  : class DataHandler
            location: class com.atlassian.mail.MailUtils
            [...]
            

            Jérôme Zago added a comment - After downloading the archives from Sun, I installed them (into my Maven2 repository) like this: $ ./maven/bin/mvn install:install-file -DgroupId=javax.transaction -DartifactId=jta \ -Dversion=1.0.1b -Dpackaging=jar -Dfile=../jta-1_0_1B-classes.zip $ ./maven/bin/mvn install:install-file -DgroupId=javax.mail -DartifactId=mail \ -Dversion=1.3.2 -Dpackaging=jar -Dfile=../javamail-1_3_2-upd.zip $ ./maven/bin/mvn install:install-file -DgroupId=javax.activation -DartifactId=activation \ -Dversion=1.0.2 -Dpackaging=jar -Dfile=../jaf-1_0_2-upd2.zip Unfortunately the Confluence 2.7.1 build still fails: $ ./build.sh [...] [INFO] ---------------------------------------------------------------------------- [INFO] Building Atlassian Mail [INFO] task-segment: [clean, package] [INFO] ---------------------------------------------------------------------------- [INFO] [clean:clean] [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. Downloading: https://m2proxy.atlassian.com/repository/public/javamail/mail/1.3.2/mail-1.3.2.pom 311b downloaded [WARNING] While downloading javamail:mail:1.3.2 This artifact has been relocated to javax.mail:mail:1.3.2. [...] [INFO] [compiler:compile] Compiling 24 source files to /telelogic/src/confluence-2.7.1-source/atlassian-mail/target/classes [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Compilation failure [...] /telelogic/src/confluence-2.7.1-source/atlassian-mail/src/main/java/com/atlassian/mail/server/MailServerManager.java:[14,18] package javax.mail does not exist [...] /telelogic/src/confluence-2.7.1-source/atlassian-mail/src/main/java/com/atlassian/mail/MailUtils.java:[374,42] cannot find symbol symbol : class DataHandler location: class com.atlassian.mail.MailUtils [...]

              Unassigned Unassigned
              95ad41a902aa Jérôme Zago
              Affected customers:
              0 This affects my team
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: