Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-4859

Broken page table structure in Edit mode after upgrade from 1.4.4 to 2.0.1

    • Icon: Bug Bug
    • Resolution: Support Request
    • Icon: High High
    • 2.1
    • 2.0.1
    • None
    • Tomcat, JDK 1.5.0_04, Linux 2.6.10

      I created a page in version 1.4.4, using Wiki markup to create a table with three columns. It looks good. We upgraded to version 2.0.1. I opened the page for editing, BUT DID NOT EDIT ANYTHING. Two things went wrong:

      1) When I return to View mode without saving or canceling the Edit session, I get a dialog warning me about unsaved changes, even though I didn't make any edits.

      2) When I view the page in Preview mode, the table structure is messed up. Some of the pipe characters, "|", I used for laying out the table originally now display as literal characters on the screen. See attachment for screen shots of the original page and how it looks in Preview mode under the new version of Confluence.

      Again, I do not have to make any edits to see both effects. It is repeatable.

      Thanks.

        1. bug_view_source.txt
          6 kB
          Kirk Johnson
        2. Confluence_bug_screenshot.doc
          137 kB
          Kirk Johnson

            [CONFSERVER-4859] Broken page table structure in Edit mode after upgrade from 1.4.4 to 2.0.1

            jens added a comment -

            Thanks for the suggestion Kirk,

            I have updated the notation guide. The note in the guide stating that each table-row has to be defined on a single line will be part of the Confluence 2.0.4 release.

            Cheers,
            Jens

            jens added a comment - Thanks for the suggestion Kirk, I have updated the notation guide. The note in the guide stating that each table-row has to be defined on a single line will be part of the Confluence 2.0.4 release. Cheers, Jens

            Daniel,

            Thanks for you help in sorting this out. I will modify my markup accordingly.

            May I suggest that the Notation Guide be updated to explicitly state the rule that table rows must be defined on a single line. In general, the Notation Guide left me uncertain about the role of newlines, where they are allowed or not. I wasn't sure if the examples were meant to taken literally (exactly), or if they were just condensed (no newlines) to save space.

            Again, thanks for your quick and thorough response.

            Best regards,

            Kirk

            Kirk Johnson added a comment - Daniel, Thanks for you help in sorting this out. I will modify my markup accordingly. May I suggest that the Notation Guide be updated to explicitly state the rule that table rows must be defined on a single line. In general, the Notation Guide left me uncertain about the role of newlines, where they are allowed or not. I wasn't sure if the examples were meant to taken literally (exactly), or if they were just condensed (no newlines) to save space. Again, thanks for your quick and thorough response. Best regards, Kirk

            I have created CONF-4896 to deal with the table heading problem.

            Daniel Ostermeier added a comment - I have created CONF-4896 to deal with the table heading problem.

            Hi Kirk,

            The problem here is that you can not have headings within tables. The WYSIWYG editor will place the heading on a new line by itself. There is also a problem of the wysiwyg editor escaping the '|' characters because, it expects a table row to be defined all on one row, not over multiple rows.

            We will look at fixing the heading within the table problem. However, since our sytax for tables is that table rows should be defined on a single line, im not sure that we can do much about the WYSIWYG editor escaping the '|'

            Regards,
            -Daniel

            Daniel Ostermeier added a comment - Hi Kirk, The problem here is that you can not have headings within tables. The WYSIWYG editor will place the heading on a new line by itself. There is also a problem of the wysiwyg editor escaping the '|' characters because, it expects a table row to be defined all on one row, not over multiple rows. We will look at fixing the heading within the table problem. However, since our sytax for tables is that table rows should be defined on a single line, im not sure that we can do much about the WYSIWYG editor escaping the '|' Regards, -Daniel

            There are still some double quotes in the View Source markup, but no single quotes, so I think just the single quotes are getting converted. We will look into the character encoding - thanks.

            I am attaching the complete markup, obfuscated a bit, from the View Source. I did find one place where I omitted a pipe character to close the last table cell in a row (see after the closing "

            {note}" tag in the last of the three tables). The WYSIWYG editor correctly adds the missing pipe. The table structure still displays differently from the original, though. There are three tables on the page, all of which display oddly, but the error was only in the last of the three tables.

            I have a question on the markup, which I might be doing incorrectly and causing the problem: in places, I have newlines between the opening and closing pipes that define a table cell. For example, the second column in each table row starts with a leverl four heading, followed by a newline, followed by some text. Is this allowed within a table cell? I couldn't discover the answer from the Notation Guide. In some places it seems that newlines are significant (e.g., to terminate a heading line started with "hn"), but in other places they aren't. I also have newlines within an {info} and {note}

            that are themselves within a table cell.

            Kirk Johnson added a comment - There are still some double quotes in the View Source markup, but no single quotes, so I think just the single quotes are getting converted. We will look into the character encoding - thanks. I am attaching the complete markup, obfuscated a bit, from the View Source. I did find one place where I omitted a pipe character to close the last table cell in a row (see after the closing " {note}" tag in the last of the three tables). The WYSIWYG editor correctly adds the missing pipe. The table structure still displays differently from the original, though. There are three tables on the page, all of which display oddly, but the error was only in the last of the three tables. I have a question on the markup, which I might be doing incorrectly and causing the problem: in places, I have newlines between the opening and closing pipes that define a table cell. For example, the second column in each table row starts with a leverl four heading, followed by a newline, followed by some text. Is this allowed within a table cell? I couldn't discover the answer from the Notation Guide. In some places it seems that newlines are significant (e.g., to terminate a heading line started with "hn"), but in other places they aren't. I also have newlines within an {info} and {note} that are themselves within a table cell.

            Hi Kirk,

            What type of quotation marks were you using? That they were turned into '?' marks would indicate that there is a character encoding problem somewhere in your setup. Are you able to use non-standard characters such as the euro symbol?

            As for getting the original wiki markup, on the pages info tab, there is a view source link that will show you the original markup. Please ensure that you copy the wiki markup (without the sensitive content) as exactly as you can.

            What I think is happening is that the wiki markup that you have on the page, whilst working and rendering correctly, is not strictly valid markup. What happens is that when the WYSIWYG editor converts this into HTML, it will force strict adherance to the table markup.

            For example, the following markup will correctly render as a table with two rows and two columns. However, it is missing a '|' in the first row.

            A B
            C D

            When you view this in the WYSIWYG editor and then save it, it will be converted to

            A B
            C D

            which is the more correct version.

            Another example is

            A B
            C D

            which also renders as the same table as in the previous example, but is converted to

            A B
             
            C D

            by the WYSIWYG editor.

            Does this help explain what is happening?

            Regards,
            -Daniel

            Daniel Ostermeier added a comment - Hi Kirk, What type of quotation marks were you using? That they were turned into '?' marks would indicate that there is a character encoding problem somewhere in your setup. Are you able to use non-standard characters such as the euro symbol? As for getting the original wiki markup, on the pages info tab, there is a view source link that will show you the original markup. Please ensure that you copy the wiki markup (without the sensitive content) as exactly as you can. What I think is happening is that the wiki markup that you have on the page, whilst working and rendering correctly, is not strictly valid markup. What happens is that when the WYSIWYG editor converts this into HTML, it will force strict adherance to the table markup. For example, the following markup will correctly render as a table with two rows and two columns. However, it is missing a '|' in the first row. A B C D When you view this in the WYSIWYG editor and then save it, it will be converted to A B C D which is the more correct version. Another example is A B C D which also renders as the same table as in the previous example, but is converted to A B   C D by the WYSIWYG editor. Does this help explain what is happening? Regards, -Daniel

            Daniel,

            Thanks for your quick response.

            Below is a part of the wiki markup for the page. It is the entire first
            table that I sent in the screen shot. I have removed some of the text for
            confidentiality reasons.

            Note that this is not necessarily the original markup. To get the markup
            below, I opened the page in Edit mode, clicked the Wiki Markup tab, and
            cut-and-pasted the code. It seems that the Confluence editor is changing
            the markup when I open the page in Edit mode. Is there a way I can get at
            the original markup without opening the page in Edit mode?

            Looking at this now, it looks like at least some of the single quotes that
            were in the original text are now converted to question marks.

            Kirk

            High Priority

            Need a web server dedicated solely to development for our PHP 4

            production apps

            Most of Zoot?s production web applications, as well as our internal
            sites/apps, are written in PHP 4. (remaining text removed). | To be
            addressed at next meeting |

            Need a reliable ?production? web server for our internal web tools

            See item 1. Internal tools used company-wide or for critical applications
            need to be hosted on a reliable server dedicated to that task. | To be
            addressed at next meeting |

            Need a profiler / debugger for PHP 4 development

            We do not currently have an IDE tool for PHP development. (remaining text
            removed). | Priority assigned |

            Review php.ini for new PHP 5 servers

            PHP configuration should be reviewed (remaining text removed). |

            {tip:title=New Item}

            |
            Page Top

            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
            Kirk Johnson
            Web Programmer, Systems Development
            406.556.8857 / kjohnson@zootweb.com

            Zoot Enterprises, Inc. (http://www.zootweb.com)
            555 Zoot Enterprises Lane, Bozeman, MT 59718
            phone: 406.586.5050 fax: 406.586.8005
            -----------------------------------------------
            Copyright © 2005 Zoot Enterprises, Inc. and its affiliates. All rights
            reserved. This email, including any attachments, is confidential and may
            not be redistributed without permission. If you are not an intended
            recipient, you have received this message in error; please notify us
            immediately by replying to this message and deleting it from your
            computer. Thank you.

            "Daniel Ostermeier (JIRA)" <jira@atlassian.com> wrote on 12/07/2005
            01:13:08 AM:

            http://jira.atlassian.com/browse/CONF-4859?page=comments#action_47429]
            2.0.1
            --------------------------------------------------------------------------

            Kirk.Johnson@zootweb.com added a comment - Daniel, Thanks for your quick response. Below is a part of the wiki markup for the page. It is the entire first table that I sent in the screen shot. I have removed some of the text for confidentiality reasons. Note that this is not necessarily the original markup. To get the markup below, I opened the page in Edit mode, clicked the Wiki Markup tab, and cut-and-pasted the code. It seems that the Confluence editor is changing the markup when I open the page in Edit mode. Is there a way I can get at the original markup without opening the page in Edit mode? Looking at this now, it looks like at least some of the single quotes that were in the original text are now converted to question marks. Kirk High Priority Need a web server dedicated solely to development for our PHP 4 production apps Most of Zoot?s production web applications, as well as our internal sites/apps, are written in PHP 4. (remaining text removed). | To be addressed at next meeting | Need a reliable ?production? web server for our internal web tools See item 1. Internal tools used company-wide or for critical applications need to be hosted on a reliable server dedicated to that task. | To be addressed at next meeting | Need a profiler / debugger for PHP 4 development We do not currently have an IDE tool for PHP development. (remaining text removed). | Priority assigned | Review php.ini for new PHP 5 servers PHP configuration should be reviewed (remaining text removed). | {tip:title=New Item} | Page Top ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Kirk Johnson Web Programmer, Systems Development 406.556.8857 / kjohnson@zootweb.com Zoot Enterprises, Inc. ( http://www.zootweb.com ) 555 Zoot Enterprises Lane, Bozeman, MT 59718 phone: 406.586.5050 fax: 406.586.8005 ----------------------------------------------- Copyright © 2005 Zoot Enterprises, Inc. and its affiliates. All rights reserved. This email, including any attachments, is confidential and may not be redistributed without permission. If you are not an intended recipient, you have received this message in error; please notify us immediately by replying to this message and deleting it from your computer. Thank you. "Daniel Ostermeier (JIRA)" <jira@atlassian.com> wrote on 12/07/2005 01:13:08 AM: http://jira.atlassian.com/browse/CONF-4859?page=comments#action_47429 ] 2.0.1 --------------------------------------------------------------------------

            Hi Kirk,

            Can you please give us an example of the wiki markup that you used that is causing this problem?

            Regards,
            -Daniel

            Daniel Ostermeier added a comment - Hi Kirk, Can you please give us an example of the wiki markup that you used that is causing this problem? Regards, -Daniel

              Unassigned Unassigned
              48e3dc552ce1 Kirk Johnson
              Affected customers:
              0 This affects my team
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: