Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-36484

hibernate.c3p0.preferredTestQuery is ignored in confluence.cfg.xml

XMLWordPrintable

      Our documentation says we can modify the preferred test query by setting that parameter. However, with Confluence 5.7 and possibly older versions, it does not appear to work.

      Steps to reproduce:

      • Start Confluence 5.7 with a debugger attached
      • Add to confluence.cfg.xml 
        <property name="hibernate.c3p0.preferredTestQuery">select 1</property>
<property name="hibernate.c3p0.validate">true</property>
      • Set a breakpoint in testPooledConnection in C3P0PooledConnectionPool and you will notice that the test query is null, which eventually ends up calling com.mchange.v2.c3p0.impl.DefaultConnectionTester#activeCheckConnectionNoQuery which does a getTables() call on the connection metadata instead of issuing the test query specified.

      Workaround:

      Add the system property - c3p0.preferredTestQuery - with the validation query that is appropriate for your database. The added system property will be used as default value and picked up by c3p0 connection pool when getting a new connection.

      Database Type Validation Query
      MySQL select 1
      Microsoft SQL Server select 1
      Oracle select 1 from dual
      PostgreSQL select 1

      For example:

      -Dc3p0.preferredTestQuery="select 1"

      Refer to https://confluence.atlassian.com/display/DOC/Configuring+System+Properties for more information on how to configure system properties.

      Workaround 2:

      Run the steps in this guide to switch from jdbc to datasource. Be sure to back up the files indicated in Step 1.

      Please be sure not to skip the section starting with "If you're changing an existing Confluence installation over to using a datasource" in Step 4.

            [CONFSERVER-36484] hibernate.c3p0.preferredTestQuery is ignored in confluence.cfg.xml

            Rudy Slaiby made changes -
            Remote Link Original: This issue links to "Page (Extranet)" [ 103220 ]
            Katherine Yabut made changes -
            Workflow Original: JAC Bug Workflow v3 [ 2879101 ] New: CONFSERVER Bug Workflow v4 [ 3002888 ]
            Owen made changes -
            Workflow Original: JAC Bug Workflow v2 [ 2787698 ] New: JAC Bug Workflow v3 [ 2879101 ]
            Status Original: Resolved [ 5 ] New: Closed [ 6 ]
            Owen made changes -
            Workflow Original: JAC Bug Workflow [ 2730108 ] New: JAC Bug Workflow v2 [ 2787698 ]
            Owen made changes -
            Symptom Severity Original: Critical [ 14430 ] New: Severity 1 - Critical [ 15830 ]
            Owen made changes -
            Workflow Original: Confluence Workflow - Public Facing - Restricted v5 - TEMP [ 2393150 ] New: JAC Bug Workflow [ 2730108 ]
            Katherine Yabut made changes -
            Workflow Original: Confluence Workflow - Public Facing - Restricted v5 [ 2279775 ] New: Confluence Workflow - Public Facing - Restricted v5 - TEMP [ 2393150 ]
            Katherine Yabut made changes -
            Workflow Original: Confluence Workflow - Public Facing - Restricted v5.1 - TEMP [ 2221022 ] New: Confluence Workflow - Public Facing - Restricted v5 [ 2279775 ]
            Katherine Yabut made changes -
            Workflow Original: Confluence Workflow - Public Facing - Restricted v5 - TEMP [ 2163206 ] New: Confluence Workflow - Public Facing - Restricted v5.1 - TEMP [ 2221022 ]
            Katherine Yabut made changes -
            Workflow Original: Confluence Workflow - Public Facing - Restricted v5 [ 1951761 ] New: Confluence Workflow - Public Facing - Restricted v5 - TEMP [ 2163206 ]

              fxu Feng Xu (Inactive)
              nbhawnani Niraj Bhawnani
              Affected customers:
              9 This affects my team
              Watchers:
              19 Start watching this issue

                Created:
                Updated:
                Resolved: