StorageMacroV2Marshaller does not use old parameters array, macros created with deprecated method do not have parameters persisted

tanstett reported an issue with Confluence 5.3-beta1:

While testing Scroll Versions with Confluence 5.3-beta1 we found some weird behaviour. I need to mention that Scroll Versions is still using the deprecated MacroDefinition constructor and not the new one introduced by the 5.3-beta1.

Although MacroDefintions using storageVersion 1 render perfectly in the storageToView chain it looks like that they are not handled in the StorageMacroV2Marshaller (68). My gut feeling is that all plugins using xhtmlContent to update MacroDefinitions will run into this problem. The StorageMacroV2Marshaller just considers the typedParameters map which would be empty and does not look into the "old" parameters map.

Is this the intended behaviour?

Then following up:

The StorageMacroV2Marshaller just considers the typedParameters map which would be empty and does not look into the "old" parameters map. Thus no parameters will be saved in the storage format. An Macro created the deprecated way and saved will result in a storage format representation without any parameters.

This is currently affecting the scroll versions plugin

cc richatkins matt@atlassian.com