Editing a page can cause the "line-height" style's casing to change which triggers "format changes" in version comparison adding noise and increasing probability of merge conflicts for concurrent editing

XMLWordPrintable

    • 1
    • Severity 2 - Major
    • 0

      I've noticed situations where someone edits a page and actually only modifies a targeted section of content, but the subsequent version comparison highlights what appeared to be a random set of paragraphs as having format changes. This originally annoyed me due to the increased noise when reviewing someone's changes, but later it got even more annoying when it caused merge conflicts when I was editing content in those sections where the other person's apparent random "format change" caused a merge conflict for me.

      When I view the two versions, I can't visually tell any difference between the sections that claim to have format changes. However, if I view the "storage format" for the two versions, I see that there is a case difference in the "line-height" style attribute. And I'm guessing that this is what is causing the comparison engine to assume a format change was done. Below are examples of the same Heading 2 line that was in the original page version's storage format, and then the one in the new version, where I am confident the editor of the new version didn't touch that section.

      • <h2><span style="line-height: 1.4285;">Policy</span></h2>
      • <h2><span style="LINE-HEIGHT: 1.4285;">Policy</span></h2>

      If I search the storage format content, it seems that every place where a line-height style attribute was present, its case was changed. I haven't yet been able to confirm the browser and version that the editor was using, but I believe it would have been IE 9 or potentially IE 8.

      As a shot in the dark, I'm assuming the WYSIWYG editor you guys are using maybe introduced that casing toggle? And maybe you could post process the storage format to revert that casing toggle in those situations, assuming there isn't a way to fix it up stream?

      I attached the following images:

      • VersionComparisonHighlightingFormattingChanges.png shows the version comparison highlighting formatting differences, where there was no visible change
      • ComparisonOfStorageFormatShowingLine-HeightCaseChanges.png that shows the differences in the storage format that was just the casing of the line-height style attribute, as well as a lot of extract white space, but at least it seems your version comparison is tolerant of extra white space.

              Assignee:
              Unassigned
              Reporter:
              Pete Jaffe
              Votes:
              5 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: