Uploaded image for project: 'Confluence Cloud'
  1. Confluence Cloud
  2. CONFCLOUD-54206

Confluence changes in the last 24 hours email shows users as anonymous.

      After the upgrade from 5.1-OD-13 to 5.2-OD-3 on July 8, 2013 the Daily update email shows all users as Anonymous.

      The following text shows in the email:
      Page: Example Page! created by Anonymous [12:05 AM]

      A fix for this will be available 29th July 2013

            [CONFCLOUD-54206] Confluence changes in the last 24 hours email shows users as anonymous.

            stephen.gramm@nasa.gov I believe that this issue is unrelated to what you are experiencing. My understanding of your issue is that Change in the last 24 hours emails are being sent from Anonymous user in the From: field. This issue deals with the Change in the last 24 hours email body containing pages that were changed by users but listed as changed by Anonymous. To the best of my knowledge, this specific issue occurred in OnDemand and was promptly fixed. It never affected our standalone releases. I think the on going issue you are interested in is: https://jira.atlassian.com/browse/CONF-26159. I will make a comment on this issue separately.

            Ted Piotrowski (Inactive) added a comment - stephen.gramm@nasa.gov I believe that this issue is unrelated to what you are experiencing. My understanding of your issue is that Change in the last 24 hours emails are being sent from Anonymous user in the From: field. This issue deals with the Change in the last 24 hours email body containing pages that were changed by users but listed as changed by Anonymous. To the best of my knowledge, this specific issue occurred in OnDemand and was promptly fixed. It never affected our standalone releases. I think the on going issue you are interested in is: https://jira.atlassian.com/browse/CONF-26159 . I will make a comment on this issue separately.

            We need this to be fixed in Confluence 5.2.5 Standalone version. Please send us a fix for the same reported problem: CSP-118930

            Stephen Gramm added a comment - We need this to be fixed in Confluence 5.2.5 Standalone version. Please send us a fix for the same reported problem: CSP-118930

            Apologies to those who are waiting for this but we've hit a problem with out planned fix for Monday 15 so it has to be delayed. I'll update you again once we've locked in the fix, but I estimate it will be there in about two weeks.

            John Masson added a comment - Apologies to those who are waiting for this but we've hit a problem with out planned fix for Monday 15 so it has to be delayed. I'll update you again once we've locked in the fix, but I estimate it will be there in about two weeks.

            This has been fixed by the merge of the branch issue/CONFDEV-18186.
            As per the previous comment however, you won't see the fix on OnDemand instances until Monday 15th July.

            Paul Curren added a comment - This has been fixed by the merge of the branch issue/CONFDEV-18186. As per the previous comment however, you won't see the fix on OnDemand instances until Monday 15th July.

            Paul Curren added a comment - - edited

            Hi OnDemand Customers.

            The plan is to deploy a new version of Confluence (5.2-OD-5) to OnDemand instances on Monday 15th July. At the same time we will flip the switch to enable the newly developed versions of our notification e-mails. This will resolve the problem of 'Anonymous' being reported.

            So this plan means that the current bug will persist until Monday.

            Paul Curren added a comment - - edited Hi OnDemand Customers. The plan is to deploy a new version of Confluence (5.2-OD-5) to OnDemand instances on Monday 15th July. At the same time we will flip the switch to enable the newly developed versions of our notification e-mails. This will resolve the problem of 'Anonymous' being reported. So this plan means that the current bug will persist until Monday.

            Just trying to make sense of the discussion thread on this issue. The
            Confluence Changes in the last 24 hours I received 8 hours ago is still showing Anonymous, so I assume it isn't fixed in production yet? However, based on Ted Piotrowski's comment does this mean we can expect a fix in the next maintenance window (or sooner)?

            James Dellow added a comment - Just trying to make sense of the discussion thread on this issue. The Confluence Changes in the last 24 hours I received 8 hours ago is still showing Anonymous, so I assume it isn't fixed in production yet? However, based on Ted Piotrowski's comment does this mean we can expect a fix in the next maintenance window (or sooner)?

            Is there a fix that will go out for this? The daily email I received at 12:00 am today is still showing anonymous. I am on the On Demand version

            Sue Marmion added a comment - Is there a fix that will go out for this? The daily email I received at 12:00 am today is still showing anonymous. I am on the On Demand version

            I've created a pull request with fixes to the old emails.

            https://stash.atlassian.com/projects/CONF/repos/confluence/pull-requests/1385/overview

            I've asked pcurren to merge them if CBAC says ok.

            Ted Piotrowski (Inactive) added a comment - I've created a pull request with fixes to the old emails. https://stash.atlassian.com/projects/CONF/repos/confluence/pull-requests/1385/overview I've asked pcurren to merge them if CBAC says ok.

            jmasson@atlassian.com and I just confirmed that the ADG versions of both the 'recommended content' and 'changes in last 24 hours' emails are working correctly. This issue only affects the old emails.

            Ted Piotrowski (Inactive) added a comment - - edited jmasson@atlassian.com and I just confirmed that the ADG versions of both the 'recommended content' and 'changes in last 24 hours' emails are working correctly. This issue only affects the old emails.

            Paul Curren added a comment - - edited

            The problem was introduced when the user rename branch was merged to master but isn't actually related to user rename.

            In the old changedigest-notification.vm file, a $page is used. It has been assumed that this was a com.atlassian.confluence.pages.Page object but it isn't. It's actually a com.atlassian.confluence.mail.reports.PageReport and it doesn't have a 'creator' property. This should be changed back to creatorName and lastModifier should be changed by to lastModifierName.
            (See lines 20 and 23.)

            The recommended e-mails are also affected but instead of showing anonymous they will just show no author at all. I think this will be acceptable for OD customers to receive (it won't spook them into thinking anonymous access is enabled on their site).

            The problematic changes in this case are in popular-content.vm:

            #if($contentItem.creator)
                                 <img class="avatar" src="cid:${contentItem.imageDatasources.get($contentItem.creatorName).name}" title="$contentItem.creator.fullName" alt="$contentItem.creator.fullName"/>
                                 <div class="author-name">$i18n.getText("daily.summary.email.popular.author", 
                                    "<span class='author'>$contentItem.creator.fullName</span>")
                                 </div>
                            #end
            

            $contentItem is a com.atlassian.confluence.plugins.dailysummary.content.popular.PopularContentExcerptDto. It doesn't have a 'creator' property. It has a creatorName property instead.

            Paul Curren added a comment - - edited The problem was introduced when the user rename branch was merged to master but isn't actually related to user rename. In the old changedigest-notification.vm file, a $page is used. It has been assumed that this was a com.atlassian.confluence.pages.Page object but it isn't. It's actually a com.atlassian.confluence.mail.reports.PageReport and it doesn't have a 'creator' property. This should be changed back to creatorName and lastModifier should be changed by to lastModifierName. (See lines 20 and 23.) The recommended e-mails are also affected but instead of showing anonymous they will just show no author at all. I think this will be acceptable for OD customers to receive (it won't spook them into thinking anonymous access is enabled on their site). The problematic changes in this case are in popular-content.vm: #if($contentItem.creator) <img class="avatar" src="cid:${contentItem.imageDatasources.get($contentItem.creatorName).name}" title="$contentItem.creator.fullName" alt="$contentItem.creator.fullName"/> <div class="author-name">$i18n.getText("daily.summary.email.popular.author", "<span class='author'>$contentItem.creator.fullName</span>") </div> #end $contentItem is a com.atlassian.confluence.plugins.dailysummary.content.popular.PopularContentExcerptDto . It doesn't have a 'creator' property. It has a creatorName property instead.

              tpiotrowski Ted Piotrowski (Inactive)
              imaduro Ivan Maduro (Inactive)
              Affected customers:
              5 This affects my team
              Watchers:
              35 Start watching this issue

                Created:
                Updated:
                Resolved: