Uploaded image for project: 'Confluence Data Center'
  1. Confluence Data Center
  2. CONFSERVER-25069

[4.2] Quick Comment's loading of editor resources cause style clashes due to unqualified css body selector

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Low Low
    • None
    • 4.2
    • None

      The problem affects our pluginuses jQuery's Sortable/Draggable feaure. When dragging a page (see attachment) the box is shifted.

      The cause is that overflow-x property is set to hidden in the body. That property is set in the editor css.

      So here's the deal.
      Because of Quick Comments's feature the editor resources get loaded (asynchronously) when viewing page.

      The problem is with a css setting in page-editor.css (top of the file):

      body {
          overflow-x: hidden;
      }
      

      That that setting should be qualified to apply only for body.contenteditor. If you look at page-ditor.css everything is properly qualified (through classes and/or hierarcy).

      So, it should be this instead:

      body.contenteditor {
          overflow-x: hidden;
      }
      

            [CONFSERVER-25069] [4.2] Quick Comment's loading of editor resources cause style clashes due to unqualified css body selector

            Paul Curren added a comment - - edited

            I've made the CSS change as described for 4.2.

            Addressing the TODO and your request for an event to be triggered will be covered in 4.2.x or 4.3 development. I've raised CONFDEV-8082 in our development backlog to sort this out.

            Thanks.

            Paul Curren added a comment - - edited I've made the CSS change as described for 4.2. Addressing the TODO and your request for an event to be triggered will be covered in 4.2.x or 4.3 development. I've raised CONFDEV-8082 in our development backlog to sort this out. Thanks.

            Roberto Dominguez added a comment - - edited

            Looks like at least somebody was aware of the potential of this problem as I found this TODO in editor_loader.js:

                    // TODO don't append the CSS until the Editor is actually activated to avoid risk of style clashes
            

            Also, it would be a good idea to fire an event after the Editor CSS stylesheets are loaded.

            Roberto Dominguez added a comment - - edited Looks like at least somebody was aware of the potential of this problem as I found this TODO in editor_loader.js : // TODO don't append the CSS until the Editor is actually activated to avoid risk of style clashes Also, it would be a good idea to fire an event after the Editor CSS stylesheets are loaded.

              pcurren Paul Curren
              cab5e2ae7e1f Roberto Dominguez
              Affected customers:
              1 This affects my team
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: