Don Willis added a comment - 03/May/2011 8:06 AM Resolving as fixed based on Stefan's comment above that the fixed xwork jar is included in 3.5

Roy Hartono [Atlassian] added a comment - 18/Apr/2011 4:55 AM If using Confluence earlier than 3.5, please refer to this KB article: http://confluence.atlassian.com/display/CONFKB/Excessive+HashMap+with+Xwork+Causes+High+CPU+Load

Stefan Saasen (Inactive) added a comment - 04/Apr/2011 8:03 AM Hi Husein, I've updated the fix for version to 3.5 as this was in fact updated for 3.5 and not 3.2-m4. Cheers, Stefan

HuseinA added a comment - 04/Apr/2011 7:54 AM As far as I can see, xwork-1.0.3.2.jar comes bundled only with Confluence 3.5 onwards. Can we change the fix version to 3.5 instead to avoid any confusion to the affected users (3.2.x - 3.4.x)?

Adrian Deccico [Atlassian] added a comment - 28/Feb/2011 3:40 AM sure I'll check it

Matt Ryall added a comment - 28/Feb/2011 3:32 AM Is there any chance we could also get the source JAR deployed to the Maven repo? It would really help a lot with debugging in XWork-related code.

Stefan Saasen (Inactive) added a comment - 25/Feb/2011 6:36 AM I just checked what the changes were between 1.0.3.1 and 1.0.3.2 : Boils down to this: diff --git a/src/java/com/opensymphony/xwork/util/OgnlUtil.java b/src/java/com/opensymphony/xwork/util/OgnlUtil.java index 318889f..abb11ad 100644 --- a/src/java/com/opensymphony/xwork/util/OgnlUtil.java +++ b/src/java/com/opensymphony/xwork/util/OgnlUtil.java @@ -21,6 +21,7 @@ import java.beans.PropertyDescriptor; import java.util.HashMap; import java.util.Iterator; import java.util.Map; + import java.util.concurrent.ConcurrentHashMap; /** @@ -33,7 +34,7 @@ public class OgnlUtil { //~ Static fields/initializers ///////////////////////////////////////////// private static final Log log = LogFactory.getLog(OgnlUtil.class); - private static HashMap expressions = new HashMap(); + private static Map expressions = new ConcurrentHashMap(); //~ Methods //////////////////////////////////////////////////////////////// compile looks like this and is the only place in the code that uses the expressions Map: public static Object compile( String expression) throws OgnlException { Object o = expressions.get(expression); if (o == null ) { o = Ognl.parseExpression(expression); expressions.put(expression, o); } return o; } While using the ConcurrentHashMap might solve the original problem reported, the compile method is still susceptible to race conditions as the put if absent operation isn't atomic.

Adrian Deccico [Atlassian] added a comment - 25/Feb/2011 4:50 AM Hi, I just updated pom version (rev 143600)

Adrian Deccico [Atlassian] added a comment - 25/Feb/2011 4:16 AM Hi, I already uploaded 1.0.3.2 to Atlassian 3rd party repo.

Don Willis added a comment - 23/Feb/2011 11:52 AM This isn't fixed and as far as I can tell it never has been. Confluence is currently (in 3.4.x) still on 1.0.3.1 of this library. 1.0.3.2 is still not deployed to a maven repo.