-
Bug
-
Resolution: Fixed
-
Low
-
None
-
None
In the decorator being rendered for Space Administration > Look and Feel > Layout which is located in /includes/common-listdecorators.vm there are two superfluous tags at the very end of the file (</table></div>) which break my custom layout.
[CONFSERVER-16683] superfluous </table></div> in /includes/common-listdecorators.vm
Hi Josua,
Thanks for explaining, I understand what you mean now. Yes it indeed looks like a bug, to fix it we just need to push the last line of common-listdecorators.vm one level up, so that it is within the else block:
</table></div> #end
Anatoli.
Josua Hunziker
added a comment - Hi Anatoli,
Hm I wanted to attach a HTML Dump of my Page but I didn't really got it working with all the layout being preserved. So I'll try to explain: My custom layout is tableless with floating divs. I honestly did not dive deep into the problem, but when I e.g. open the "Colour Scheme" page everything is ok, but when I open the "Layout" page (where only the error message appears that I can't customize the look and feel when a theme is active) the whole Layout somehow breaks: Some Background Images are not shown anymore and the positioning is messed up. I compared the two files then (/includes/lookandfeel.vm (and also the other layout files for that section) against /includes/common-listdecorators.vm) and found that common-listdecorators.vm is the only file containing that </table></div> tags at the end. I also can't find the opening tags they should match, except e.g. at lines 15&16 inside some #foreach and #if statements, but then the closing tags should not really be at the end of the file outside these tags, right? Or do I understand something totally wrong? Can you otherwise tell me which <div><table> tags these tags should close?
Thanks for your help.
Josua
Josua Hunziker
added a comment - Hi Anatoli,
Hm I wanted to attach a HTML Dump of my Page but I didn't really got it working with all the layout being preserved. So I'll try to explain: My custom layout is tableless with floating divs. I honestly did not dive deep into the problem, but when I e.g. open the "Colour Scheme" page everything is ok, but when I open the "Layout" page (where only the error message appears that I can't customize the look and feel when a theme is active) the whole Layout somehow breaks: Some Background Images are not shown anymore and the positioning is messed up. I compared the two files then (/includes/lookandfeel.vm (and also the other layout files for that section) against /includes/common-listdecorators.vm) and found that common-listdecorators.vm is the only file containing that </table></div> tags at the end. I also can't find the opening tags they should match, except e.g. at lines 15&16 inside some #foreach and #if statements, but then the closing tags should not really be at the end of the file outside these tags, right? Or do I understand something totally wrong? Can you otherwise tell me which <div><table> tags these tags should close?
Thanks for your help.
Josua Hi Josua,
Can you please provide a bit more details about your custom layout. The closing tags inside /includes/common-listdecorators.vm are necessary and they match the opening tags.
Anatoli.
Lovely bit of code there.