Uploaded image for project: 'Clover'
  1. Clover
  2. CLOV-1210

New dark colour scheme makes code covered by uncovered code highlighting unreadable

    • Icon: Suggestion Suggestion
    • Resolution: Fixed
    • 4.0.3
    • CIJ Plugin
    • None
    • IntelliJ IDEA 12.0.2
    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      The colours used for the highlighting make the code fairly unreadable when you use the new dark colour scheme of IDEA 12 (Darcula). See attached screenshot for how unreadable it becomes. Of course, the default colour scheme works as you expect.

      Workaround:

      Open "File -> Settings -> Project Settings -> Clover". Open the "View" tab. In the "Source highlighting" panel click on "Uncovered / Failed / etc" checkboxes and select appropriate colours (the dark ones from second row from the bottom look good). Click "OK".

      To be implemented:

      Prepare two sets of colours (for Default and Darcula schemes) for highlighting. Clover should detect which scheme is the active one upon start-up and select proper highlighting. In case user has different colour set, he could always define Clover's colours manually as described above.

            [CLOV-1210] New dark colour scheme makes code covered by uncovered code highlighting unreadable

            Marek Parfianowicz added a comment - - edited

            TODO: update also https://confluence.atlassian.com/display/CLOVER/5.+IDEA+configuration+options and add a message like:

            Clover 4.0.3 or above handles the Darcula scheme, but you have to restart IDEA after scheme change.

            Marek Parfianowicz added a comment - - edited TODO: update also https://confluence.atlassian.com/display/CLOVER/5.+IDEA+configuration+options and add a message like: Clover 4.0.3 or above handles the Darcula scheme, but you have to restart IDEA after scheme change.

            I've noticed this too. Thanks!

            Marek Parfianowicz added a comment - I've noticed this too. Thanks!

            asmodai added a comment -

            Ah, to follow up to that, after closing the Settings window, the check marks that were there (to show any colours might have changed) are not present any more. So the functionality of the checkboxes as visual indicator that something is/was customised is only present during the period where the Settings window is open.

            asmodai added a comment - Ah, to follow up to that, after closing the Settings window, the check marks that were there (to show any colours might have changed) are not present any more. So the functionality of the checkboxes as visual indicator that something is/was customised is only present during the period where the Settings window is open.

            asmodai added a comment -

            Ah, awesome Marek. Partly mea culpa, I looked at some default locations for this including this tab, but since the Source Highlighting boxes looked like checkmark UI boxes, I did not think further (and hadn't come to that part in the documentation yet) to think clicking on them would also allow me to configure a colour.

            Might it make sense to separate checkbox functionality from colour picker, and have it as [checkbox] [colour picker]? Right now when you click the checkbox and cancel the resulting window popup for the colour picker, it still remains checked. It's a bit unintuitive as it is now.

            But I can at least, knowing what you described, work around the issue at the moment.

            asmodai added a comment - Ah, awesome Marek. Partly mea culpa, I looked at some default locations for this including this tab, but since the Source Highlighting boxes looked like checkmark UI boxes, I did not think further (and hadn't come to that part in the documentation yet) to think clicking on them would also allow me to configure a colour. Might it make sense to separate checkbox functionality from colour picker, and have it as [checkbox] [colour picker] ? Right now when you click the checkbox and cancel the resulting window popup for the colour picker, it still remains checked. It's a bit unintuitive as it is now. But I can at least, knowing what you described, work around the issue at the moment.

            You can define custom colours - see updated description. However, it would be a good idea to have them selected automatically.

            Marek Parfianowicz added a comment - You can define custom colours - see updated description. However, it would be a good idea to have them selected automatically.

            asmodai added a comment -

            Darcula resulting screenshot.

            asmodai added a comment - Darcula resulting screenshot.

              Unassigned Unassigned
              4260b291b33e asmodai
              Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: