• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 5.0.0, 4.14.5
    • 4.11.1
    • Pull Requests
    • None

      Summary

      Similar regression on ---BSERV-3190--- except this is only triggered only after when a user wants to add themselves as a reviewer of a PR. If a user gets invited to a PR instead, this bug doesn't get affected (the 'Merge' button will be enabled or disabled appropriately). 

      Steps to Reproduce

      1. Create a second user and provide write access to a repository
      2. Create a Pull Request and set the minimum number for approval to 1
      3. Login as the second user and add as a reviewer of the Pull Request
      4. Approve that PR

      Expected Results

      The Merge button is enabled and a comment saying that the second user had approve the PR

      Actual Results

      The Merge button is still disabled and nothing is written on the comment

      Workaround

      Refresh the PR page. After refreshing, the merge button should work as expected if the conditions are met. 

        1. pr-approval-4.10.1.mp4
          398 kB
        2. pr-approval-4.11.2.mp4
          1.06 MB
        3. screenshot.png
          screenshot.png
          77 kB
        4. Screen Shot 2019-04-19 at 2.28.50 PM.png
          Screen Shot 2019-04-19 at 2.28.50 PM.png
          635 kB
        5. Screen Shot 2019-04-19 at 3.24.09 PM.png
          Screen Shot 2019-04-19 at 3.24.09 PM.png
          589 kB

            [BSERV-9358] Merge button does not refresh when PR is approved

            Brent P added a comment - - edited

            atantsuyev - A majority of the Bitbucket Server developers use Google Chrome, so I'm pretty confident things are working. Do you see any errors or warnings in the javascript console? Have you tried disabling any extensions you may have installed?

            If neither of those suggestions help, could you raise a support request at https://getsupport.atlassian.com/ and we'll get to the bottom of what's going on.

            Thanks!

            Brent P added a comment - - edited atantsuyev - A majority of the Bitbucket Server developers use Google Chrome, so I'm pretty confident things are working. Do you see any errors or warnings in the javascript console? Have you tried disabling any extensions you may have installed? If neither of those suggestions help, could you raise a support request at https://getsupport.atlassian.com/ and we'll get to the bottom of what's going on. Thanks!

            I didn't see the Merge button on Chrome but saw it on Safari and Firefox. Refreshing the page was not helping! Please take a look at this issue - it might need to be reopened

             

            Sincerely,

            Andrey

            Andriy Tantsuyev (Inactive) added a comment - I didn't see the Merge button on Chrome but saw it on Safari and Firefox. Refreshing the page was not helping! Please take a look at this issue - it might need to be reopened   Sincerely, Andrey

            cezarius added a comment - - edited

            Now another bug. I use 5.0.1.

            My team member go to vocation and did not do PR. I do pr from his fork to main repository. Now i cant merge because need one aproval, but only me can aprove PR to this project. I cant add self as aprover. Now i have big problem because cant merge.

             

            My repository configuration: pull request -> selected require 1 approvers; default reviewers -> any, master, me, 1

            cezarius added a comment - - edited Now another bug. I use 5.0.1. My team member go to vocation and did not do PR. I do pr from his fork to main repository. Now i cant merge because need one aproval, but only me can aprove PR to this project. I cant add self as aprover. Now i have big problem because cant merge.   My repository configuration: pull request -> selected require 1 approvers; default reviewers -> any, master, me, 1

            Kristy added a comment -

            Thank you to those of you who opened support cases for us to investigate this. We have now identified the problem and the fix will be included in upcoming releases.

            Kristy added a comment - Thank you to those of you who opened support cases for us to investigate this. We have now identified the problem and the fix will be included in upcoming releases.

            Kristy added a comment -

            After a lot of manual testing, we are able to reproduce this bug although not consistently. Our automated tests which check for this bug are passing, and manually the bug sometimes appears to be fixed and sometimes not.

            We will be investigating this further.

            Thanks for your patience,

            Kristy

            Kristy added a comment - After a lot of manual testing, we are able to reproduce this bug although not consistently. Our automated tests which check for this bug are passing, and manually the bug sometimes appears to be fixed and sometimes not. We will be investigating this further. Thanks for your patience, Kristy

            cezarius added a comment - - edited

            updated to 4.14.2 but still exists merge button bug

            cezarius added a comment - - edited updated to 4.14.2 but still exists merge button bug

            cezarius added a comment -

            I use this addons: Awesome Graphs for Bitbucket Server, Bitbucket Server Archive Plugin, Commit Graph

            repository configuration: branch master Changes without a pull request excep me, default reviewers master branch is me and need 1 approvals

            we work 2 with same project. i work on master repository. another member have fork and work on own repository. when he done work make PR from forked to master. I open PR and press approve. merge button still disabled. I must press F5 and merge button enabled.

            When we have PR i can do movie with smartphone if need or take screenshots.

            cezarius added a comment - I use this addons: Awesome Graphs for Bitbucket Server, Bitbucket Server Archive Plugin, Commit Graph repository configuration: branch master Changes without a pull request excep me, default reviewers master branch is me and need 1 approvals we work 2 with same project. i work on master repository. another member have fork and work on own repository. when he done work make PR from forked to master. I open PR and press approve. merge button still disabled. I must press F5 and merge button enabled. When we have PR i can do movie with smartphone if need or take screenshots.

            jj added a comment -

            Just want to confirm - for our Bitbucket Server instance it is fixed.

            jj added a comment - Just want to confirm - for our Bitbucket Server instance it is fixed.

            Brent P added a comment -

            info1934850947 - We tested this on 4.14 and can't reproduce as described in the "steps to reproduce". We also added an automated test to ensure it won't break again.

            We're pretty confident this won't happen on a new instance of Bitbucket Server with no plugins installed. However, there is always a chance we're missing something (an environmental factor, a third-party plugin, or maybe a missing step in the "steps to reproduce").

            We'd love to fix this for you. Please raise a support ticket at https://support.atlassian.com/ . That gives us a chance to find out more about your installation and debug the problem.

            Thanks!

            Brent P added a comment - info1934850947 - We tested this on 4.14 and can't reproduce as described in the "steps to reproduce". We also added an automated test to ensure it won't break again. We're pretty confident this won't happen on a new instance of Bitbucket Server with no plugins installed. However, there is always a chance we're missing something (an environmental factor, a third-party plugin, or maybe a missing step in the "steps to reproduce"). We'd love to fix this for you. Please raise a support ticket at https://support.atlassian.com/ . That gives us a chance to find out more about your installation and debug the problem. Thanks!

            cezarius added a comment -

            Also still exists in version 4.14

            cezarius added a comment - Also still exists in version 4.14

              khughes@atlassian.com Kristy
              aer Andrew Er (Inactive)
              Affected customers:
              3 This affects my team
              Watchers:
              12 Start watching this issue

                Created:
                Updated:
                Resolved: