• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Medium Medium
    • 5.0.0, 4.14.5
    • 4.11.1
    • Pull Requests
    • None

      Summary

      Similar regression on ---BSERV-3190--- except this is only triggered only after when a user wants to add themselves as a reviewer of a PR. If a user gets invited to a PR instead, this bug doesn't get affected (the 'Merge' button will be enabled or disabled appropriately). 

      Steps to Reproduce

      1. Create a second user and provide write access to a repository
      2. Create a Pull Request and set the minimum number for approval to 1
      3. Login as the second user and add as a reviewer of the Pull Request
      4. Approve that PR

      Expected Results

      The Merge button is enabled and a comment saying that the second user had approve the PR

      Actual Results

      The Merge button is still disabled and nothing is written on the comment

      Workaround

      Refresh the PR page. After refreshing, the merge button should work as expected if the conditions are met. 

        1. Screen Shot 2019-04-19 at 2.28.50 PM.png
          Screen Shot 2019-04-19 at 2.28.50 PM.png
          635 kB
        2. Screen Shot 2019-04-19 at 3.24.09 PM.png
          Screen Shot 2019-04-19 at 3.24.09 PM.png
          589 kB
        3. pr-approval-4.11.2.mp4
          1.06 MB
        4. pr-approval-4.10.1.mp4
          398 kB
        5. screenshot.png
          screenshot.png
          77 kB

            [BSERV-9358] Merge button does not refresh when PR is approved

            John van der Loo (Inactive) made changes -
            Attachment Original: 1z0-477-dumps.pdf [ 348559 ]
            John van der Loo (Inactive) made changes -
            Attachment Original: 1Z0-962-dumps.pdf [ 348560 ]
            Ray Renee made changes -
            Attachment New: 1Z0-962-dumps.pdf [ 348560 ]
            Ray Renee made changes -
            Attachment New: 1z0-477-dumps.pdf [ 348559 ]
            Andriy Tantsuyev (Inactive) made changes -
            Comment [ I didn't see the Merge button on Chrome but saw it on Safari and Firefox. Refreshing the page was not helping! Please take a look at this issue - it might need to be reopened. Screenshots are below

             

            Sincerely,

            Andrey ]
            Andriy Tantsuyev (Inactive) made changes -
            Comment [ I didn't see the Merge button on Chrome but saw it on Safari and Firefox. Refreshing the page was not helping! Please take a look at this issue - it might need to be reopened. Screenshots are below

             

            Sincerely,

            Andrey

             

             

             

            !Screen Shot 2019-04-19 at 2.28.50 PM.png!!Screen Shot 2019-04-19 at 3.24.09 PM.png! ]
            Andriy Tantsuyev (Inactive) made changes -
            Attachment New: Screen Shot 2019-04-19 at 2.28.50 PM.png [ 348372 ]
            Andriy Tantsuyev (Inactive) made changes -
            Attachment New: Screen Shot 2019-04-19 at 3.24.09 PM.png [ 348371 ]
            Owen made changes -
            Workflow Original: Stash Workflow - Restricted [ 1625491 ] New: JAC Bug Workflow v3 [ 3137018 ]
            Owen made changes -
            Symptom Severity Original: Minor [ 14432 ] New: Severity 3 - Minor [ 15832 ]

              khughes@atlassian.com Kristy
              aer Andrew Er (Inactive)
              Affected customers:
              3 This affects my team
              Watchers:
              12 Start watching this issue

                Created:
                Updated:
                Resolved: