Repository import fails to parse git url with trailing space

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: Low
    • 4.10.0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Severity 3 - Minor

      Repository import will fail to import a repository when there is a trailing space in the git url. This only occurs when passing in auth via username/password. 

       

      Example error in logs: 

      2016-09-19 10:47:38,769 WARN [pool-7-thread-3] admin @1LYGELx647x137x0 ojysym 0:0:0:0:0:0:0:1 "POST /rest/importer/latest/projects/PROJ/import/repos HTTP/1.1" c.a.s.i.s.g.c.f.MirrorSynchronizeCommand Could not set user in remote URL https://github.com/PROJECT/cmt_web.git
java.net.URISyntaxException: Illegal character in path at index 41: https://github.com/PROJECT/cmt_web.git
 at java.net.URI$Parser.fail(URI.java:2848) ~[na:1.8.0_66]
 at java.net.URI$Parser.checkChars(URI.java:3021) ~[na:1.8.0_66]
 at java.net.URI$Parser.parseHierarchical(URI.java:3105) ~[na:1.8.0_66]
 at java.net.URI$Parser.parse(URI.java:3053) ~[na:1.8.0_66]
 at java.net.URI.<init>(URI.java:588) ~[na:1.8.0_66]
 at com.atlassian.bitbucket.util.UrlUtils.interpolateUserInfo(UrlUtils.java:254) ~[bitbucket-util-4.10.0-SNAPSHOT.jar:na]
 at com.atlassian.stash.internal.scm.git.command.fetch.MirrorSynchronizeCommand.lambda$call$47(MirrorSynchronizeCommand.java:60) ~[na:na]
 at java.util.Optional.map(Optional.java:215) ~[na:1.8.0_66]
 at com.atlassian.stash.internal.scm.git.command.fetch.MirrorSynchronizeCommand.call(MirrorSynchronizeCommand.java:57) ~[na:na]
 at com.atlassian.stash.internal.scm.git.command.fetch.MirrorSynchronizeCommand.call(MirrorSynchronizeCommand.java:27) ~[na:na]
 at com.atlassian.bitbucket.internal.importer.repository.RefSyncTask.syncRefs(RefSyncTask.java:114) ~[bitbucket-importer-4.10.0-SNAPSHOT.jar:na]
 at com.atlassian.bitbucket.internal.importer.repository.RefSyncTask.lambda$call$27(RefSyncTask.java:74) ~[bitbucket-importer-4.10.0-SNAPSHOT.jar:na]
 at com.atlassian.stash.internal.user.DefaultEscalatedSecurityContext.call(DefaultEscalatedSecurityContext.java:51) ~[bitbucket-service-impl-4.10.0-SNAPSHOT.jar:na]
 at com.atlassian.bitbucket.internal.importer.repository.RefSyncTask.call(RefSyncTask.java:73) ~[bitbucket-importer-4.10.0-SNAPSHOT.jar:na]
 at com.atlassian.bitbucket.internal.importer.repository.RefSyncTask.call(RefSyncTask.java:33) ~[bitbucket-importer-4.10.0-SNAPSHOT.jar:na]
 at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[na:1.8.0_66]
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) ~[na:1.8.0_66]
 at java.lang.Thread.run(Thread.java:745) ~[na:1.8.0_66]
 ... 1 frame trimmed

            Assignee:
            Paul Thompson (Inactive)
            Reporter:
            Fraser
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: