Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-8875

Smart Commits - only run actions from commits authored by the pusher

XMLWordPrintable

    • We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

      Currently Smart Commits parses every commit message and executes any actions as the author of that commit. This means a malicious person given access to your codebase can act as another user for Smart Commit actions, and instances that don't have this level of trust in the people writing their code can't use Smart Commits.

      This suggestion is to introduce an option that will only execute actions on commits where the author's email address matches the email address of the Bitbucket Server user doing the push.

      This means a pusher can't maliciously attribute actions to others, but also means that if a pusher is the first person to push someone else's commits to Bitbucket Server, those commits will never have their actions run.

      Workaround

      Bitbucket Server 5.0 includes the "Verify committer" repository hook that ensures all new commits are authored by the person pushing them. If you enable this hook, the pusher will not be able to perform actions on behalf of other users by faking commit data.

       

            [BSERV-8875] Smart Commits - only run actions from commits authored by the pusher

            Katherine Yabut made changes -
            Workflow Original: JAC Suggestion Workflow [ 3394927 ] New: JAC Suggestion Workflow 3 [ 3623439 ]
            Status Original: RESOLVED [ 5 ] New: Closed [ 6 ]
            Monique Khairuliana (Inactive) made changes -
            Workflow Original: BSERV Suggestions Workflow [ 2683550 ] New: JAC Suggestion Workflow [ 3394927 ]
            Owen made changes -
            Workflow Original: Stash Workflow [ 1422571 ] New: BSERV Suggestions Workflow [ 2683550 ]
            Status Original: Closed [ 6 ] New: Resolved [ 5 ]
            Roger Barnes (Inactive) made changes -
            Resolution New: Answered [ 9 ]
            Status Original: Open [ 1 ] New: Closed [ 6 ]

            Roger Barnes (Inactive) added a comment -

            Given the currently available workaround, it's unlikely we'd also make changes to only apply smart commits when authored by the same person that's pushing.

            Please comment here if there are significant issues arising despite the workaround and we'll reconsider.

            Roger Barnes (Inactive) added a comment - Given the currently available workaround, it's unlikely we'd also make changes to only apply smart commits when authored by the same person that's pushing. Please comment here if there are significant issues arising despite the workaround and we'll reconsider.
            Brent P made changes -
            Description Original: Currently Smart Commits parses every commit message and executes any actions as the author of that commit. This means a malicious person given access to your codebase can act as another user for Smart Commit actions, and instances that don't have this level of trust in the people writing their code can't use Smart Commits.

            This suggestion is to introduce an option that will only execute actions on commits where the author's email address matches the email address of the Bitbucket Server user doing the push.

            This means a pusher can't maliciously attribute actions to others, but also means that if a pusher is the first person to push someone else's commits to Bitbucket Server, those commits will never have their actions run.
            h2. Workaround

            Bitbucket Server 5.0 includes a repository hook that requires all pushed commits come

                          		New: Currently Smart Commits parses every commit message and executes any actions as the author of that commit. This means a malicious person given access to your codebase can act as another user for Smart Commit actions, and instances that don't have this level of trust in the people writing their code can't use Smart Commits.

            This suggestion is to introduce an option that will only execute actions on commits where the author's email address matches the email address of the Bitbucket Server user doing the push.

            This means a pusher can't maliciously attribute actions to others, but also means that if a pusher is the first person to push someone else's commits to Bitbucket Server, those commits will never have their actions run.
            h2. Workaround

            Bitbucket Server 5.0 includes the ["Verify committer" repository hook|https://confluence.atlassian.com/display/BitbucketServer/Bitbucket+Server+5.0+release+notes#BitbucketServer5.0releasenotes-Committerverification] that ensures all new commits are authored by the person pushing them. If you enable this hook, the pusher will not be able to perform actions on behalf of other users by faking commit data.

             
            Brent P made changes -
            Description Original: Currently Smart Commits parses every commit message and executes any actions as the author of that commit. This means a malicious person given access to your codebase can act as another user for Smart Commit actions, and instances that don't have this level of trust in the people writing their code can't use Smart Commits.

            This suggestion is to introduce an option that will only execute actions on commits where the author's email address matches the email address of the Bitbucket Server user doing the push.

            This means a pusher can't maliciously attribute actions to others, but also means that if a pusher is the first person to push someone else's commits to Bitbucket Server, those commits will never have their actions run.             		New: Currently Smart Commits parses every commit message and executes any actions as the author of that commit. This means a malicious person given access to your codebase can act as another user for Smart Commit actions, and instances that don't have this level of trust in the people writing their code can't use Smart Commits.

            This suggestion is to introduce an option that will only execute actions on commits where the author's email address matches the email address of the Bitbucket Server user doing the push.

            This means a pusher can't maliciously attribute actions to others, but also means that if a pusher is the first person to push someone else's commits to Bitbucket Server, those commits will never have their actions run.
            h2. Workaround

            Bitbucket Server 5.0 includes a repository hook that requires all pushed commits come

             
            Brent P made changes -
            Remote Link New: This issue links to "Page (Extranet)" [ 279462 ]
            Adam Ahmed (Inactive) made changes -
            Assignee Original: Adam Ahmed [ aahmed ]
            Adam Ahmed (Inactive) made changes -
            Summary Original: Smart Commits allow a user without permissions to a JIRA ticket to take action on that ticket as another user New: Smart Commits - only run actions from commits authored by the pusher

              Unassigned Unassigned
              smaruvada Shashank Maruvada
              Votes:
              1 Vote for this issue
              Watchers:
              11 Start watching this issue

                Created:
                Updated:
                Resolved: