Details
-
Bug
-
Resolution: Fixed
-
Medium
-
3.3.1, 3.6.1, 3.8.0
Description
If a file has greater than 10,000 lines and is then deleted the diff will never load on a pull request.
This can be reproduced by:
- Creating a file with 10,001 lines
- Adding that file and committing it to a branch (add)
- Creating a new branch from the original named remove
- Deleting that file, committing and pushing both branches
- Creating a pull request with a source of remove and destination of add
- Viewing the diff tab of the pull request will cause the request to spin because of a JS error:
JS console shows a Uncaught TypeError: Cannot read property 'toString' of null on line 2505 of batch.js
File type does not seem to be of consequence this works on several versions of Stash.
Changing page.max.diff.lines=10000 in stash-config.properties has no effect either.