Loading...

XML

Word

Printable

Details

Type: Suggestion
Resolution: Fixed
Fix Version/s: 7.0.0
Component/s: None
Labels:
- devexp
Environment:

Hide

*Location*: https://stash.atlassian.com/projects/JIRA/repos/jira/pull-requests/1183/overview?commentId=77307
*User-Agent*: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36
*Screen Resolution*: 1920 x 1200

Show
*Location*: https://stash.atlassian.com/projects/JIRA/repos/jira/pull-requests/1183/overview?commentId=77307 *User-Agent*: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/35.0.1916.153 Safari/537.36 *Screen Resolution*: 1920 x 1200

Feedback Policy:

We collect Bitbucket feedback from various sources, and we evaluate what we've collected when planning our product roadmap. To understand how this piece of feedback will be reviewed, see our Implementation of New Features Policy.

Description

Atlassian status as of March 2020

Hi all,

I'm excited to share that in Bitbucket Server 7.0 we shipped redesigned and optimized pull request page with several improvements you’ve been asking us, including support of the native Ctrl+F search dialog. The page will not hijack browser search dialog anymore, which will add comfort to your code review experience.

You can find more information in the Bitbucket Server 7.0 release notes and Pull Requests documentation.

Please, don't hesitate to leave feedback on the feature in the comments. This will help us to priorities further development.

Anton Genkin
Product Manager Bitbucket Server

Original message

It wouldn't be horrible except that in my browser, ctrl+f allows me to press enter to cycle between the N matches that are on the page. Pressing enter in stash's ctrl+f closes the find window and doesn't scroll to the next match.

Is outputting the full file at a given commit hash then overlaying the diff a significant performance issue? Can we make it work for files up to a certain reasonable size, and only incur the poor UX if your file is over a certain length?

Attachments

Issue Links

is duplicated by

BSERV-7757 Stash hijacks Ctrl-F

Closed

BSERV-4585 Code search UX issues on diff views

Closed

BSERV-7231 Ability to disable Stash's control/command-F

Closed

BSERV-8386 While reviewing some source changes in Stash, I wished to know how a particular variable was used throughout the diff of a particular file. I

Closed

relates to

BSERV-4585 Code search UX issues on diff views

Closed

BSERV-7068 Search broken in browse file pages

Closed

BSERV-7361 Disable keyboard shortcuts

Closed

BSERV-14048 Stop overriding Cmd/Ctrl+F in source view and file editor

Gathering Interest

BSERV-14049 "Search code" in diff must search across all file lines

Gathering Interest

mentioned in: Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...; Page Loading...

(4 relates to, 10 mentioned in)

Activity

People

Assignee:: Unassigned

Reporter:: ig (Inactive)

Votes:: 92 Vote for this issue

Watchers:: 66 Start watching this issue

Dates

Created:: 03/Jul/2014 4:34 AM

Updated:: 01/May/2023 5:09 AM

Resolved:: 06/Mar/2020 12:53 AM