Thanks Bryan, issue opened

idan.bidani,

That error means the unique constaints are working. Put differently, it shows that this issue is fixed. Previously, the duplicate insert would have just worked, and corrupted the data.

That error should be benign (it shouldn't happen at all, of course, but when it does it should be benign). Are you seeing it often? When does it happen? You might want to open a ticket at support.atlassian.com, where you can share details and logs with us privately, rather than trying to diagnose the problem here.

Best regards,
Bryan Turner
Atlassian Bitbucket

I'm seeing this error on Bitbucket 5.6.2 with Postgres

Any idea what could cause it to happen if this was fixed?

Thanks

< 2018-09-17 10:18:28.039 EDT > ERROR:  duplicate key value violates unique constraint "uk_mem_dir_parent_child"
< 2018-09-17 10:18:28.039 EDT > DETAIL:  Key (directory_id, lower_child_name, lower_parent_name, membership_type)=(4325377, <<REAL_USERID>>, <<REAL_DL_NAME>>, GROUP_USER) already exists.
< 2018-09-17 10:18:28.039 EDT > STATEMENT:  insert into cwd_membership (parent_id, child_id, membership_type, group_type, parent_name, lower_parent_name, child_name, lower_child_name, created_date, directory_id, id) values ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11)

heshanm - We updated the priority. Note that this issue was already fixed in Stash 3.7.0.

Atlassian,

Can you please let me know how you guys prioritize this as a minor bug, since one or more users are unable to access the system due to sync fail.

Cheers,
heshan

As part of the fix a unique key constraint has been added to `cwd_membership`.

Thanks Bjarni, that's perfect.

looking at the database table definitions for this it looks like a similar (but not the same) problem. I've created STASH-5244 to track this issue.

cheers,
James

Hi James,

Here is what I confirm:

• JIRA tables are OK
• Stash cwd_user contains the duplicates and these users can not log in
• Stash cwd_membership did not contain any entries for the one of the "bad entries" (like I had the same user twice, one of these users had entries in the membership table but the other one not)
• I'm running Stash 2.12.1
• I see the same error in my log as is reported (that is how I found this issue)

I fixed this myself by simply deleting the "second user" from the cwd_user table in Stash.

Hope this helps,

-Bjarni

Hi Bjarni,

could you please confirm that what you are seeing is:

• JIRA tables are fine (no duplicates in cwd_user or cwd_membership)
• Stash cwd_user contains duplicates (as above)
  • These users cannot log in
• Stash cwd_membership does not contain duplicates

If this is the case it looks like a different problem and if you haven't fixed it yourself we should open a support ticket for you. If you have fixed it I'll create a new bug report to get this fixed.

Some related questions:

• what version of Stash are you using?
• are you seeing error logging related to the failed login?

We will hopefully have a fix to the problem originally on this ticket soon.

cheers,
James

One more thing,

When I execute the query above on the Stash database, I do get several duplicates but when I execute the same query on the JIRA database nothing shows.

JIRA is synced with AD and Stash is synced with JIRA.

Thanks again,

-Bjarni