Details
-
Bug
-
Resolution: Fixed
-
Low
-
None
-
None
Description
Our Stash.a.c logs are filled with these errors:
2013-10-04 10:56:52,009 WARN [threadpool:thread-16440] user1 656x98029x2 1dhhznz 172.24.4.5 SSH - git-upload-pack '/stash/stash.git' c.a.s.i.s.g.p.ssh.GitSshScmRequest upload-pack did not complete. It will be assumed the command failed 2013-10-04 10:56:52,386 WARN [threadpool:thread-16414] user2 656x98031x2 wt1fey 172.24.4.5 SSH - git-upload-pack '/bam/bamboo.git' c.a.s.i.s.g.p.ssh.GitSshScmRequest upload-pack did not complete. It will be assumed the command failed 2013-10-04 11:02:40,113 WARN [threadpool:thread-16615] user3 662x98902x1 7rznq7 172.24.4.5 SSH - git-upload-pack '/conf/confluence-questions.git' c.a.s.i.s.g.p.ssh.GitSshScmRequest upload-pack did not complete. It will be assumed the command failed
This error is logged when the git process exithandler has not been called when the process terminates. This can happen in SCM cache on cache misses for ref advertisement because the SCM cache writes the final flush packet just before it closes the process output streams.
Additional debug logging shows that the streams are indeed being closed before the git process finishes normally.
2013-10-04 11:24:40,467 DEBUG [threadpool:thread-17361] user4 684x102215x1 llzyfc 172.24.4.5 SSH - git-upload-pack '/pfe/lab-in-a-can.git' c.a.s.i.s.g.p.ssh.GitSshExitHandler /usr/bin/git upload-pack /opt/j2ee/domains/atlassian.com/stash-prod/home/data/repositories/482. (Exit code: '143') 2013-10-04 11:24:40,467 WARN [threadpool:thread-17361] user4 684x102215x1 llzyfc 172.24.4.5 SSH - git-upload-pack '/pfe/lab-in-a-can.git' c.a.s.i.s.g.p.ssh.GitSshScmRequest upload-pack did not complete. It will be assumed the command failed