-
Type:
Bug
-
Resolution: Answered
-
Priority:
Low
-
None
-
Affects Version/s: 2.6.2
-
Component/s: None
-
None
-
Environment:
1. Run a build against a given commit on a pull request, in a way that will result in a build failure. The overall PR build status should show Build Failure icon, as well as the most recent commit showing the same Build Failure icon.
2. Run a rebuild against the same commit, in a way that will result in the build succeeding. The overall PR build status should go to a green Build Success icon, but it does not. If you click on it to see Build History, you'll see the most recent build was green, but that was not good enough to update the overall status to green. This same is true when reviewing that most-recent-commit build status.1. Run a build against a given commit on a pull request, in a way that will result in a build failure. The overall PR build status should show Build Failure icon, as well as the most recent commit showing the same Build Failure icon. 2. Run a rebuild against the same commit, in a way that will result in the build succeeding. The overall PR build status should go to a green Build Success icon, but it does not. If you click on it to see Build History, you'll see the most recent build was green, but that was not good enough to update the overall status to green. This same is true when reviewing that most-recent-commit build status.
When viewing the Build Status for a given PR overall, as well as for individual commits, a single Build Failure will result in the overall Build Status to be shown as Failure even when subsequent builds are successful.
Note how the overall PR build status shows failure (far right), but the popup build history shows the most recent build was successful:
(see BUG-OverallBuild.png)
Here again, note how the given commit (the top one) shows build failure (far right), but the popup build history for it shows the most recent build was successful:
(see BUG-CommitBuild.png)
I am seeing this behavior on Stash v2.6.2 while using the Jenkins webhook v1.1 (https://github.com/Nerdwin15/stash-jenkins-postreceive-webhook). I filed an Issue there first (https://github.com/Nerdwin15/stash-jenkins-postreceive-webhook/issues/29), but I can't see any spot in the plugin code where this icon choice would be controlled. Thus, I'm guessing it's an overall behavior in Stash itself.
