We couldn't load all Actvitity tabs. Refresh the page to try again.
If the problem persists, contact your Jira admin.
IMPORTANT: JAC is a Public system and anyone on the internet will be able to view the data in the created JAC tickets. Please don’t include Customer or Sensitive data in the JAC ticket.
Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-13190

Edit Comment : Toolbar: Toolbar is missing appropriate role and/or attributes

    Issue Summary

    The toolbar element for edit comments in the pull request appears and functions like a toolbar but is missing the required ARIA role(s) and/or attribute(s).

    Steps to Reproduce

    1. Launch the URL
    2. Navigate to the comment section on the pull request page.
    3. Activate the "Edit" link available on any comment.
    4. Navigate into the text input area for the comment and navigate into the toolbar.

    Actual Results

    In the Edit comment for pull requests, the role is not defined for the interactive toolbar div element. This made it difficult for screen reader users to access the functionality associated with it.

    When native HTML elements are used basic information about an element, such as name, role, state and value are exposed to assistive technologies by default. However, for custom components, this information needs to be made available for assistive technologies, so users can interact with the custom components effectively.

    Expected Results

    Apply the following changes:
    • Provide role="toolbar" for the <div> element containing the mentioned element.
    • Provide hidden instructions such as "Use this toolbar to edit the comment for pull request". This instruction should be before buttons in the page source.

    A working example of a toolbar: https://www.w3.org/TR/wai-aria-practices/examples/toolbar/toolbar.html 

    Screenshot

    Workaround

    Currently, there is no known workaround for this behaviour. A workaround will be added here when available.

    Bug Ref: 737179

          Loading...
          IMPORTANT: JAC is a Public system and anyone on the internet will be able to view the data in the created JAC tickets. Please don’t include Customer or Sensitive data in the JAC ticket.
          Uploaded image for project: 'Bitbucket Data Center'
          1. Bitbucket Data Center
          2. BSERV-13190

          Edit Comment : Toolbar: Toolbar is missing appropriate role and/or attributes

            Issue Summary

            The toolbar element for edit comments in the pull request appears and functions like a toolbar but is missing the required ARIA role(s) and/or attribute(s).

            Steps to Reproduce

            1. Launch the URL
            2. Navigate to the comment section on the pull request page.
            3. Activate the "Edit" link available on any comment.
            4. Navigate into the text input area for the comment and navigate into the toolbar.

            Actual Results

            In the Edit comment for pull requests, the role is not defined for the interactive toolbar div element. This made it difficult for screen reader users to access the functionality associated with it.

            When native HTML elements are used basic information about an element, such as name, role, state and value are exposed to assistive technologies by default. However, for custom components, this information needs to be made available for assistive technologies, so users can interact with the custom components effectively.

            Expected Results

            Apply the following changes:
            • Provide role="toolbar" for the <div> element containing the mentioned element.
            • Provide hidden instructions such as "Use this toolbar to edit the comment for pull request". This instruction should be before buttons in the page source.

            A working example of a toolbar: https://www.w3.org/TR/wai-aria-practices/examples/toolbar/toolbar.html 

            Screenshot

            Workaround

            Currently, there is no known workaround for this behaviour. A workaround will be added here when available.

            Bug Ref: 737179

                    cb3955cd8c67 Carlos Sanchez Rosa
                    12b69dcabe29 Matthew Brennan
                    Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                      Created:
                      Updated:
                      Resolved:

                          cb3955cd8c67 Carlos Sanchez Rosa
                          12b69dcabe29 Matthew Brennan
                          Affected customers:
                          0 This affects my team
                          Watchers:
                          2 Start watching this issue

                            Created:
                            Updated:
                            Resolved: