Details
High Description
Summary
After upgrading to 5.16.x, the application logs contain a git-upload-pack message.
2019-04-07 11:18:20,257 WARN [ssh-scm-request-handler] 2aae8be9f4e1c695 *1WVLUW5x678x6222x1 uir0m7 142.136.201.251 SSH - git-upload-pack '/techmobile/server.git' c.a.s.i.s.g.p.s.CachingSshUploadPack TECHMOBILE/server[225]: git-upload-pack did not complete. It will be assumed the command failed
This appears to be a manifestation of https://jira.atlassian.com/browse/BSERV-11330 but customers that have upgraded to 5.16.x still see the warnings.
Apart from this warning message in the logs, there don't seem to be any issues
Steps to Reproduce
It can be reproduced intermittently by performing multiple concurrent git fetches of the same repository at the same time over the ssh protocol and when it's either a cache:miss or a cache:bypass (ref advertisement cache is not enabled).
Expected Results
No warning message should appear in the application logs.
Actual Results
The below exception is thrown in the atlassian-bitbucket.log file:
2019-04-07 11:18:20,257 WARN [ssh-scm-request-handler] 2aae8be9f4e1c695 *1WVLUW5x678x6222x1 uir0m7 142.136.201.251 SSH - git-upload-pack '/techmobile/server.git' c.a.s.i.s.g.p.s.CachingSshUploadPack TECHMOBILE/server[225]: git-upload-pack did not complete. It will be assumed the command failed
Workaround
These can be turned off using a REST API call (without the need of a restart), but users will lose the visibility that they have been turned off and miss new warnings in the future. For this reason our recommendation is to add the following to the bitbucket.properties file and restart or let the next restart apply the new setting:
logging.logger.com.atlassian.stash.internal.scm.git.protocol.ssh.CachingSshUploadPack=ERROR
This line is increasing the log level from WARN to ERROR.
The API workaround only applies until Bitbucket is stopped, upon restart the values in the bitbucket.properties or the defaults apply.
This is the endpoint to use for changing the log level to ERROR:
curl -u <USER> -v -X PUT -d "" -H "Content-Type: application/json" <BITBUCKET URL>/rest/api/latest/logs/logger/com.atlassian.stash.internal.scm.git.protocol.ssh.CachingSshUploadPack/error
