Uploaded image for project: 'Bitbucket Data Center'
  1. Bitbucket Data Center
  2. BSERV-10223

Git command factories do not null-check their parameters

XMLWordPrintable

      When calling any of the Git SCM's CommandFactory types, the method parameters are marked as @Nonnull, but the implementations don't always enforce it. In certain cases, that actually allows starting invalid git processes which can fail in unexpected ways.

          Form Name

            [BSERV-10223] Git command factories do not null-check their parameters

            Owen made changes -
            Workflow Original: Stash Workflow - Restricted [ 2447179 ] New: JAC Bug Workflow v3 [ 3136281 ]
            Owen made changes -
            Symptom Severity Original: Minor [ 14432 ] New: Severity 3 - Minor [ 15832 ]
            Bryan Turner (Inactive) made changes -
            Fix Version/s New: 5.0.9 [ 75186 ]
            Fix Version/s New: 5.1.8 [ 75187 ]
            Fix Version/s New: 5.2.6 [ 75188 ]
            Fix Version/s New: 5.5.0 [ 74868 ]
            Fix Version/s New: 5.3.4 [ 75169 ]
            Fix Version/s New: 5.4.2 [ 75170 ]
            Resolution New: Fixed [ 1 ]
            Status Original: To be reviewed [ 10026 ] New: Closed [ 6 ]
            Bryan Turner (Inactive) made changes -
            Remote Link New: This issue links to "Bitbucket Server › 5.4.X › BSERV-10223-bturner-merge-5.3-to-5.4 (server-syd-bamboo)" [ 325473 ]
            Bryan Turner (Inactive) made changes -
            Remote Link New: This issue links to "Bitbucket Server › Pull Request Build › BSERV-10223-bturner-merge-5.3-to-5.4 (server-syd-bamboo)" [ 325354 ]
            Bryan Turner (Inactive) made changes -
            Remote Link New: This issue links to "Bitbucket Server › Pull Request Build with Coverage › BSERV-10223-bturner-merge-5.3-to-5.4 (server-syd-bamboo)" [ 325459 ]
            Bryan Turner (Inactive) made changes -
            Remote Link New: This issue links to "Bitbucket Server › Pull Request Build with Coverage › BSERV-10223-bturner-merge-5.0-to-5.1 (server-syd-bamboo)" [ 324800 ]
            Bryan Turner (Inactive) made changes -
            Remote Link New: This issue links to "Bitbucket Server › Pull Request Build › BSERV-10223-bturner-merge-5.0-to-5.1 (server-syd-bamboo)" [ 324599 ]
            Bryan Turner (Inactive) made changes -
            Remote Link New: This issue links to "Bitbucket Server › 5.0.X › BSERV-10223-bturner-null-checks-in-git-factories (server-syd-bamboo)" [ 324194 ]
            Bryan Turner (Inactive) made changes -
            Status Original: In Progress [ 3 ] New: To be reviewed [ 10026 ]

              bturner Bryan Turner (Inactive)
              bturner Bryan Turner (Inactive)
              Affected customers:
              0 This affects my team
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: