Uploaded image for project: 'Bitbucket Cloud'
  1. Bitbucket Cloud
  2. BCLOUD-22614

Add merge check for no unresolved pull request comments

XMLWordPrintable

    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      Now that https://jira.atlassian.com/browse/BCLOUD-6535 is done it would be good to be able to restrict pull requests from being merged if there are any unresolved PR comments.

      This would greatly increase the utility of resolvable pull request comments.

      Note: This is actually intended for the Bitbucket Cloud (BCLOUD) project but I was unable to select that.

            [BCLOUD-22614] Add merge check for no unresolved pull request comments

            Greg Freeland added a comment -

            With the new PR UI, we've had an uptick of PRs getting merged with open comments. While the new activity feed is pretty useful, it seems to have made PR comments even easier to miss. I think this feature would be very useful.

            Greg Freeland added a comment - With the new PR UI, we've had an uptick of PRs getting merged with open comments. While the new activity feed is pretty useful, it seems to have made PR comments even easier to miss. I think this feature would be very useful.

            Chris Moore added a comment -

            This seems like it would be a useful addition to the core Bitbucket Cloud product.

            Chris Moore added a comment - This seems like it would be a useful addition to the core Bitbucket Cloud product.

            Saxea _Flowie_ added a comment -

            We have added support in Flowie for the 'no unresolved comments' merge check, with the option to restrict who can resolve the comment in order for the check to pass. See details here.

            Saxea _Flowie_ added a comment - We have added support in Flowie for the 'no unresolved comments' merge check, with the option to restrict who can resolve the comment in order for the check to pass. See details here .

            Pierre-Emmanuel Larrouturou added a comment -

            That would be very useful. FYI sometimes the PR author adds comments to their own PR, to explain why code was changed in a certain way. Ideally, the solution should find a way so that these "self-comments" aren't taken into account to prevent the merging.

            (Resolving one's own comments is a solution, but then they're more difficult to see by the other team members).

            Pierre-Emmanuel Larrouturou added a comment - That would be very useful. FYI sometimes the PR author adds comments to their own PR, to explain why code was changed in a certain way. Ideally, the solution should find a way so that these "self-comments" aren't taken into account to prevent the merging. (Resolving one's own comments is a solution, but then they're more difficult to see by the other team members).
            Dave Parrish [Atlassian] made changes -
            Status Original: Gathering Interest [ 11772 ] New: Under Consideration [ 11774 ]
            Dave Parrish [Atlassian] made changes -
            Assignee New: Dave Parrish [Atlassian] [ dparrish ]

            Jörn Dyherrn added a comment -

            In relation with https://jira.atlassian.com/browse/BCLOUD-22615 this would simplify our manual merge checks

            Jörn Dyherrn added a comment - In relation with https://jira.atlassian.com/browse/BCLOUD-22615 this would simplify our manual merge checks

            Jörn Dyherrn added a comment -

            This feature would be super useful for us. For now we have to check each comment manually in order to ensure no unresolved comments remain.

            Jörn Dyherrn added a comment - This feature would be super useful for us. For now we have to check each comment manually in order to ensure no unresolved comments remain.
            Dave Parrish [Atlassian] made changes -
            Component/s Original: Pull Request - Merge [ 25323 ]
            Component/s Original: Pull Request - Comments [ 21590 ]
            Component/s New: Pull Request - Comments [ 60915 ]
            Key Original: BSERV-14009 New: BCLOUD-22614
            Project Original: Bitbucket Server [ 13310 ] New: Bitbucket Cloud [ 20310 ]

            Reuben added a comment -

            Could this ticket please be moved to the BCLOUD project?

            Reuben added a comment - Could this ticket please be moved to the BCLOUD project?

              dparrish Dave Parrish [Atlassian]
              59c73aa219df Reuben
              Votes:
              60 Vote for this issue
              Watchers:
              29 Start watching this issue

                Created:
                Updated: