Uploaded image for project: 'Bamboo Data Center'
  1. Bamboo Data Center
  2. BAM-8457

Bamboo should not report build failure if there are only skipped tests (no successful tests)

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Low Low
    • 3.2 M3, 3.2
    • 3.0.1
    • None
    • None

      UI reports:

      No failed tests found, a possible compilation error occurred.

      06-Apr-2011 07:51:23 	BUILD SUCCESSFUL
      06-Apr-2011 07:51:23 	Total time: 20.24 seconds
      06-Apr-2011 07:51:23 	Build process for 'CLI integration test - Confluece CLI - itest' returned with return code = 0
      06-Apr-2011 07:51:23 	Parsing test results...
      06-Apr-2011 07:51:23 	Failing build since test cases were expected but none were found.
      

      However, there were test results even though none were successful. Since there were none failed, Bamboo should NOT fail the build.

      <testsuite time='19.066' failures='0' errors='0' skipped='1' tests='1' name='confluencecli'>
      

            [BAM-8457] Bamboo should not report build failure if there are only skipped tests (no successful tests)

            I agree with the part about Bamboo reporting on skipped tests. This JUnit XML format has been around for a long time, and ignoring this part of the test results leaves the JUnit and TestNG crowd in a strange place.

            James Snyder added a comment - I agree with the part about Bamboo reporting on skipped tests. This JUnit XML format has been around for a long time, and ignoring this part of the test results leaves the JUnit and TestNG crowd in a strange place.

            Bob Swift added a comment -

            Yes, I understand the check box . I expect it to report failure when test results are to be produced and no results are found, or results are found and they indicate test failures. In this case, test results were found and they indicated NO failures, therefore that is SUCCESS. Really, it's just a minor point and fringe case. Bamboo is just taking too much control out of the hands of the script. Skipped tests are not failures. If the test script writer wants it to be a failure, they can do so. From an integration test perspective, skipped tests usually relates to some external service not being available or platform specific exclusions. In fact, it would be nice if Bamboo reported on skipped tests.

            Bob Swift added a comment - Yes, I understand the check box . I expect it to report failure when test results are to be produced and no results are found , or results are found and they indicate test failures . In this case, test results were found and they indicated NO failures, therefore that is SUCCESS. Really, it's just a minor point and fringe case. Bamboo is just taking too much control out of the hands of the script. Skipped tests are not failures. If the test script writer wants it to be a failure, they can do so. From an integration test perspective, skipped tests usually relates to some external service not being available or platform specific exclusions. In fact, it would be nice if Bamboo reported on skipped tests.

            MarkC added a comment -

            Bob,

            I assume you know that if you don't check the checkbox on the builder for parsing tests then the build won't fail? The logic here is that if you expect to find the tests and your build doesn't produce any tests (e.g. you accidentally configured your build to skip all the tests) the build should fail to tell you that it's not testing anything.

            Is it sufficient to uncheck that check box? Or is there a case where sometimes there are tests and sometimes they are skipped and you want them both to pass?

            Cheers,

            Mark C

            MarkC added a comment - Bob, I assume you know that if you don't check the checkbox on the builder for parsing tests then the build won't fail? The logic here is that if you expect to find the tests and your build doesn't produce any tests (e.g. you accidentally configured your build to skip all the tests) the build should fail to tell you that it's not testing anything. Is it sufficient to uncheck that check box? Or is there a case where sometimes there are tests and sometimes they are skipped and you want them both to pass? Cheers, Mark C

              pstefaniak PiotrA
              bob.swift@charter.net Bob Swift
              Affected customers:
              1 This affects my team
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: