Uploaded image for project: 'Bamboo Data Center'
  1. Bamboo Data Center
  2. BAM-3503

Dead elastic agent screen should only show relevante build history and nothing else

    • Icon: Suggestion Suggestion
    • Resolution: Fixed
    • 2.2 M5
    • None
    • None
    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      1. agent history mockup.jpg
        agent history mockup.jpg
        112 kB
      2. sagentinfo.jpg
        sagentinfo.jpg
        29 kB
      3. screenshot-1.jpg
        screenshot-1.jpg
        62 kB

          [BAM-3503] Dead elastic agent screen should only show relevante build history and nothing else

          Again some time was needed after Brydie's review.

          Lucas Guminski [Atlassian] added a comment - Again some time was needed after Brydie's review.

          bmccoy added a comment -

          Hi Lucas,

          A fix is required for both the admin view and non-admin view.

          Users can view dead agents via the link on the build results page (and other locations) and we want the content for the two to look the same. In terms of the listing of dead agents, try the following logic:
          If the user has admin rights the link will take them to the admin view of the agent.
          If the user doesn't have admin rights, the link will take them to a non-admin view which will not include the breadcrumb to provide the list.

          Cheers,
          Brydie

          bmccoy added a comment - Hi Lucas, A fix is required for both the admin view and non-admin view. Users can view dead agents via the link on the build results page (and other locations) and we want the content for the two to look the same. In terms of the listing of dead agents, try the following logic: If the user has admin rights the link will take them to the admin view of the agent. If the user doesn't have admin rights, the link will take them to a non-admin view which will not include the breadcrumb to provide the list. Cheers, Brydie

          Now, when an elastic agent is dead the ViewAgentAdmin action redirects to the new page which conforms to Brydie's design.

          There is no such redirection for the ViewAgent action because there is no listing of dead elastic agents we could redirect to. Moreover ViewAgent action already presents recent activity of the agent.

          Lucas Guminski [Atlassian] added a comment - - edited Now, when an elastic agent is dead the ViewAgentAdmin action redirects to the new page which conforms to Brydie's design. There is no such redirection for the ViewAgent action because there is no listing of dead elastic agents we could redirect to. Moreover ViewAgent action already presents recent activity of the agent.

          it turned that what I did was beyond the scope. I need to reopen this ticket and finish.

          Lucas Guminski [Atlassian] added a comment - it turned that what I did was beyond the scope. I need to reopen this ticket and finish.

          bmccoy added a comment - - edited

          Hi Lucas,

          This issue was not actually clearly defined. What we want to do is change the page you go to when clicking on an old elastic agent (from throughout Bamboo as well as from the main view agent history page). Essentially most of the information on the regular view agents page is irrelevant when viewing agent history, we mostly just want the build history as well as the information you have added above. Clicking on online elastic agents the behaviour will be the same as it is currently.

          So what we need is a brand new Elastic Agent History page. I have drawn a quick mockup as a guideline of what we are thinking. (numbered points relate to numbers in the screen shot).
          1. This page doesn't follow the normal view agent pattern
          2. Blurb to highlight the fact that this is historical information only and this is not a regular agent
          3. All these details can be the same as what you added above, status field is not necessary - they will always be offline
          4. The table of build results contains the same information as the table of build results on the regular view agents page, except you will be able to see ALL builds (normal agents only show e.g last 20).
          5. Because we are showing all builds it may be necessary to paginate them so the page doesn't take to long to load.

          Not in the mockup :- we also probably want a way to delete this agent history from this page if your and admin, you can not edit an offline elastic agent so this functionality/link is not necessary

          Cheers,
          Brydie

          bmccoy added a comment - - edited Hi Lucas, This issue was not actually clearly defined. What we want to do is change the page you go to when clicking on an old elastic agent (from throughout Bamboo as well as from the main view agent history page). Essentially most of the information on the regular view agents page is irrelevant when viewing agent history, we mostly just want the build history as well as the information you have added above. Clicking on online elastic agents the behaviour will be the same as it is currently. So what we need is a brand new Elastic Agent History page. I have drawn a quick mockup as a guideline of what we are thinking. (numbered points relate to numbers in the screen shot). 1. This page doesn't follow the normal view agent pattern 2. Blurb to highlight the fact that this is historical information only and this is not a regular agent 3. All these details can be the same as what you added above, status field is not necessary - they will always be offline 4. The table of build results contains the same information as the table of build results on the regular view agents page, except you will be able to see ALL builds (normal agents only show e.g last 20). 5. Because we are showing all builds it may be necessary to paginate them so the page doesn't take to long to load. Not in the mockup :- we also probably want a way to delete this agent history from this page if your and admin, you can not edit an offline elastic agent so this functionality/link is not necessary Cheers, Brydie

          I have ajaxed agent details so that it refreshes agent status every 10sec. This is the information I am currently displaying (for a dead agent).

          Lucas Guminski [Atlassian] added a comment - I have ajaxed agent details so that it refreshes agent status every 10sec. This is the information I am currently displaying (for a dead agent).

          MarkC added a comment -

          It should show any useful details we have of it. Like uptime, instance Id etc.

          MarkC added a comment - It should show any useful details we have of it. Like uptime, instance Id etc.

            Unassigned Unassigned
            Anonymous Anonymous
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 6h Original Estimate - 6h
                6h
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 12h
                12h