Uploaded image for project: 'Bamboo Data Center'
  1. Bamboo Data Center
  2. BAM-20138

Disabling the "master" plan does not prevent branch detection or branch triggering

    • Icon: Suggestion Suggestion
    • Resolution: Unresolved
    • None
    • Plan Branches
    • None
    • 2
    • 10
    • Our product teams collect and evaluate feedback from a number of different sources. To learn more about how we use customer feedback in the planning process, check out our new feature policy.

      Problem Definition

      Disabling the "master" plan does not prevent branch detection or branch triggering, this is by design.

      Suggested Solution

      Provide an additional mechanism to completely disable the master plan, plan branch detection and all plan branch execution.
      Ensure the UI clearly articulates the differences between both modes of disable.

      Workaround

      1. Disable the master plan
      2. Disable automatic plan branch creation at Plan Configuration >> Branches >> Create plan branch (set to "Manually)
      3. Disable automatic plan branch deletion at Plan Configuration >> Branches >> Delete plan branch
        • Uncheck "After branch was deleted from repository"
        • Uncheck "After branch inactivity in repository"
      4. Disable the trigger at Plan Configurations >> Trigger (assuming the plan branches are inheriting their trigger configuration from the main plan)

            [BAM-20138] Disabling the "master" plan does not prevent branch detection or branch triggering

            David Ball added a comment -

            Right now it could take quite a lot of clicks to disable every action related to a plan and all its branches, including branch creation triggers, plan execution triggers, manual runs, and anything else. It would then take an equivalent number of clicks (maybe more) to put things back to how they were later (should I need to do that).

            Having a new single-click option would be a time-saver for me and less error prone.

             

            David Ball added a comment - Right now it could take quite a lot of clicks to disable every action related to a plan and all its branches, including branch creation triggers, plan execution triggers, manual runs, and anything else. It would then take an equivalent number of clicks (maybe more) to put things back to how they were later (should I need to do that). Having a new single-click option would be a time-saver for me and less error prone.  

            I agree with @Paul Smith.

            I just ran into this today. I disabled the plan because a software license that is needed for the build to succeed has lapsed. So we want to temporarily stop running this plan for PR branches. Yet, disabling the plan does not stop it from running when PRs are created.

            Michael Nicholson added a comment - I agree with @Paul Smith. I just ran into this today. I disabled the plan because a software license that is needed for the build to succeed has lapsed. So we want to temporarily stop running this plan for PR branches. Yet, disabling the plan does not stop it from running when PRs are created.

            Paul Smith added a comment -

            The entire idea of treating the "master" branch, or any other Git branch, specially in this way is a fundamental design mistake in Bamboo.  Every plan should have an individual plan branch for every branch, including the "master"/"main" branch, and all of them should be treated identically by bamboo: show up as plan branches in the branch list for the plan configuration, be individually manageable, etc.

            The only thing that should mark the "master"/"main" branch as special is that the plan could create that initial plan branch automatically when the plan itself is created (or not, either way works fine for me).

            Paul Smith added a comment - The entire idea of treating the "master" branch, or any other Git branch, specially in this way is a fundamental design mistake in Bamboo.  Every plan should have an individual plan branch for every branch, including the "master"/"main" branch, and all of them should be treated identically by bamboo: show up as plan branches in the branch list for the plan configuration, be individually manageable, etc. The only thing that should mark the "master"/"main" branch as special is that the plan could create that initial plan branch automatically when the plan itself is created (or not, either way works fine for me).

            There are some scenarios which we only want branch plans to be executed while keeping the master plan disabled.

            E.g.

             

            However, I feel there should be separate options to

            • Disable Plan - disable the plan and branch plan completely
            • Master Enabled - disable only the master (similar to Branch enabled in the Branch details)

             

             

             

            Hua Soon SIM [Akeles] added a comment - There are some scenarios which we only want branch plans to be executed while keeping the master plan disabled. E.g. https://community.atlassian.com/t5/Bamboo-questions/can-i-configure-bamboo-plan-branching-to-exclude-running-a-job/qaq-p/12569 builds to be limited only the QA branch but not master branch   However, I feel there should be separate options to Disable Plan - disable the plan and branch plan completely Master Enabled - disable only the master (similar to Branch enabled in the Branch details )      

              Unassigned Unassigned
              jowen@atlassian.com Jeremy Owen
              Votes:
              12 Vote for this issue
              Watchers:
              12 Start watching this issue

                Created:
                Updated: