Bamboo should support the use of TLS - SNI

Description

When creating AppLinks between Bamboo and another Atlassian application going through a proxy set up with SNI, the AppLinks won't work properly.

This issue is caused by the commons-httpclient version (3.0.1) used by Bamboo, which does not have support for TLS - SNI.

Environment

Java version 1.7 or newer (starting from the java version 1.7 TLS 1.1 and 1.2 are disabled by default).

Expected results

The AppLink can be successfully created.

Actual results

It is not possible to successfully create an AppLink and the following stack trace can be found in the atlassian-bamboo.log

2015-09-01 17:02:29,222 ERROR [http-bio-8085-exec-11] [CreateApplicationLinkUIResource] ManifestNotFoundException thrown while retrieving manifest
com.atlassian.applinks.spi.manifest.ManifestNotFoundException: javax.net.ssl.SSLHandshakeException: No appropriate protocol (protocol is disabled or cipher suites are inappropriate)
    at com.atlassian.applinks.core.manifest.AppLinksManifestDownloader.download1(AppLinksManifestDownloader.java:201)
    at com.atlassian.applinks.core.manifest.AppLinksManifestDownloader.access$000(AppLinksManifestDownloader.java:44)
    at com.atlassian.applinks.core.manifest.AppLinksManifestDownloader$1$1.<init>(AppLinksManifestDownloader.java:86)
    at com.atlassian.applinks.core.manifest.AppLinksManifestDownloader$1.apply(AppLinksManifestDownloader.java:79)
    at com.atlassian.applinks.core.manifest.AppLinksManifestDownloader$1.apply(AppLinksManifestDownloader.java:76)
    at com.google.common.collect.ComputingConcurrentHashMap$ComputingValueReference.compute(ComputingConcurrentHashMap.java:355)
    at com.google.common.collect.ComputingConcurrentHashMap$ComputingSegment.compute(ComputingConcurrentHashMap.java:184)
...
...

Notes

Workarounds

The following workaround options are alternatives, please choose the best one for your case.

Workaround - option #1
Use a newer commons-httpclient jar version (you need at least version 3.1-atlassian-2) by following these steps:

1. # Shutdown Bamboo
2. Download this commons-httpclient-3.1-atlassian-2.jar into the machine hosting Bamboo
3. Backup and delete /opt/atlassian/bamboo/atlassian-bamboo/WEB-INF/lib/commons-httpclient-3.0.1.jar
4. Move the file commons-httpclient-3.1-atlassian-2.jar into the directory /opt/atlassian/bamboo/atlassian-bamboo/WEB-INF/lib
5. Restart Bamboo

Workaround - option #2
Add the following Java properties to the Bamboo Java properties:

-Dhttps.protocols=TLSv1.1,TLSv1.2

Workaround - option #3
Connect the Atlassian applications bypassing the proxy.

You can find the instructions describing the changes required to your environment, and how to recreate the AppLinks bypassing the proxy here:
How to create an unproxied Application Link