• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Low Low
    • None
    • 5.9.1
    • None

      Problem:

      Plan branches are added for disabled plans

      Steps to Reproduce:

      1. Configure Bamboo to use a linked repository to Stash
      2. In Stash, pull requests to require 1 approver and 1 successful build
      3. Create a build plan in which the option "Automatically manage branches" is checked
      4. Clone this build plan
      5. Disable the cloned build plan.
      6. Make a commit on a new branch

      Both build plans get branch plans created for them, even the disabled on. The build on the disabled plan fails. Stash then sees both a passing build in the original plan and a failed build in the disabled cloned plan. Now Stash will not let the merge go process as it sees the failed build in the disabled plan as not meeting the requirement to allow the pull request to be merged as Stash seems to require a passing build in all plans where the branch build might occur.

      Expected Behavior:

      The desired behavior is that if the overall plan is disabled, it should not allow automatic branch plans to obtain the branch unless manually added.

      Workaround:

      Disable all the individual branch plans or delete the disabled plan.

          Form Name

            [BAM-16094] Branches still added when plan is disabled

            What version of Bamboo was this fixed in?  I just hit this problem in v7.0.6 today. Most developers and admins would expect disabling a plan to disable automatic branch creation too.  It's annoying because our Bitbucket policy prevents merging code with failed builds, and BitBucket won't disregard the build result for a queued build that was manually cancelled. Now I have to wait 1h for a silly duplicated build to pass in an automatically created branch in a disabled plan!

            Greg Niestrawski added a comment - What version of Bamboo was this fixed in?  I just hit this problem in v7.0.6 today. Most developers and admins would expect disabling a plan to disable automatic branch creation too.  It's annoying because our Bitbucket policy prevents merging code with failed builds, and BitBucket won't disregard the build result for a queued build that was manually cancelled. Now I have to wait 1h for a silly duplicated build to pass in an automatically created branch in a disabled plan!

            If this is not a bug but intended behaviour then the intended behaviour is wrong here.

            Right now I have disabled plans that keep polling a (not existing anymore) repository:

            • the plan is disabled
            • all triggers have been deleted
            • all branches are disabled too
            • the branch configuration is set to "Do not create plan branches"

            But still the error logs are filling up with entries that the plan tries to poll the deleted repository for changes.
            I do not want to delete the plan, it should just stop polling for changes.

            This is polluting the error log and is very annoying and this behaviour should be changed.

            karelbemelmansnordcloud added a comment - If this is not a bug but intended behaviour then the intended behaviour is wrong here. Right now I have disabled plans that keep polling a (not existing anymore) repository: the plan is disabled all triggers have been deleted all branches are disabled too the branch configuration is set to "Do not create plan branches" But still the error logs are filling up with entries that the plan tries to poll the deleted repository for changes. I do not want to delete the plan, it should just stop polling for changes. This is polluting the error log and is very annoying and this behaviour should be changed.

            This behaviour is intended.

            Przemek Bruski added a comment - This behaviour is intended.

            WestonM added a comment -

            I just found this out today! I was a bit upset to see hundreds of active plan branches, which are ENABLED too even if the parent plan is disabled.

            I also can't bulk edit (disable) plan branches.

            WestonM added a comment - I just found this out today! I was a bit upset to see hundreds of active plan branches, which are ENABLED too even if the parent plan is disabled. I also can't bulk edit (disable) plan branches.

              Unassigned Unassigned
              jgiles@atlassian.com James Giles IV (Inactive)
              Affected customers:
              2 This affects my team
              Watchers:
              7 Start watching this issue

                Created:
                Updated:
                Resolved: