Uploaded image for project: 'Bamboo Data Center'
  1. Bamboo Data Center
  2. BAM-12979

Test file date check not forgiving enough

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Cannot Reproduce
    • Icon: Low Low
    • None
    • 6.1.1, 6.4.1
    • Tests

      Summary

      calling file.lastUpdated() on my machine provides you with a time stamp to the nearest second (and seems to always round down). This means that if your build is really fast, the files look like they were updated before the tasks started and therefore Bamboo will not parse them for tests.

      There are also file systems which only store the lastUpdated timestamps to the nearest 2 second.

      We should probably provide some sort of leniency here.

      Solution

      Bamboo uses system property bamboo.fs.timestamp.precision to define FS timestamp resolution. By default it is set to 100 (ms), please set it to higher value in order to make file date check less strict. Bamboo does the check in the following way:

      private boolean isFileRecentEnough(final File file)
{
  return file.lastModified() >= (taskStartDate.getTime() - SystemProperty.FS_TIMESTAMP_RESOLUTION_MS.getTypedValue());
}

            [BAM-12979] Test file date check not forgiving enough

            Conny Postma made changes -
            Remote Link Original: This issue links to "Page (Atlassian Documentation)" [ 104673 ]
            Giovanna Fragoso made changes -
            Assignee New: Giovanna Fragoso [ a3e6629b6e9d ]
            Monique Khairuliana (Inactive) made changes -
            Workflow Original: Bamboo Workflow 2016 v1 - Restricted [ 1443747 ] New: JAC Bug Workflow v3 [ 3386032 ]
            Status Original: Resolved [ 5 ] New: Closed [ 6 ]
            Pawel Skierczynski made changes -
            Resolution New: Cannot Reproduce [ 5 ]
            Status Original: Needs Triage [ 10030 ] New: Resolved [ 5 ]
            Bugfix Automation Bot made changes -
            Support reference count New: 3
            Oleksandr Tkachenko made changes -
            Affects Version/s New: 6.4.1 [ 78590 ]
            Affects Version/s New: 6.1.1 [ 73029 ]
            Oleksandr Tkachenko made changes -
            Fix Version/s Original: 5.10.1.1 [ 61404 ]
            Oleksandr Tkachenko made changes -
            Resolution Original: Done [ 17 ]
            Status Original: Resolved [ 5 ] New: Needs Triage [ 10030 ]
            Owen made changes -
            Symptom Severity Original: Minor [ 14432 ] New: Severity 3 - Minor [ 15832 ]
            Krystian Brazulewicz made changes -
            Link New: This issue is duplicated by BAM-16324 [ BAM-16324 ]

              a3e6629b6e9d Giovanna Fragoso
              bmccoy bmccoy
              Affected customers:
              28 This affects my team
              Watchers:
              29 Start watching this issue

                Created:
                Updated:
                Resolved: