|
[
Permlink
| « Hide
]
=Neal Applebaum added a comment - 05/Dec/05 05:28 PM
or footer or operations... it works entirely differently in 3.3.3
On version 3.4.2 (j.a.com) it doesn't seem to do much of anything...
Quite a curiious problem. Seems to only be a problem for the QuickLinkServlet that is, all the links under /browse/. and only on *Orion. It also works fine under Tomcat. For some reason the decorator value simply gets ignored. Will investigate further
It appears the Orion, somehow or rather, strips the request parameters from the request after the rest of the filter chain has ran.
In the sitemesh filter {[PageFilter}} the method below is ran. protected Page parsePage(HttpServletRequest request, HttpServletResponse response, FilterChain chain) throws IOException, ServletException { ... PageResponseWrapper pageResponse = new PageResponseWrapper(response, factory); chain.doFilter(request, pageResponse); // check if another servlet or filter put a page object to the request Page result = (Page)request.getAttribute(PAGE); ... Before the chain.doFilter call, request.getParameter("decorator") returns the correct value (printable). After the doFilter chain, request.getParameter returns null and indeed, the request contains no parameters. The request object passed to the QuickLinkServlet contains all the parameters passed, including the decorator property, which is why the printable view appears to do nothing. However, if you actually print the page, then toolbar and the likes disappear in any case. A strange problem, however... The problem seems ot be Orion specific.
This should be fixed in 3.7 by making the top-right printable link link to the printable view of an issue.
I can confirm that on 3.7 and Orion 2.0.2, this is fixed.
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Resolved
Trivial
On Orion the printable decorator of an issue does not remove the toolbar
