Issue Details (XML | Word | Printable)

Key: JRA-7291
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Dylan Etkin [Atlassian]
Reporter: Mike Hardy
Votes: 0
Watchers: 0
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
JIRA

Jira thumbnailing code mishandles attachments with errors

Created: 11/Jul/05 07:05 PM   Updated: 30/Jul/06 07:35 PM
Component/s: Web interface
Affects Version/s: 3.2.2
Fix Version/s: 3.3 Beta1

Time Tracking:
Not Specified

File Attachments: 1. JPEG File GiftCard_Error.jpg (2.25 MB)


Participants: Dylan Etkin [Atlassian] and Mike Hardy
Since last comment: 3 years, 20 weeks, 4 days ago
Resolution Date: 14/Jul/05 12:33 AM
Labels:


 Description  « Hide
Reproduction:
1) Create a new issue
2) Get a bitmap file (.bmp), and rename it test.jpg (yes, I know this qualifies as silly)
3) Attach the now silly image to your new issue from #1
4) witness the log file explode with stack traces, and see the broken thumbnails on the issue

I'm not asking you guys to invent smarter users, we're working on them over here, but the thumbnailing code should handle this error more gracefully as it is user input and the principle of the internet is to "be liberal in what accept".

You should expect users to upload all manner of mislabeled or non-conforming junk, and not error out because of it. It might be a valid attachment, and you're just inferring too much from the name



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Mike Hardy added a comment - 11/Jul/05 07:07 PM
I've attached an example bitmap file with a silly name, it should break the thumbnail code

Dylan Etkin [Atlassian] added a comment - 14/Jul/05 12:33 AM
This has been fixed by checking if the bytes really resolve to a supported image type.

Mike Hardy added a comment - 14/Jul/05 12:40 AM
Excellent - I figured it was going to be relatively easy or I wouldn't have pestered, given the willfull ignorance involved in creating the situation. I can't be the only jira admin with this problem though, so this should help