[#JRA-6964] Integrity Checker - SearchRequest Does Not Check FilterSubscription

JIRA

Integrity Checker - SearchRequest Does Not Check FilterSubscription

Created: 09/Jun/05 06:57 PM Updated: 23/Oct/05 07:27 PM

Component/s:

None

Affects Version/s:

3.1.1

Fix Version/s:

3.4

Time Tracking:

Not Specified

Environment:

Linux, Resin 3.0.12 Pro, Java 1.4.2_07

Participants:	Anton Mazkovoi [Atlassian], Dylan Etkin [Atlassian] and Matthew E. Porter
Since last comment:	2 years, 49 weeks, 6 days ago
Resolution Date:	23/Oct/05 07:27 PM
Labels:

Description

« Hide

The integrity checker utility does not check the filterId field (SearchRequest) of FilterSubscription.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Anton Mazkovoi [Atlassian] added a comment - 09/Jun/05 07:12 PM

Sorry, do you mean that there is no Integrity Check to find all orphan subscriptions?

[ Permlink | « Hide ]

Matthew E. Porter added a comment - 09/Jun/05 08:04 PM

In the case where we found this (jira.codehaus.org), the filtersubcription table had a filterid value that did not exist in searchrequest. This produced the following exception -

2005-06-09 16:32:09.864329500 java.lang.RuntimeException: Null list of issues for subscription [GenericEntity:FilterSubscription][group,null][lastRun,2005-06-07 15:38:47.081][username,daggerrz][emailOnEmpty,false][id,10220][filterID,10850], user daggerrz
2005-06-09 16:32:09.864337500 at com.atlassian.jira.mail.SubscriptionMailQueueItem.sendSearchRequestEmail(SubscriptionMailQueueItem.java:89)
2005-06-09 16:32:09.864340500 at com.atlassian.jira.mail.SubscriptionMailQueueItem.send(SubscriptionMailQueueItem.java:69)
2005-06-09 16:32:09.864344500 at com.atlassian.mail.queue.MailQueueImpl.sendBuffer(MailQueueImpl.java:55)
2005-06-09 16:32:09.864412500 at com.atlassian.jira.service.services.mail.MailQueueService.run(MailQueueService.java:23)
2005-06-09 16:32:09.864415500 at com.atlassian.jira.service.JiraServiceContainer.run(JiraServiceContainer.java:53)
2005-06-09 16:32:09.864419500 at com.atlassian.jira.service.ServiceRunner.execute(ServiceRunner.java:50)
2005-06-09 16:32:09.864422500 at org.quartz.core.JobRunShell.run(JobRunShell.java:147)
2005-06-09 16:32:09.864445500 at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:387)
2005-06-09 16:32:09.864449500 2005-06-09 16:32:09,844 ERROR [atlassian.jira.mail.SubscriptionMailQueueItem] Null list of issues for subscription [GenericEntity:FilterSubscription][group,null][lastRun,2005-06-07 15:38:47.081][username,daggerrz][emailOnEmpty,false][id,10220][filterID,10850], user daggerrz
2005-06-09 16:32:09.864485500 java.lang.RuntimeException: Null list of issues for subscription [GenericEntity:FilterSubscription][group,null][lastRun,2005-06-07 15:38:47.081][username,daggerrz][emailOnEmpty,false][id,10220][filterID,10850], user daggerrz
2005-06-09 16:32:09.864510500 at com.atlassian.jira.mail.SubscriptionMailQueueItem.sendSearchRequestEmail(SubscriptionMailQueueItem.java:89)
2005-06-09 16:32:09.864514500 at com.atlassian.jira.mail.SubscriptionMailQueueItem.send(SubscriptionMailQueueItem.java:69)
2005-06-09 16:32:09.864517500 at com.atlassian.mail.queue.MailQueueImpl.sendBuffer(MailQueueImpl.java:55)
2005-06-09 16:32:09.864541500 at com.atlassian.jira.service.services.mail.MailQueueService.run(MailQueueService.java:23)
2005-06-09 16:32:09.864545500 at com.atlassian.jira.service.JiraServiceContainer.run(JiraServiceContainer.java:53)
2005-06-09 16:32:09.864548500 at com.atlassian.jira.service.ServiceRunner.execute(ServiceRunner.java:50)
2005-06-09 16:32:09.864551500 at org.quartz.core.JobRunShell.run(JobRunShell.java:147)
2005-06-09 16:32:09.864574500 at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:387)

[ Show » ]

Matthew E. Porter added a comment - 09/Jun/05 08:04 PM In the case where we found this (jira.codehaus.org), the filtersubcription table had a filterid value that did not exist in searchrequest. This produced the following exception - 2005-06-09 16:32:09.864329500 java.lang.RuntimeException: Null list of issues for subscription [GenericEntity:FilterSubscription][group,null][lastRun,2005-06-07 15:38:47.081][username,daggerrz][emailOnEmpty,false][id,10220][filterID,10850], user daggerrz 2005-06-09 16:32:09.864337500 at com.atlassian.jira.mail.SubscriptionMailQueueItem.sendSearchRequestEmail(SubscriptionMailQueueItem.java:89) 2005-06-09 16:32:09.864340500 at com.atlassian.jira.mail.SubscriptionMailQueueItem.send(SubscriptionMailQueueItem.java:69) 2005-06-09 16:32:09.864344500 at com.atlassian.mail.queue.MailQueueImpl.sendBuffer(MailQueueImpl.java:55) 2005-06-09 16:32:09.864412500 at com.atlassian.jira.service.services.mail.MailQueueService.run(MailQueueService.java:23) 2005-06-09 16:32:09.864415500 at com.atlassian.jira.service.JiraServiceContainer.run(JiraServiceContainer.java:53) 2005-06-09 16:32:09.864419500 at com.atlassian.jira.service.ServiceRunner.execute(ServiceRunner.java:50) 2005-06-09 16:32:09.864422500 at org.quartz.core.JobRunShell.run(JobRunShell.java:147) 2005-06-09 16:32:09.864445500 at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:387) 2005-06-09 16:32:09.864449500 2005-06-09 16:32:09,844 ERROR [atlassian.jira.mail.SubscriptionMailQueueItem] Null list of issues for subscription [GenericEntity:FilterSubscription][group,null][lastRun,2005-06-07 15:38:47.081][username,daggerrz][emailOnEmpty,false][id,10220][filterID,10850], user daggerrz 2005-06-09 16:32:09.864485500 java.lang.RuntimeException: Null list of issues for subscription [GenericEntity:FilterSubscription][group,null][lastRun,2005-06-07 15:38:47.081][username,daggerrz][emailOnEmpty,false][id,10220][filterID,10850], user daggerrz 2005-06-09 16:32:09.864510500 at com.atlassian.jira.mail.SubscriptionMailQueueItem.sendSearchRequestEmail(SubscriptionMailQueueItem.java:89) 2005-06-09 16:32:09.864514500 at com.atlassian.jira.mail.SubscriptionMailQueueItem.send(SubscriptionMailQueueItem.java:69) 2005-06-09 16:32:09.864517500 at com.atlassian.mail.queue.MailQueueImpl.sendBuffer(MailQueueImpl.java:55) 2005-06-09 16:32:09.864541500 at com.atlassian.jira.service.services.mail.MailQueueService.run(MailQueueService.java:23) 2005-06-09 16:32:09.864545500 at com.atlassian.jira.service.JiraServiceContainer.run(JiraServiceContainer.java:53) 2005-06-09 16:32:09.864548500 at com.atlassian.jira.service.ServiceRunner.execute(ServiceRunner.java:50) 2005-06-09 16:32:09.864551500 at org.quartz.core.JobRunShell.run(JobRunShell.java:147) 2005-06-09 16:32:09.864574500 at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:387)

[ Permlink | « Hide ]

Anton Mazkovoi [Atlassian] added a comment - 09/Jun/05 08:34 PM

Yep, thanks. We'll see if we can get this into 3.3.

We have fixed a bug in JIAR 3.2 that causes these orphan records to occur. However I am sure there are JIRA instances out there with these problems, so it will be worth while.

Thanks,
Anton

[ Permlink | « Hide ]

Dylan Etkin [Atlassian] added a comment - 23/Oct/05 07:27 PM

I added two integrity checkers around the filter subscriptions. One that will delete the filter subscription if the corresponding saved filter no longer exists and the other deleting the filter subscription if the corresponding quartz trigger does not exist. This should take care of all the orphan filter subscriptions.