Issue Details (XML | Word | Printable)

Key: JRA-6860
Type: Improvement Improvement
Status: Open Open
Priority: Minor Minor
Assignee: Unassigned
Reporter: Willie Doyle
Votes: 2
Watchers: 1
Operations

Add/Edit UI Mockup to this issue
If you were logged in you would be able to see more operations.
JIRA

Change log level of "Revision 1.1.1.1 has no main branch" messages in statcvs jar to debug

Created: 01/Jun/05 05:31 PM   Updated: 15/Oct/06 08:41 AM
Component/s: CVS integration
Affects Version/s: 3.1.1
Fix Version/s: None

Time Tracking:
Not Specified

File Attachments: 1. Text File cvs.log (43 kB)

Environment:
java 1.4
red hat linux
tomcat 5
Issue Links:
Reference
 

Participants: Anton Mazkovoi [Atlassian], Matt Doar, Scott Farquhar [Atlassian] and Willie Doyle
Since last comment: 3 years, 22 weeks, 1 day ago
Labels:


 Description  « Hide
I need to know how to find out what is causing thsi so I can fix it. I am running a few CVS services.

============
14:44:41 - [WARN]net.sf.statcvs.input.Builder.buildRevision(Builder.java:138):


Revision 1.1.1.1 has no main branch - ignoring revision.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Anton Mazkovoi [Atlassian] added a comment - 01/Jun/05 11:37 PM
Hi Willie,

This warning is printed as JIRA does not read revisions that signify the initial import of the module to CVS.
There messages can be safely ignored. Does the CVS integration work as expected?

If you would like these log messages to be supressed please add teh following 2 lines to the WEB-INF/classes/log4j.properties file under the JIRA web application and restart JIRA:
log4j.category.net.sf.statcvs.input = ERROR, console
log4j.additivity.net.sf.statcvs.input = false

I hope this helps. Please let us know if you have any other questions or would like more information. Otherwise please resolve this issue.

Thanks,
Anton


Matt Doar added a comment - 23/Jun/05 05:40 PM
I'm also seeing these errors:

2005-06-23 12:11:53,512 WARN [sf.statcvs.input.Builder] Revision 1.27.2.5 has no main branch - ignoring revision.
2005-06-23 12:11:53,649 WARN [sf.statcvs.input.Builder] Revision 1.27.2.2 has no main branch - ignoring revision.
2005-06-23 12:11:53,649 WARN [sf.statcvs.input.Builder] Revision 1.27.2.1 has no main branch - ignoring revision.
2005-06-23 12:11:53,657 WARN [sf.statcvs.input.Builder] Revision 1.13.2.2 has no main branch - ignoring revision.
2005-06-23 12:11:53,657 WARN [sf.statcvs.input.Builder] Revision 1.13.2.1 has no main branch - ignoring revision.

and from the revision numbers I don't think that this is related to importing files. Looking at the statcvs and Jira source, it could be that Jira is ignoring files that only exist on branches, not on the mainline? If the warning message displayed the filename, it would be easier to track down what is happening (that's a minor request for a future release)

The problem with this message is that it makes people think that there is corruption in their CVS repositories. If it is an expected occurence, then it shouldn't be displayed.

~Matt


Matt Doar added a comment - 23/Jun/05 07:04 PM
I believe I have a small test case for this. I modified the statcvs-patched jar file to display comments, so I could actually
work out which files were causing this (very useful). Then I created a minimal cvs.log file (attached) and when Jira started up, I saw:

2005-06-23 16:53:43,932 WARN [sf.statcvs.input.Builder] Revision 1.27.2.5, comment: fix for bug 1392. use a connection timeout for TCP connection: has no main branch - ignoring revision.
2005-06-23 16:53:43,938 WARN [sf.statcvs.input.Builder] Revision 1.27.2.2, comment: remove modifications made for server IP blocking (bug 1252): has no main branch - ignoring revision.
2005-06-23 16:53:43,939 WARN [sf.statcvs.input.Builder] Revision 1.27.2.1, comment: - fix for bug 1252 ...
: has no main branch - ignoring revision

The source file in question displays fine with ViewCVS, and I can check out each of the mentioned revisions, so I suspect that the modifications made by Atlassian to the statcvs source code may be making some invalid assumptions. I don't think that the attached cvs log should generate any such warnings.

~Matt


Matt Doar added a comment - 23/Jun/05 07:05 PM
Added the minimal test case.

Matt Doar added a comment - 23/Jun/05 07:54 PM
Aha! I withdraw that suspicion of Jira's modifications to statcvs. I was in fact mistaken to say that this file looked ok in ViewCVS. It turned out that someone had messed with the branch numbers in the past (cvs admin is a risky command). So in this case statcvs was correctly noting real problems in oour CVS repository, and the warnings should not be disabled.

In the attached cvs log file, the tag that created the branch

TAG_2_1_1_1_BRANCH: 1.27.0.4

should have been:

TAG_2_1_1_1_BRANCH: 1.27.0.2

(http://durak.org/cvswebsites/doc/cvs_58.php#SEC58 describes the CVS branch numbering scheme)

~Matt


Scott Farquhar [Atlassian] added a comment - 25/Jun/05 03:14 AM
So - can we close this issue?

Willie Doyle added a comment - 27/Jun/05 09:01 AM
Please close. We were able to resolve by modifying the log4j.xml on the server.

Matt Doar added a comment - 30/Jun/05 11:44 AM
Yes, ignoring the 1.1.1.1 warnings seems like the right thing to do. However, other warnings from statcvs are important, since they indicate real problems with the user's repository.

How about having Jira filter out the 1.1.1.1 warnings itself?

~Matt