[#JRA-5320] CVS - Incorrect Branching checks causes parsing failure.

JIRA

CVS - Incorrect Branching checks causes parsing failure.

Created: 23/Nov/04 01:10 AM Updated: 30/Jul/06 07:34 PM

Component/s:

CVS integration

Affects Version/s:

3.0.3

Fix Version/s:

3.1

Time Tracking:

Not Specified

File Attachments:

statcvs-20041123-patched.jar (1.01 MB)

Issue Links:

Reference

This issue is related to:

~~JRA-5548~~ CVS parser breaks with illegal state error

Participants:	Jeff Turner [Atlassian], Keith Brophy and Yuri Gadow
Since last comment:	3 years, 40 weeks, 3 days ago
Resolution Date:	03/Jan/05 09:49 PM
Labels:

Description

« Hide

Incorrect branching checks causes parsing failure:

2004-11-20 16:50:05,006 DEBUG [sf.statcvs.input.FileBuilder] logging my_file
/my_file
2004-11-20 16:32:23,091 ERROR [action.admin.vcs.AddRepository] Error occurred while obtaining cvs log or parsing the cvs log.
java.lang.IllegalStateException: Already have branch data: name='V_0_3_0_PATCH_0_BUILD_11_BRANCH' branchRevision='1.9.0.2' revisonNumber='1.9.2 startRevisionNumber='1.9'
at net.sf.statcvs.input.CvsRevisionParser.setBranchInformation(CvsRevisionParser.java:206)
at net.sf.statcvs.input.CvsRevisionParser.parseRevision(CvsRevisionParser.java:167)

This branch check failure occurs with a branch of a branch - the check to see if the child branch already exists fails as the 'parent' branch already exists.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Keith Brophy added a comment - 23/Nov/04 01:18 AM

Please replace the original statcvs-20040721-patched.jar file with the attached file to resolve this issue.

[ Permlink | « Hide ]

Jeff Turner [Atlassian] added a comment - 20/Dec/04 09:47 PM

Stacktrace from another probable instance of this:

2004-12-09 09:30:10,447 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:11,306 WARN [sf.statcvs.input.Builder] Revision 1.1.2.1 has no
main branch - ignoring revision.
2004-12-09 09:30:11,385 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:11,400 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:11,416 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:11,775 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:11,869 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:14,056 WARN [sf.statcvs.input.Builder] Revision 1.2.8.1 has no
main branch - ignoring revision.
2004-12-09 09:30:14,416 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:16,838 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:16,853 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:16,916 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:19,041 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:20,244 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:20,259 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:20,259 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:20,275 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:20,291 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:20,306 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:20,353 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:20,353 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:20,353 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no
main branch - ignoring revision.
2004-12-09 09:30:22,541 WARN [sf.statcvs.input.FileBuilder] illegal state in Wha
tToDoForAVersionChange.txt:1.1
2004-12-09 09:30:22,541 ERROR [action.admin.vcs.AddRepository] Error occurred wh
ile obtaining cvs log or parsing the cvs log.
java.lang.NullPointerException
at net.sf.statcvs.input.FileBuilder.createFile(FileBuilder.java:193)
at net.sf.statcvs.input.Builder.createCvsContent(Builder.java:163)
at com.atlassian.jira.vcs.cvsimpl.CvsRepositoryUtilImpl.parseCvsLogs(Cvs
RepositoryUtilImpl.java:154)
at com.atlassian.jira.web.action.admin.vcs.RepositoryActionSupport.testR
epository(RepositoryActionSupport.java:285)
at com.atlassian.jira.web.action.admin.vcs.RepositoryActionSupport.check
Repository(RepositoryActionSupport.java:224)
at com.atlassian.jira.web.action.admin.vcs.RepositoryActionSupport.check
PathsAndRepository(RepositoryActionSupport.java:336)
at com.atlassian.jira.web.action.admin.vcs.RepositoryActionSupport.valid
ateRepositoryParameters(RepositoryActionSupport.java:309)
at com.atlassian.jira.web.action.admin.vcs.AddRepository.doValidation(Ad
dRepository.java:54)
at webwork.action.ActionSupport.validate(ActionSupport.java:371)
at webwork.action.ActionSupport.execute(ActionSupport.java:148)
at com.atlassian.jira.action.JiraActionSupport.execute(JiraActionSupport
.java:46)
at webwork.dispatcher.GenericDispatcher.executeAction(GenericDispatcher.
java:131)
at com.atlassian.jira.web.dispatcher.JiraServletDispatcher.service(JiraS
ervletDispatcher.java:186)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:247)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:193)
at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilt
er.java:142)
at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilte
r.java:58)
at com.atlassian.jira.web.filters.SitemeshExcludePathFilter.doFilter(Sit
emeshExcludePathFilter.java:36)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:213)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:193)
at com.atlassian.seraph.filter.SecurityFilter.doFilter(SecurityFilter.ja
va:168)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:213)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:193)
at com.atlassian.seraph.filter.LoginFilter.doFilter(LoginFilter.java:181
)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:213)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:193)
at com.atlassian.util.profiling.filters.ProfilingFilter.doFilter(Profili
ngFilter.java:132)
at com.atlassian.jira.web.filters.ProfilingAndErrorFilter.doFilter(Profi
lingAndErrorFilter.java:25)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:213)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:193)
at com.atlassian.jira.web.filters.ActionCleanupDelayFilter.doFilter(Acti
onCleanupDelayFilter.java:37)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:213)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:193)
at com.atlassian.johnson.filters.JohnsonFilter.doFilter(JohnsonFilter.ja
va:91)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:213)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:193)
at com.atlassian.jira.web.filters.gzip.GzipFilter.doFilter(GzipFilter.ja
va:72)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:213)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:193)
at com.atlassian.core.filters.AbstractEncodingFilter.doFilter(AbstractEn
codingFilter.java:36)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl
icationFilterChain.java:213)
at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF
ilterChain.java:193)
at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV
alve.java:256)
at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContex
t.invokeNext(StandardPipeline.java:643)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.jav
a:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)

at org.apache.catalina.core.StandardContextValve.invoke(StandardContextV
alve.java:191)
at org.apache.catalina.core.StandardPipe line$StandardPipelineValveContex
t.invokeNext(StandardPipeline.java:643)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.jav
a:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)

at org.apache.catalina.core.StandardContext.invoke(StandardContext.java:
2417)
at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.j
ava:180)
at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContex
t.invokeNext(StandardPipeline.java:643)
at org.apache.catalina.valves.ErrorDispatcherValve.invoke(ErrorDispatche
rValve.java:171)
at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContex
t.invokeNext(StandardPipeline.java:641)
at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.j
ava:172)
at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContex
t.invokeNext(StandardPipeline.java:641)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.jav
a:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)

at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineVal
ve.java:174)
at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContex
t.invokeNext(StandardPipeline.java:643)
at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.jav
a:480)
at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995)

at org.apache.coyote.tomcat4.CoyoteAdapter.service(CoyoteAdapter.java:19
3)
at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java
:781)
at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.proce
ssConnection(Http11Protocol.java:549)
at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java
:589)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadP
ool.java:666)
at java.lang.Thread.run(Thread.java:534)

[ Show » ]

Jeff Turner [Atlassian] added a comment - 20/Dec/04 09:47 PM Stacktrace from another probable instance of this: 2004-12-09 09:30:10,447 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:11,306 WARN [sf.statcvs.input.Builder] Revision 1.1.2.1 has no main branch - ignoring revision. 2004-12-09 09:30:11,385 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:11,400 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:11,416 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:11,775 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:11,869 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:14,056 WARN [sf.statcvs.input.Builder] Revision 1.2.8.1 has no main branch - ignoring revision. 2004-12-09 09:30:14,416 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:16,838 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:16,853 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:16,916 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:19,041 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:20,244 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:20,259 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:20,259 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:20,275 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:20,291 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:20,306 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:20,353 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:20,353 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:20,353 WARN [sf.statcvs.input.Builder] Revision 1.1.1.1 has no main branch - ignoring revision. 2004-12-09 09:30:22,541 WARN [sf.statcvs.input.FileBuilder] illegal state in Wha tToDoForAVersionChange.txt:1.1 2004-12-09 09:30:22,541 ERROR [action.admin.vcs.AddRepository] Error occurred wh ile obtaining cvs log or parsing the cvs log. java.lang.NullPointerException at net.sf.statcvs.input.FileBuilder.createFile(FileBuilder.java:193) at net.sf.statcvs.input.Builder.createCvsContent(Builder.java:163) at com.atlassian.jira.vcs.cvsimpl.CvsRepositoryUtilImpl.parseCvsLogs(Cvs RepositoryUtilImpl.java:154) at com.atlassian.jira.web.action.admin.vcs.RepositoryActionSupport.testR epository(RepositoryActionSupport.java:285) at com.atlassian.jira.web.action.admin.vcs.RepositoryActionSupport.check Repository(RepositoryActionSupport.java:224) at com.atlassian.jira.web.action.admin.vcs.RepositoryActionSupport.check PathsAndRepository(RepositoryActionSupport.java:336) at com.atlassian.jira.web.action.admin.vcs.RepositoryActionSupport.valid ateRepositoryParameters(RepositoryActionSupport.java:309) at com.atlassian.jira.web.action.admin.vcs.AddRepository.doValidation(Ad dRepository.java:54) at webwork.action.ActionSupport.validate(ActionSupport.java:371) at webwork.action.ActionSupport.execute(ActionSupport.java:148) at com.atlassian.jira.action.JiraActionSupport.execute(JiraActionSupport .java:46) at webwork.dispatcher.GenericDispatcher.executeAction(GenericDispatcher. java:131) at com.atlassian.jira.web.dispatcher.JiraServletDispatcher.service(JiraS ervletDispatcher.java:186) at javax.servlet.http.HttpServlet.service(HttpServlet.java:853) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:247) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:193) at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilt er.java:142) at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilte r.java:58) at com.atlassian.jira.web.filters.SitemeshExcludePathFilter.doFilter(Sit emeshExcludePathFilter.java:36) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:213) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:193) at com.atlassian.seraph.filter.SecurityFilter.doFilter(SecurityFilter.ja va:168) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:213) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:193) at com.atlassian.seraph.filter.LoginFilter.doFilter(LoginFilter.java:181 ) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:213) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:193) at com.atlassian.util.profiling.filters.ProfilingFilter.doFilter(Profili ngFilter.java:132) at com.atlassian.jira.web.filters.ProfilingAndErrorFilter.doFilter(Profi lingAndErrorFilter.java:25) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:213) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:193) at com.atlassian.jira.web.filters.ActionCleanupDelayFilter.doFilter(Acti onCleanupDelayFilter.java:37) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:213) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:193) at com.atlassian.johnson.filters.JohnsonFilter.doFilter(JohnsonFilter.ja va:91) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:213) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:193) at com.atlassian.jira.web.filters.gzip.GzipFilter.doFilter(GzipFilter.ja va:72) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:213) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:193) at com.atlassian.core.filters.AbstractEncodingFilter.doFilter(AbstractEn codingFilter.java:36) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Appl icationFilterChain.java:213) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationF ilterChain.java:193) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperV alve.java:256) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContex t.invokeNext(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.jav a:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextV alve.java:191) at org.apache.catalina.core.StandardPipe line$StandardPipelineValveContex t.invokeNext(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.jav a:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardContext.invoke(StandardContext.java: 2417) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.j ava:180) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContex t.invokeNext(StandardPipeline.java:643) at org.apache.catalina.valves.ErrorDispatcherValve.invoke(ErrorDispatche rValve.java:171) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContex t.invokeNext(StandardPipeline.java:641) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.j ava:172) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContex t.invokeNext(StandardPipeline.java:641) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.jav a:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineVal ve.java:174) at org.apache.catalina.core.StandardPipeline$StandardPipelineValveContex t.invokeNext(StandardPipeline.java:643) at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.jav a:480) at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:995) at org.apache.coyote.tomcat4.CoyoteAdapter.service(CoyoteAdapter.java:19 3) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java :781) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.proce ssConnection(Http11Protocol.java:549) at org.apache.tomcat.util.net.TcpWorkerThread.runIt(PoolTcpEndpoint.java :589) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadP ool.java:666) at java.lang.Thread.run(Thread.java:534)

[ Permlink | « Hide ]

Yuri Gadow added a comment - 23/Dec/04 11:37 AM

Just an FYI, we had the same problem - dropped in the new JAR above, and everything appears to be at 100% now.

[ Permlink | « Hide ]

Jeff Turner [Atlassian] added a comment - 03/Jan/05 09:51 PM

Although ~~JRA-5548~~ has the same symptom as ~~JRA-5320~~ it is a separate bug, not fixed by the ~~JRA-5320~~ patch.