Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-15405

Catch and quieten ClientAbortException in AbstractViewFileServlet

    XMLWordPrintable

Details

    • Bug
    • Resolution: Won't Fix
    • Low
    • None
    • None
    • Issue - Attachments
    • None

    Description

      Currently if the user aborts a request during an attachment you get a nice big ugly exception:

      008-08-10 14:59:34,917 http-j2ee.jira.atlassian.com%2F127.0.0.101-8080-Processor69 ERROR [jira.web.servlet.ViewAttachmentServlet] Error finding /13343/Comandos+do+DOS+(bat).pdf: null
      ClientAbortException:  java.net.SocketException: Broken pipe
              at org.apache.catalina.connector.OutputBuffer.realWriteBytes(OutputBuffer.java:366)
              at org.apache.tomcat.util.buf.ByteChunk.flushBuffer(ByteChunk.java:432)
              at org.apache.catalina.connector.OutputBuffer.doFlush(OutputBuffer.java:314)
              at org.apache.catalina.connector.OutputBuffer.close(OutputBuffer.java:278)
              at org.apache.catalina.connector.CoyoteOutputStream.close(CoyoteOutputStream.java:104)
              at com.atlassian.jira.web.servlet.AbstractViewFileServlet.doGet(AbstractViewFileServlet.java:70)
              at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
              at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
      ....
      ...
      

      As we have done nothing wrong, we shouldn't spit out these big stack traces. I actually don't see the harm in catching these exceptions and logging out as a WARN or even INFO.

      Attachments

        Activity

          People

            Unassigned Unassigned
            nick.menere Nick Menere [Atlassian] (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: