[#JRA-15189] noformat tag breaks

JIRA

noformat tag breaks

Created: 02/Jul/08 08:56 PM Updated: 14/Jul/08 07:06 PM

Component/s:

UI / Usability

Affects Version/s:

3.12.3

Fix Version/s:

4.0

Time Tracking:

Original Estimate:

Not Specified

Remaining Estimate:

0 minutes

Time Spent:

1 day, 45 minutes

Participants:	Dushan Hanuska [Atlassian], Paul Curren [Atlassian] and Timothy Chin [Atlassian]
Since last comment:	6 weeks, 2 days ago
Labels:

Description

« Hide

The scroll bar is missing from the noformat tag in:

Firefox 3
Safari Version 3.1.2 (5525.20.1)
Safari 4

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Dushan Hanuska [Atlassian] added a comment - 09/Jul/08 09:08 PM

The problem is that PRE tag inside a table (TABLE tag) that has no set width (in pixels) stretches the table beyond the screen width.

Possible solutions:

Replace the TABLE with DIV tags and CSS
- It would need to be done properly so it works across all supported browsers
- It would require lots of testing
Set the max-width style attribute on the PRE tag
- This would be handled by JavaScript on-window-resize handler
- Not be supported by IE6
- Not really a clean solution
- This would require lots of browser testing
It is possible to use white-space: pre-wrap, which would cause the long lines inside PRE to wrap
- This is not really a good solution
- Not supported by all browsers, however more browser specific white-space values are available
- Not really what we want to do as it could make lots of things just look ugly

[ Permlink | « Hide ]

Dushan Hanuska [Atlassian] added a comment - 09/Jul/08 09:13 PM

Nice example of TABLE and PRE styling combinations: http://www.atmaweapon.org/tables.html

[ Permlink | « Hide ]

Dushan Hanuska [Atlassian] added a comment - 09/Jul/08 09:25 PM - edited

If you are affected by this and want to:

use white-space: pre-wrap, add the following in wiki-renderer-css.vm

.preformattedContent pre {
    white-space: pre-wrap;       /* css-3 should we be so lucky... */
    white-space: -moz-pre-wrap;  /* Mozilla, since 1999 */
    white-space: -pre-wrap;      /* Opera 4-6 ?? */
    white-space: -o-pre-wrap;    /* Opera 7 ?? */
    word-wrap: break-word;       /* Internet Explorer 5.5+ */
    _white-space: pre;   /* IE only hack to re-specify in addition to word-wrap  */
}

or set ((max-width}} or width of PRE tags, modify wiki-renderer-css.vm (for example 900px)

.preformatted {
    border: 1px dashed ;
    font-size: 11px;
    font-family: Courier;
    margin: 10px;
    line-height: 13px;
    max-width: 900px;
}

When you are done with your modifications, check that system-renderers-plugin.xml is using this file (wiki-renderer-js.vm) and not its minified version (wiki-renderer-js-min.vm)

<jira-renderer key="atlassian-wiki-renderer" name="Wiki Style Renderer"
    i18n-name-key="admin.renderer.plugin.wiki.renderer.name"
    class="com.atlassian.jira.issue.fields.renderer.wiki.AtlassianWikiRenderer">
    <description key="admin.renderer.plugin.wiki.renderer.desc">A renderer that will renderer wiki style syntax into html markup.</description>
    <resource type="velocity" name="css" location="templates/plugins/renderers/wiki/wiki-renderer-css.vm"/>
    <resource type="velocity" name="javascript" location="templates/plugins/renderers/wiki/wiki-renderer-js.vm"/>
    <resource type="velocity" name="edit" location="templates/plugins/renderers/wiki/wiki-renderer-edit.vm"/>
    <java-version min="1.4"/>
</jira-renderer>

and restart the application server in order for the changes to take effect.

[ Permlink | « Hide ]

Paul Curren [Atlassian] added a comment - 14/Jul/08 06:28 PM

Safari Version 3.1.2 (5525.20.1) also affected. Very very annoying. It makes reading issues very difficult since you need to keep scrolling your window horizontally.