[#JRA-12720] Component is always swapped while being deleted

JIRA

Component is always swapped while being deleted

Created: 13/May/07 11:14 PM Updated: 22/May/07 02:31 AM

Component/s:

None

Affects Version/s:

3.9

Fix Version/s:

3.9.1

Time Tracking:

Not Specified

File Attachments:

jira-patch-150507-JRA-12720.zip (10 kB)
2.

jira-patch-220507-JRA-12720-JIRA3_8_1.zip (10 kB)

Participants:	Andreas Knecht [Atlassian], Anton Mazkovoi [Atlassian], Ivo Verlaek and Kay Nny Lee [Atlassian]
Since last comment:	1 year, 20 weeks, 5 days ago
Resolution Date:	22/May/07 02:31 AM
Labels:

Description

« Hide

When a component is being deleted, it will always be swapped to the component selected in the combo box, ignoring the "Remove component from all issues" option.

Something has gone wrong with the checking:

if(swapComponentId != null)
{
  // ...

It should be doing this instead:

if(action.equalsIgnoreCase("swap") && swapComponentId != null)
{
  // ...

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Andreas Knecht [Atlassian] added a comment - 15/May/07 01:48 AM

This has now been fixed for JIRA 3.9.1. Components will be removed properly with a ChangeHistory item if the 'Remove Component' option is selected.

If you can't wait for JIRA 3.9.1 the attached patch should fix things. Instructions for applying the patch:
If you are using JIRA Standalone please do the following:

Download and unzip the attached zip file.
Copy the files to <jira_install_dir>/atlassian-jira/WEB-INF/classes/ overwriting the files there
Restart JIRA

If you are using the WAR distribution of JIRA:

Download files and unzip the attached zip file
Copy the files to <jira_install_dir>/webapp/WEB-INF/classes/ overwriting the files there
Run 'build.sh clean' on unix or 'build.bat clean' on windows
Run 'build.sh' on unix or 'build.bat' on windows
Redeploy the JIRA web app into your application server
Restart the application server

The patch contains the following three classes:

com/atlassian/jira/bc/project/component/DefaultProjectComponentService.class
com/atlassian/jira/bc/project/component/ProjectComponentService.class
com/atlassian/jira/web/action/project/DeleteComponent.class

[ Permlink | « Hide ]

Ivo Verlaek added a comment - 21/May/07 02:35 AM

Installation of this patch on Version 3.8.1 causes this problem: No component what soever can be deleted.
Reproducable with:

install jira 3.8.1
install jira-patch-150507-~~JRA-12720~~.zip
create project
create component
try to delete this component.

Does this mean the patch is only for JIRA Version 3.9 and no other version?

[ Permlink | « Hide ]

Andreas Knecht [Atlassian] added a comment - 21/May/07 06:34 PM

Hi Ivo,

Sorry about that. This issue was incorrectly opened against JIRA 3.9 by Kay. I wasn't aware of your support issue (which is against 3.8.1). I'll make available the patch for 3.8.1 ASAP.

Cheers,
Andreas

[ Permlink | « Hide ]

Andreas Knecht [Atlassian] added a comment - 21/May/07 07:13 PM

I've now attached a patch that will also work for JIRA 3.8.1. Please let us know if this fixes the problem.

Cheers,
Andreas

[ Permlink | « Hide ]

Andreas Knecht [Atlassian] added a comment - 22/May/07 02:31 AM

Resolving since the new patch should address the 3.8.1 issues.