[#JRA-12491] Caching in integrity checker can make integrity checker corrupt workflow data

JIRA

Caching in integrity checker can make integrity checker corrupt workflow data

Created: 30/Mar/07 02:37 AM Updated: 03/Apr/07 03:02 AM

Component/s:

Integrity Checker

Affects Version/s:

None

Fix Version/s:

3.8.1

Time Tracking:

Not Specified

File Attachments:

WorkflowCurrentStepCheck.class (9 kB)

Participants:	Anton Mazkovoi [Atlassian] and Jed Wesley-Smith [Atlassian]
Since last comment:	1 year, 21 weeks, 2 days ago
Resolution Date:	02/Apr/07 11:15 PM
Labels:

Description

« Hide

When running the "Check workflow current step entries" integrity check (WorkflowCurrentStepCheck) a cache is kept around for project-issuetype-status to current step id mapping to speed up the check.

The problem is that the cache is never flushed, so if a project has been migrated to a different workflow scheme (and hence different workflows) the integrity checker starts falsely detecting errors. If the integrity checker is told to fix errors it corrupts the data, such that issues actually end up on the wrong workflow step. When this happens the issue shows the correct status, but the available workflow actions are wrong.

The current solution is to stop and start JIRA. Then run the integrity checker again to actaully fix the problems. Then restart JIRA again to clear the cache.

All

Comments

Work Log

Change History

Sort Order:

[ Permlink | « Hide ]

Jed Wesley-Smith [Atlassian] added a comment - 02/Apr/07 11:14 PM

removed all caching from this check as it was broken and pointless

[ Permlink | « Hide ]

Jed Wesley-Smith [Atlassian] added a comment - 03/Apr/07 02:48 AM

Attached is the patched WorkflowCurrentStepCheck class. To apply the patch please follow these instructions.

If you are using JIRA Standalone please do the following:

Download the attached WorkflowCurrentStepCheck.class
Copy it to <jira_install_dir>/atlassian-jira/WEB-INF/classes/com/atlassian/jira/appconsistency/integrity/check/ overwriting the file there
Restart JIRA

If you are using the WAR distribution of JIRA:

Download the attached WorkflowCurrentStepCheck.class
Copy it to <jira_install_dir>/webapp/WEB-INF/classes/com/atlassian/jira/appconsistency/integrity/check/ overwriting the file there
Run 'build.sh clean' on unix or 'build.bat clean' on windows
Run 'build.sh' on unix or 'build.bat' on windows
Redeploy the JIRA web app into your application server
Restart the application server

[ Permlink | « Hide ]

Jed Wesley-Smith [Atlassian] added a comment - 03/Apr/07 03:02 AM

Please note that this class should be replaced for all versions from 3.7 and above. It is highly recommended that this patch should be applied. If you are running a version of JIRA pre 3.7 or unpatched 3.7 -> 3.8 you must restart JIRA between finding and fixing the Current Step problems, and again afterwards.