Uploaded image for project: 'Jira Data Center'
  1. Jira Data Center
  2. JRASERVER-11186

apostrophe's in group names are not escaped

    XMLWordPrintable

Details

    • Bug
    • Resolution: Answered
    • Medium
    • None
    • 3.6.5
    • None

    Description

      Upgrade to 3.6.5 caused these exceptions to occur. It's caused by a group with an apostrophe (impoperly used I might add) but it wasn't an issue on 3.6.3:

      2006-09-26 14:10:00,364 ERROR [jira.toolkit.customfield.ParticipantsDAO] org.ofbiz.core.entity.GenericDataSourceException: SQL Exception while executing the following:select distinct(jiraaction.AUTHOR) from jiraaction where jiraaction.issueid = ? and jiraaction.actiontype = 'comment' and (jiraaction.actionlevel is null or jiraaction.actionlevel in ('jira-users','stc-users','qa-engineers','Tier 2 SE's')) (Invalid SQL statement or JDBC escape, terminating ''' not found.)
      org.ofbiz.core.entity.GenericDataSourceException: SQL Exception while executing the following:select distinct(jiraaction.AUTHOR) from jiraaction where jiraaction.issueid = ? and jiraaction.actiontype = 'comment' and (jiraaction.actionlevel is null or jiraaction.actionlevel in ('jira-users','stc-users','qa-engineers','Tier 2 SE's')) (Invalid SQL statement or JDBC escape, terminating ''' not found.)
      at org.ofbiz.core.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:330)
      at org.ofbiz.core.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:302)
      at com.atlassian.jira.toolkit.customfield.ParticipantsDAO.getCommenterNames(ParticipantsDAO.java:110)
      at com.atlassian.jira.toolkit.customfield.ParticipantsCFType.getValueFromIssue(ParticipantsCFType.java:84)
      at com.atlassian.jira.issue.fields.CustomFieldImpl.getValue(CustomFieldImpl.java:212)
      at com.atlassian.jira.issue.IssueImpl.getCustomFieldValue(IssueImpl.java:678)
      at com.atlassian.jira.issue.fields.CustomFieldImpl.getRendererCustomFieldValue(CustomFieldImpl.java:594)
      at com.atlassian.jira.issue.fields.CustomFieldImpl.getViewHtml(CustomFieldImpl.java:688)
      at com.atlassian.jira.issue.fields.CustomFieldImpl.getViewHtml(CustomFieldImpl.java:683)
      at com.atlassian.jira.web.action.issue.ViewIssue.getCustomFieldHtml(ViewIssue.java:1098)
      at sun.reflect.GeneratedMethodAccessor199.invoke(Unknown Source)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
      at java.lang.reflect.Method.invoke(Method.java:324)
      at webwork.util.InjectionUtils$DefaultInjectionImpl.invoke(InjectionUtils.java:61)
      at webwork.util.InjectionUtils.invoke(InjectionUtils.java:52)
      at webwork.util.ValueStack.findValue(ValueStack.java:426)
      at webwork.util.ValueStack.findValue(ValueStack.java:175)
      at webwork.view.taglib.WebWorkBodyTagSupport.findValue(WebWorkBodyTagSupport.java:61)
      at webwork.view.taglib.BasicPropertyTag.doStartTag(BasicPropertyTag.java:54)
      at org.apache.jsp.includes.panels.issue.view_005fcustomfields_jsp._jspx_meth_webwork_property_17(view_005fcustomfields_jsp.java:837)
      at org.apache.jsp.includes.panels.issue.view_005fcustomfields_jsp._jspx_meth_webwork_if_4(view_005fcustomfields_jsp.java:778)
      at org.apache.jsp.includes.panels.issue.view_005fcustomfields_jsp._jspx_meth_webwork_property_14(view_005fcustomfields_jsp.java:738)
      at org.apache.jsp.includes.panels.issue.view_005fcustomfields_jsp._jspx_meth_webwork_iterator_2(view_005fcustomfields_jsp.java:700)
      at org.apache.jsp.includes.panels.issue.view_005fcustomfields_jsp._jspx_meth_webwork_iterator_1(view_005fcustomfields_jsp.java:601)
      at org.apache.jsp.includes.panels.issue.view_005fcustomfields_jsp._jspService(view_005fcustomfields_jsp.java:83)
      at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:324)
      at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
      at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
      at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:704)
      at org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:590)
      at org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:510)
      at org.apache.jasper.runtime.JspRuntimeLibrary.include(JspRuntimeLibrary.java:966)
      at org.apache.jsp.secure.views.issue.viewissue_jsp._jspx_meth_webwork_if_5(viewissue_jsp.java:900)
      at org.apache.jsp.secure.views.issue.viewissue_jsp._jspService(viewissue_jsp.java:202)
      at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:94)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:324)
      at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:292)
      at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:236)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
      at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:704)
      at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:474)
      at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:409)
      at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:312)
      at com.atlassian.jira.web.dispatcher.JiraServletDispatcher.service(JiraServletDispatcher.java:253)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
      at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:704)
      at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:474)
      at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:409)
      at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:312)
      at com.atlassian.jira.servlet.QuickLinkServlet.service(QuickLinkServlet.java:59)
      at javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:237)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
      at com.atlassian.jira.web.filters.AccessLogFilter.doFilter(AccessLogFilter.java:51)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
      at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:119)
      at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:55)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
      at com.atlassian.seraph.filter.SecurityFilter.doFilter(SecurityFilter.java:182)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
      at com.atlassian.seraph.filter.LoginFilter.doFilter(LoginFilter.java:181)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
      at com.atlassian.util.profiling.filters.ProfilingFilter.doFilter(ProfilingFilter.java:132)
      at com.atlassian.jira.web.filters.ProfilingAndErrorFilter.doFilter(ProfilingAndErrorFilter.java:35)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
      at com.atlassian.jira.web.filters.ActionCleanupDelayFilter.doFilter(ActionCleanupDelayFilter.java:39)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
      at com.atlassian.core.filters.AbstractEncodingFilter.doFilter(AbstractEncodingFilter.java:37)
      at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:186)
      at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:157)
      at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:214)
      at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
      at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
      at org.apache.catalina.core.StandardContextValve.invokeInternal(StandardContextValve.java:198)
      at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:152)
      at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
      at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
      at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:137)
      at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
      at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:118)
      at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:102)
      at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
      at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
      at org.apache.catalina.core.StandardValveContext.invokeNext(StandardValveContext.java:104)
      at org.apache.catalina.core.StandardPipeline.invoke(StandardPipeline.java:520)
      at org.apache.catalina.core.ContainerBase.invoke(ContainerBase.java:929)
      at org.apache.coyote.tomcat5.CoyoteAdapter.service(CoyoteAdapter.java:160)
      at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:300)
      at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:374)
      at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:743)
      at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:675)
      at org.apache.jk.common.SocketConnection.runIt(ChannelSocket.java:866)
      at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:683)
      at java.lang.Thread.run(Thread.java:534)
      java.sql.SQLException: Invalid SQL statement or JDBC escape, terminating ''' not found.
      at net.sourceforge.jtds.jdbc.SQLParser.parse(SQLParser.java:1155)
      at net.sourceforge.jtds.jdbc.SQLParser.parse(SQLParser.java:156)
      at net.sourceforge.jtds.jdbc.JtdsPreparedStatement.<init>(JtdsPreparedStatement.java:104)
      at net.sourceforge.jtds.jdbc.ConnectionJDBC2.prepareStatement(ConnectionJDBC2.java:2221)
      at net.sourceforge.jtds.jdbc.ConnectionJDBC2.prepareStatement(ConnectionJDBC2.java:2179)
      at org.apache.commons.dbcp.DelegatingConnection.prepareStatement(DelegatingConnection.java:185)
      at org.apache.commons.dbcp.PoolingDataSource$PoolGuardConnectionWrapper.prepareStatement(PoolingDataSource.java:278)
      at org.ofbiz.core.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:327)
      at org.ofbiz.core.entity.jdbc.SQLProcessor.prepareStatement(SQLProcessor.java:302)
      at com.atlassian.jira.toolkit.customfield.ParticipantsDAO.getCommenterNames(ParticipantsDAO.java:110)
      at com.atlassian.jira.toolkit.customfield.ParticipantsCFType.getValueFromIssue(ParticipantsCFType.java:84)
      at com.atlassian.jira.issue.fields.CustomFieldImpl.getValue(CustomFieldImpl.java:212)

      Attachments

        Activity

          People

            Unassigned Unassigned
            b110dfdb5811 Brian Fox
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: