History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: JRA-10426
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Daniel Hurst
Reporter: Ruediger Jungbeck
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
JIRA

Charcter 0x1a in JIRA comment produces invalid RSS output

Created: 14/Jun/06 03:32 AM   Updated: 18/Oct/06 02:55 AM
Component/s: Web interface
Affects Version/s: 3.3.2
Fix Version/s: 3.7

Time Tracking:
Not Specified

Environment: Standalone
Issue Links:
Reference
 

Participants: Daniel Hurst, Dushan Hanuska [Atlassian], Markus Mueller, Ruediger Jungbeck and Scott Farquhar [Atlassian]
Since last comment: 91 weeks, 4 days ago
Resolution Date: 18/Oct/06 02:55 AM
Labels:


 Description  « Hide
If a EOF character (hex 0x1a) is in an issue comment, the RSS output used by Confluence becomes invalid (it contains &#026).

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Dushan Hanuska [Atlassian] - 15/Jun/06 09:52 PM
Hi Ruediger,

I'd like to ask you couple of questions that help us clarify this issue.

How were you able to enter EOF character in the issue comment?

Did you mean to say that the RSS output used by Confluence becomes invalid, or was it meant to be JIRA, or were you using JIRA's RSS feed in Confluence?

Thanks,
Dushan


Ruediger Jungbeck - 16/Jun/06 02:24 AM
Hi Dushan,

I'm not sure how the comment was entered, but the character was in an email signature file, so I belive the comment was entered via the email interface [I have deleted the comment to make the RSS feed usable again].

We are using the RSS from JIRA in Confluence (via the {jira} macro. Confluence was not able to parse the stream and complains. Next step was to open the rss stream (from the Confluence error message) with the web browser, which also complained about the stream (but with position information).

Ruediger


Dushan Hanuska [Atlassian] - 16/Jun/06 03:04 AM
Hi Ruediger,

Thank you for you valueable input. I am not sure how we can reproduce this but may help the developers find and fix the problem.

On second thought, I know there was a problem that issues created from e-mails that had digital signatures created the issue attachments from the signatures:

http://jira.atlassian.com/browse/JRA-9933

This issue was resolved and will be released in 3.6.3.

Anyway, if you have the email that caused it, could you please attach it? Or alternatively, if you have any ideas how we could reproduce the problem, we would appreciate your input.

Kind regards,
Dushan


Markus Mueller - 19/Jun/06 04:28 AM
Hi,

this is a sample message that should mess up the RSS feed.

Thanks

Markus Mueller RSJ Software GmbH Phone: +49-89-894142-23
mm@rsj.de Industriestr. 10 Fax: +49-89-894142-80
http://www.rsj.de 82110 Germering, Germany


Dushan Hanuska [Atlassian] - 19/Jun/06 06:41 PM
Hi Markus,

I am sorry, but I cannot find that sample message you are talking about. Did you attach it? If you are unable to attach it here, please e-mail it to support and just mention that it is for this issue (JRA-10426).

Thanks,
Dushan


Markus Mueller - 20/Jun/06 02:38 AM
Dushan,

the sample message was the message itself - no attachment. The signature
ends with a 0x1a character (the character right after the word
"Germany"), and this causes an error in the RSS feed (not valid XML).
The error occurs if you insert Jira issues into a confluence space using
the {jira} macro.

Bye
Markus


Dushan Hanuska [Atlassian] - 21/Jun/06 02:58 AM
Hi Marcus,

Thank you for pointing me in the right direction. When I clicked the XML link on this page I could see the error. Moreover, I was able to reproduce the error by entering the 'substitute' character () into the database on my testing instance of JIRA.

The problem seems to be that when the XML is produced the output characters are not checked and therefore invalid characters may "leak out" and break the XML.

What we need to do to fix this is to ensure that the code that is responsible for generation of XML or that includes the XML on issuedetails-rss.jsp filters invalid characters out. The valid XML characters are defined at http://www.w3.org/TR/1998/REC-xml-19980210.html#NT-Char.

Thanks again Marcus and Ruediger. We scheduled to fix this bug in JIRA 3.6.x.

Regards,
Dushan


Scott Farquhar [Atlassian] - 09/Oct/06 09:04 AM
Daniel,

Did you create a test case for this? Were you able to see it fixed in 3.7, or do we still need to look into it?

Scott


Daniel Hurst - 09/Oct/06 08:57 PM
Scott,

I ran the appropriate test for this XML view and included this specific German character. It didn't break as reported here.
However, the issue was created:

  • with the input text as "(Test issue with " + "\u001A" + ")"
  • the XML issue view was displayed as "(Test issue with )"- it left out the character. (I have the German language packs installed.)

I'm not sure if this is expected behaviour.

-Daniel


Scott Farquhar [Atlassian] - 18/Oct/06 02:55 AM
This appears to be fixed with the changes on JRA-10404 in JIRA 3.7