Uploaded image for project: 'FishEye'
  1. FishEye
  2. FE-4757

3.0.2 svn upgrade task can fail when using native javaHL

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Medium
    • 3.0.4, 3.1.0
    • 3.0.3
    • Integrations
    • None

    Description

      An important difference between svnkit and javaHL native is when there are no changepaths in a changeset. svnkit will pass an empty array whereas native javahl will pass a null. This causes a NPE in the upgrade operation when checking for empty changesets:

      2013-07-23 09:57:30,709 ERROR [IncrementalPinger1 <Repo>] fisheye BaseRepositoryScanner-handleSlurpException - Problem processing revisions from repo <Repo> due to class com.cenqua.fisheye.rep.RepositoryClientException - java.lang.NullPointerException
      com.cenqua.fisheye.rep.RepositoryClientException: java.lang.NullPointerException
      	at com.cenqua.fisheye.svn.SvnThrottledClient.executeNoThrottle(SvnThrottledClient.java:163)
      	at com.cenqua.fisheye.svn.SvnThrottledClient.execute(SvnThrottledClient.java:132)
      	at com.cenqua.fisheye.svn.SvnThrottledClient.logMessages(SvnThrottledClient.java:120)
      	at com.atlassian.fisheye.svn.Svn2Scanner.processNonIndexedRange(Svn2Scanner.java:1004)
      	at com.atlassian.fisheye.svn.Svn2Scanner.upgradeCountEmptyChangesets(Svn2Scanner.java:937)
      	at com.atlassian.fisheye.svn.Svn2Scanner.slurpRepository(Svn2Scanner.java:195)
      	at com.atlassian.fisheye.svn.Svn2Scanner.doSlurpTransaction(Svn2Scanner.java:177)
      	at com.cenqua.fisheye.rep.BaseRepositoryScanner.ping(BaseRepositoryScanner.java:85)
      	at com.cenqua.fisheye.rep.BaseRepositoryEngine.doSlurp(BaseRepositoryEngine.java:92)
      	at com.cenqua.fisheye.rep.RepositoryEngine.slurp(RepositoryEngine.java:408)
      	at com.cenqua.fisheye.rep.ping.IndexingPingRequest.doRequest(IndexingPingRequest.java:25)
      	at com.cenqua.fisheye.rep.ping.IncrementalPingRequest.doRequest(IncrementalPingRequest.java:30)
      	at com.cenqua.fisheye.rep.ping.PingRequest.process(PingRequest.java:58)
      	at com.cenqua.fisheye.rep.RepositoryHandle.processPingRequests(RepositoryHandle.java:228)
      	at com.cenqua.fisheye.rep.RepositoryHandle.access$100(RepositoryHandle.java:59)
      	at com.cenqua.fisheye.rep.RepositoryHandle$2.run(RepositoryHandle.java:185)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603)
      	at java.lang.Thread.run(Thread.java:722)
      Caused by: java.lang.NullPointerException
      	at com.atlassian.fisheye.svn.Svn2Scanner$10.singleMessage(Svn2Scanner.java:1009)
      	at org.tigris.subversion.javahl.SVNClient.logMessages(Native Method)
      	at org.tigris.subversion.javahl.SVNClient.logMessages(SVNClient.java:313)
      	at com.cenqua.fisheye.svn.SvnThrottledClient$2.call(SvnThrottledClient.java:124)
      	at com.cenqua.fisheye.svn.SvnThrottledClient$2.call(SvnThrottledClient.java:121)
      	at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
      	at java.util.concurrent.FutureTask.run(FutureTask.java:166)
      	at com.cenqua.fisheye.svn.SvnTask.run(SvnTask.java:32)
      	... 3 more
      

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              cmacneill Conor
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: